Mailing-List: contact dev-help@flink.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flink.apache.org
MIME-Version: 1.0
References: 
 <CAKADb_M6kT1MCN98LA0C6M8h0GrBhOnzmXJOMrDXdZzxGv0NnQ@mail.gmail.com>
In-Reply-To: 
 <CAKADb_M6kT1MCN98LA0C6M8h0GrBhOnzmXJOMrDXdZzxGv0NnQ@mail.gmail.com>
From: =?UTF-8?Q?Gyula_F=C3=B3ra?= <gyula.fora@gmail.com>
Date: Mon, 29 Jun 2015 09:14:44 +0000
Message-ID: 
 <CA+faj9yHfeNfqLtnu-sZpJTCo+Us-CwiB1AZp0aCYpYwTjzMgg@mail.gmail.com>
Subject: Re: Off-by-one issues in the windowing code
To: dev@flink.apache.org
Content-Type: multipart/alternative; boundary=089e0118279cd3c6ba0519a48582

--089e0118279cd3c6ba0519a48582
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

The second issue is related to parallel time based aggregations. I think we
should fix this for 0.9.1.

Also since the fix as you said is rather straight-forward there is no harm
doing it. As I understand if we keep the functionality of having time based
global windows, the implementations for merging the partial aggregates will
be conceptually similar after Aljoscha's update as well.

M=C3=A1rton Balassi <balassi.marton@gmail.com> ezt =C3=ADrta (id=C5=91pont:=
 2015. j=C3=BAn.
29., H, 11:02):

> I have found two off-by-one issues in the windowing code.
>
> The first may result in duplicate data in the last window and is easy to
> fix. [1]
>
> The second may result data being swallowed in the last window, and is als=
o
> not difficult to fix. [2]
>
> I've talked to Aljoscha about fixing the second one, and he suggested not
> to fix it right away as that part should be rewritten soon anyways, maybe
> we remove that functionality as a whole. As this is also in the 0.9.0
> release I would still opt for having it, at least for the sake of 0.9.1.
>
> What do you think?
>
> [1] https://issues.apache.org/jira/browse/FLINK-2285
> [2] https://issues.apache.org/jira/browse/FLINK-2286
>
> Best,
>
> Marton
>

--089e0118279cd3c6ba0519a48582--