flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lokesh Rajaram <rajaram.lok...@gmail.com>
Subject Re: Closing JIRA issues
Date Fri, 05 Jun 2015 15:31:52 GMT
Thanks Marton.

On Fri, Jun 5, 2015 at 8:29 AM, Márton Balassi <balassi.marton@gmail.com>
wrote:

> Hey Lokesh,
>
> The implicit practice is that the committer merging you PR closes the JIRA.
> Please do not close the JIRA, before your patch is merged. If the committer
> forgets to close it after your code is in you are very welcome to close it
> yourself.
>
> Best,
>
> Marton
>
> On Fri, Jun 5, 2015 at 5:24 PM, Lokesh Rajaram <rajaram.lokesh@gmail.com>
> wrote:
>
> > Hello,
> >
> > Typically when a pull request is accepted for a JIRA issue, can I close
> the
> > JIRA or should I wait for pull request reviewer to close the issue. it's
> > done differently in various teams/projects. Just would like to know how
> > it's done here in Flink project so that I can follow for future pull
> > requests.
> >
> > Thanks,
> > Lokesh
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message