flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Márton Balassi <balassi.mar...@gmail.com>
Subject Re: Too many log4j.properties files
Date Fri, 10 Apr 2015 13:11:15 GMT
+1 for Robert's suggestion.

On Fri, Apr 10, 2015 at 2:49 PM, Robert Metzger <rmetzger@apache.org> wrote:

> I agree that we are currently in a bad situation with the log4j.properties
> files.
> They should certainly not be in any JAR file we deploy to maven central.
>
> On the other hand, not having any log4j configuration files with default
> level set to INFO is costing me a lot of time and energy. Every time I want
> to run an example, some tests or start the Jobmanager out of the IDE, I
> have to copy a configuration file from somewhere or set the log level.
>
>
> Therefore, I propose to add a "log4j.properties" file to every maven module
> (in main, not test) with the log level set in INFO and exclude them using
> the maven-shade-plugin (we need to add the exclude only in the
> "flink-parent" and "flink-dist"). I would remove all the
> log4j-test.properties (it should not be an issue to log on INFO locally and
> for travis, we are using a different log4j configuration anyways).
>
> On Mon, Apr 6, 2015 at 9:01 PM, Stephan Ewen <sewen@apache.org> wrote:
>
> > Hi all!
> >
> > I see that a lot of people are committing log4j.properties files in the
> > compile scope of various projects. By now, when you start a flink
> > application, you have multiple log4j.properties files in the classpath.
> >
> > ./flink-examples/flink-java-examples/src/main/resources/log4j.properties
> > ./flink-runtime/src/main/resources/log4j.properties
> > ./flink-staging/flink-tez/src/main/resources/log4j.properties
> >
> > That is certainly not how it should be. There should be none in there, it
> > messes with all assumptions considering log configurations.
> >
> > For tests, there are even more log config files in the classpath
> >
> >
> >
> ./flink-staging/flink-streaming/flink-streaming-core/src/test/resources/log4j.properties
> > ./flink-staging/flink-hbase/src/test/resources/log4j.properties
> > ./flink-staging/flink-tachyon/src/test/resources/log4j.properties
> >
> > Please remove these files and pay attention to not commit these files,
> they
> > make it hard for anyone to actually want to debug based on log output to
> > configure the logging.
> >
> > Greetings,
> > Stephan
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message