flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Dulaj Viduranga <vidura...@icloud.com>
Subject Re: Could not build up connection to JobManager
Date Thu, 05 Mar 2015 03:21:10 GMT
The every change in the commit b7da22a is not required but I thought they are appropriate.

> On Mar 5, 2015, at 8:11 AM, Dulaj Viduranga <vidura.me@icloud.com> wrote:
> 
> Hi,
> I found many other places “localhost” is hard coded. I changed them in a better way
I think. I made a pull request. Please review. b7da22a <https://github.com/viduranga/flink/commit/b7da22a562d3da5a9be2657308c0f82e4e2f80cd>
> 
>> On Mar 4, 2015, at 8:17 PM, Stephan Ewen <sewen@apache.org> wrote:
>> 
>> If I recall correctly, we only hardcode "localhost" in the local mini
>> cluster - do you think it is problematic there as well?
>> 
>> Have you found any other places?
>> 
>> On Mon, Mar 2, 2015 at 10:26 AM, Dulaj Viduranga <vidura.me@icloud.com>
>> wrote:
>> 
>>> In some places of the code, "localhost" is hard coded. When it is resolved
>>> by the DNS, it is posible to be directed  to a different IP other than
>>> 127.0.0.1 (like private range 10.0.0.0/8). I changed those places to
>>> 127.0.0.1 and it works like a charm.
>>> But hard coding 127.0.0.1 is not a good option because when the jobmanager
>>> ip is changed, this becomes an issue again. I'm thinking of setting
>>> jobmanager ip from the config.yaml to these places.
>>> If you have a better idea on doing this with your experience, please let
>>> me know.
>>> 
>>> Best.
>>> 
> 


Mime
View raw message