flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henry Saputra <henry.sapu...@gmail.com>
Subject [DISCUSS] Submitting small PRs rather than massive ones
Date Wed, 18 Mar 2015 18:37:14 GMT
Hi All,

Recently there have been some PRs with massive changes which include
multiple JIRA tickets.

It is getting tougher to review and also to back port changes if needed.

To help reviewers to help review the changes lets try to submit small
but often PRs to make it easier to review.
Not to mention Github UI suffers with diff changes over 200 files and
thousands lines of code changes =)

When committing to ASF git it should be fine to combine one day of
work but PRs should as isolated as possible.

Exception such as new module like Gelly or ML maybe ok, but others
that require changes to the execution flow should be done if smaller
batches if possible.

Thanks,

Henry

Mime
View raw message