flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Metzger <rmetz...@apache.org>
Subject Re: "Validate" (commons) versus "checkArgument" (guava)
Date Thu, 26 Mar 2015 09:49:32 GMT
I created a "starter" task JIRA for this.
https://issues.apache.org/jira/browse/FLINK-1787


On Sun, Mar 8, 2015 at 3:23 PM, Aljoscha Krettek <aljoscha@apache.org>
wrote:

> +1 I also tend to use guava.
>
> On Sun, Mar 8, 2015 at 3:21 PM, Ufuk Celebi <uce@apache.org> wrote:
> >
> > On 08 Mar 2015, at 15:05, Stephan Ewen <sewen@apache.org> wrote:
> >
> >> Different parts of the code currently use different utilities to
> validate
> >> the arguments.
> >>
> >>  - Some parts use Guava (checkNotNull, checkArgument)
> >>  - Other parts use Validate from Apache commons-lang(3).
> >>
> >> How about we use one consistently, at least for all new code additions?
> >>
> >> In choosing one, I have a slight bias towards Guava, which has
> more/nicer
> >> methods and seems more popular in other projects (I have no source to
> back
> >> this up, it is a gut feeling from what I have seen in other projects
> that I
> >> looked into)
> >
> > +1 I'm always using Guava for the same reasons.
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message