flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Rohrmann <trohrm...@apache.org>
Subject Re: [DISCUSS] Issues with heterogeneity of the code
Date Mon, 16 Mar 2015 16:37:05 GMT
Do we already enforce the official Scala style guide strictly?

On Mon, Mar 16, 2015 at 4:57 PM, Aljoscha Krettek <aljoscha@apache.org>
wrote:

> I'm already always sticking to the official Scala style guide, with the
> exception of 100 line length.
> On Mar 16, 2015 3:27 PM, "Till Rohrmann" <trohrmann@apache.org> wrote:
>
> > +1 for stricter Java code styles. I haven't looked into the Google Code
> > Style but maybe we make it easier for new contributors if we apply a
> coding
> > style which is somehow known.
> >
> > +1 for line length of 100 for Scala code. I think it makes code review on
> > GitHub easier.
> >
> > For the Scala style, we could stick to official style guidelines [1].
> >
> > [1] http://docs.scala-lang.org/style/
> >
> > On Mon, Mar 16, 2015 at 3:06 PM, Hermann Gábor <reckoner42@gmail.com>
> > wrote:
> >
> > > +1 for the stricter Java code styles.
> > >
> > > We should not forget about providing code formatter settings for
> Eclipse
> > > and Intellij IDEA (as mentioned above).
> > > That would help a lot.
> > >
> > > (Of course if we'll use Google Code Style, they already provide such
> > files
> > > <
> > >
> >
> https://code.google.com/p/google-styleguide/source/browse/trunk/intellij-java-google-style.xml
> > > >
> > > .)
> > >
> > > On Mon, Mar 16, 2015 at 2:45 PM Alexander Alexandrov <
> > > alexander.s.alexandrov@gmail.com> wrote:
> > >
> > > > +1 for not limiting the line length.
> > > >
> > > > 2015-03-16 14:39 GMT+01:00 Stephan Ewen <sewen@apache.org>:
> > > >
> > > > > +1 for not limiting the line length. Everyone should have a good
> > sense
> > > to
> > > > > break lines. When in exceptional cases people violate this, it is
> > > usually
> > > > > for a good reason.
> > > > >
> > > > > On Mon, Mar 16, 2015 at 2:18 PM, Maximilian Michels <
> mxm@apache.org>
> > > > > wrote:
> > > > >
> > > > > > +1 for enforcing a more strict Java code style. However, let's
> not
> > > > > > introduce a line legth of 100 like in Scala. I think that's
> hurting
> > > > > > readability of the code.
> > > > > >
> > > > > > On Sat, Mar 14, 2015 at 4:41 PM, Ufuk Celebi <uce@apache.org>
> > wrote:
> > > > > >
> > > > > > > On Saturday, March 14, 2015, Aljoscha Krettek <
> > aljoscha@apache.org
> > > >
> > > > > > wrote:
> > > > > > >
> > > > > > > > I'm in favor of strict coding styles. And I like the
google
> > > style.
> > > > > > >
> > > > > > >
> > > > > > > +1 I would like that. We essentially all agree that we
want
> more
> > > > > > > homogeneity and I think strict rules are the only way to
go.
> > Since
> > > > this
> > > > > > is
> > > > > > > a very subjective matter it makes sense to go with something
> > > > (somewhat)
> > > > > > > well
> > > > > > > established like the Google code style.
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message