flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Max Michels <...@data-artisans.com>
Subject Re: Master not building and how to notice it faster in the future
Date Wed, 21 Jan 2015 12:46:13 GMT
@Robert The pre-push hook only resides in your local repository. It
cannot be pushed. Thus, we cannot enforce this check but it certainly
helps to prevent mistakes. As Ufuk mentioned, you can then even skip
the check with the --no-verify option if you're really sure.

On Wed, Jan 21, 2015 at 11:45 AM, Ufuk Celebi <uce@apache.org> wrote:
>
> On 21 Jan 2015, at 11:40, Robert Metzger <rmetzger@apache.org> wrote:
>
>> Is the git hook something we can control for everybody? I thought its more
>> like a personal thing everybody can set up if wanted?
>>
>> I'm against enforcing something like this for every committer. I don't want
>> to wait for 15 minutes for pushing a typo fix to the documentation.
>
> Sorry, I didn't mean to have it in the repo. As long as we notice failing builds fast
enough (aka email notification), it should be OK to keep it that way. As you said, every committer
should decide this on her own. BTW You can always skip hooks with git push -n (--no-verify).

Mime
View raw message