Return-Path: X-Original-To: apmail-flink-dev-archive@www.apache.org Delivered-To: apmail-flink-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 0635911366 for ; Fri, 27 Jun 2014 15:57:52 +0000 (UTC) Received: (qmail 48490 invoked by uid 500); 27 Jun 2014 15:57:52 -0000 Delivered-To: apmail-flink-dev-archive@flink.apache.org Received: (qmail 48440 invoked by uid 500); 27 Jun 2014 15:57:51 -0000 Mailing-List: contact dev-help@flink.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.incubator.apache.org Delivered-To: mailing list dev@flink.incubator.apache.org Received: (qmail 48428 invoked by uid 99); 27 Jun 2014 15:57:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 15:57:51 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.3] (HELO mail.apache.org) (140.211.11.3) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 27 Jun 2014 15:57:53 +0000 Received: (qmail 48206 invoked by uid 99); 27 Jun 2014 15:57:27 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 27 Jun 2014 15:57:27 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 5A0A598F136; Fri, 27 Jun 2014 15:57:27 +0000 (UTC) From: zentol To: dev@flink.incubator.apache.org Reply-To: dev@flink.incubator.apache.org References: In-Reply-To: Subject: [GitHub] incubator-flink pull request: FIX-FLINK-888-swapValues() for Tuple... Content-Type: text/plain Message-Id: <20140627155727.5A0A598F136@tyr.zones.apache.org> Date: Fri, 27 Jun 2014 15:57:27 +0000 (UTC) X-Virus-Checked: Checked by ClamAV on apache.org Github user zentol commented on the pull request: https://github.com/apache/incubator-flink/pull/44#issuecomment-47366280 if you use ```Assert.assertEquals(fullTuple2.f0, swappedTuple2.f1)``` the test will fail if they are not the same, just as your current code. you save six lines, and it's more obvious what you want to check. your test is supposed to make sure that the swapped values are equal, thus you should check exactly that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---