flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Fabian Hueske (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-931) Remove redundant (old) operator tests
Date Thu, 12 Jun 2014 18:33:02 GMT

    [ https://issues.apache.org/jira/browse/FLINK-931?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14029561#comment-14029561
] 

Fabian Hueske commented on FLINK-931:
-------------------------------------

The old tests are NOT subsumed by the new tests.
The tests under eu.stratosphere.test.operators test all physical execution strategies for
each (basic) operator. The tests under eu.stratosphere.test.japiOperators basically test that
the transformation before the optimization and the optimizer postpass are working correctly
(assembly of program, serializers and comparators). They do not run all physical strategies.

I would leave the tests in place as they are.

> Remove redundant (old) operator tests
> -------------------------------------
>
>                 Key: FLINK-931
>                 URL: https://issues.apache.org/jira/browse/FLINK-931
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Minor
>
> I would remove all tests in the package "eu.stratosphere.test.operators".
> There are many tests in "eu.stratosphere.test.javaApiOperators" that cover the same operator
code paths.
> The redundant tests take a lot of time without really adding test coverage.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Mime
View raw message