flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From zentol <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: FIX-FLINK-888-swapValues() for Tuple...
Date Fri, 27 Jun 2014 15:57:27 GMT
Github user zentol commented on the pull request:

    https://github.com/apache/incubator-flink/pull/44#issuecomment-47366280
  
    if you use ```Assert.assertEquals(fullTuple2.f0, swappedTuple2.f1)``` the test will fail
if they are not the same, just as your current code. you save six lines, and it's more obvious
what you want to check.
    
    your test is supposed to make sure that the swapped values are equal, thus you should
check exactly that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message