flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: FIX-FLINK-888-swapValues() for Tuple...
Date Fri, 27 Jun 2014 11:47:14 GMT
Github user uce commented on a diff in the pull request:

    https://github.com/apache/incubator-flink/pull/44#discussion_r14288993
  
    --- Diff: stratosphere-java/src/test/java/eu/stratosphere/api/java/tuple/Tuple2Test.java
---
    @@ -0,0 +1,43 @@
    +/***********************************************************************************************************************
    + *
    + * Copyright (C) 2010-2013 by the Stratosphere project (http://stratosphere.eu)
    + *
    + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this
file except in compliance with
    + * the License. You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software distributed under
the License is distributed on
    + * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or
implied. See the License for the
    + * specific language governing permissions and limitations under the License.
    + *
    + **********************************************************************************************************************/
    +
    +package eu.stratosphere.api.java.tuple;
    +
    +import junit.framework.Assert;
    +
    +import org.junit.Test;
    +
    +public class Tuple2Test {
    +	
    +
    +	@Test
    +	public void testSwapValues() {
    +		Tuple2<String, Integer> fullTuple2 = new Tuple2<String, Integer>(new String("Test
case"), 25);
    +		//Swapped tuple for comparison
    +		Tuple2<Integer, String> swappedTuple2 = fullTuple2.swapValues();
    +		
    +		// Assert when not the same
    +		// Use overloaded equals method to check for equality. Especially important for String.
    +		if(!swappedTuple2.f1.equals(fullTuple2.getField(0))) {
    --- End diff --
    
    Can't you just use JUnit's assertEquals, i.e. `Assert.assertEquals(fullTuple2.f0, swappedTuple2.f1)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message