flink-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From uce <...@git.apache.org>
Subject [GitHub] incubator-flink pull request: [FLINK-758] Add initial value to Gen...
Date Wed, 18 Jun 2014 17:48:58 GMT
Github user uce commented on the pull request:

    https://github.com/apache/incubator-flink/pull/20#issuecomment-46469440
  
    I also find it clumsy. Will change it as you suggested. I'm not sure why I didn't think
of this myself. 
    
    Sent from my iPhone
    
    > On 18 Jun 2014, at 19:32, Stephan Ewen <notifications@github.com> wrote:
    > 
    > Why do you add the "setInitialValue()" method to the reduce function? I think that
is a bit clumsy. Is that for getting the value into the runtime?
    > 
    > Why not add it as part of the user parameters? That keeps the user-facing APIs clean.
    > 
    > —
    > Reply to this email directly or view it on GitHub.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message