From commits-return-15832-archive-asf-public=cust-asf.ponee.io@flink.apache.org Sun Feb 18 10:13:58 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id A13AB1807A1 for ; Sun, 18 Feb 2018 10:13:57 +0100 (CET) Received: (qmail 12475 invoked by uid 500); 18 Feb 2018 09:13:56 -0000 Mailing-List: contact commits-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list commits@flink.apache.org Received: (qmail 12350 invoked by uid 99); 18 Feb 2018 09:13:56 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 18 Feb 2018 09:13:56 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 2AD33F2190; Sun, 18 Feb 2018 09:13:54 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: trohrmann@apache.org To: commits@flink.apache.org Date: Sun, 18 Feb 2018 09:13:57 -0000 Message-Id: In-Reply-To: <11b9577832704e4ab0f216691f93b6f0@git.apache.org> References: <11b9577832704e4ab0f216691f93b6f0@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [4/9] flink git commit: [hotfix] Only log retrying exception on debug in RetryingRegistration [hotfix] Only log retrying exception on debug in RetryingRegistration Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/ca9ee35c Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/ca9ee35c Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/ca9ee35c Branch: refs/heads/master Commit: ca9ee35c12e902c58d5d5d8077da258663386487 Parents: 24c2429 Author: Till Rohrmann Authored: Thu Feb 8 10:27:27 2018 +0100 Committer: Till Rohrmann Committed: Sun Feb 18 10:12:53 2018 +0100 ---------------------------------------------------------------------- .../runtime/registration/RetryingRegistration.java | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/ca9ee35c/flink-runtime/src/main/java/org/apache/flink/runtime/registration/RetryingRegistration.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/registration/RetryingRegistration.java b/flink-runtime/src/main/java/org/apache/flink/runtime/registration/RetryingRegistration.java index 279714b..6959729 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/registration/RetryingRegistration.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/registration/RetryingRegistration.java @@ -207,7 +207,22 @@ public abstract class RetryingRegistration { if (failure != null && !canceled) { - log.warn("Could not resolve {} address {}, retrying in {} ms", targetName, targetAddress, delayOnError, failure); + final Throwable strippedFailure = ExceptionUtils.stripCompletionException(failure); + if (log.isDebugEnabled()) { + log.debug( + "Could not resolve {} address {}, retrying in {} ms.", + targetName, + targetAddress, + delayOnError, + strippedFailure); + } else { + log.info( + "Could not resolve {} address {}, retrying in {} ms: {}.", + targetName, + targetAddress, + delayOnError, + strippedFailure.getMessage()); + } startRegistrationLater(delayOnError); }