flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ches...@apache.org
Subject [1/4] flink git commit: [FLINK-8621][prometheus][tests] Remove endpointIsUnavailableAfterReporterIsClosed()
Date Tue, 20 Feb 2018 15:48:49 GMT
Repository: flink
Updated Branches:
  refs/heads/release-1.4 528317c8f -> a7df42485


[FLINK-8621][prometheus][tests] Remove endpointIsUnavailableAfterReporterIsClosed()

The test is inherently unstable as it will always fail if any other
server is started on the port between the closing of the reporter and
the polling of metrics.

This closes #5473.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/45efe470
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/45efe470
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/45efe470

Branch: refs/heads/release-1.4
Commit: 45efe4702ac1d932afa1b322e93264c28aefbc4a
Parents: 528317c
Author: zentol <chesnay@apache.org>
Authored: Tue Feb 13 10:31:31 2018 +0100
Committer: zentol <chesnay@apache.org>
Committed: Tue Feb 20 16:48:25 2018 +0100

----------------------------------------------------------------------
 .../flink/metrics/prometheus/PrometheusReporterTest.java    | 9 ---------
 1 file changed, 9 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/45efe470/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
----------------------------------------------------------------------
diff --git a/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
b/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
index 6704189..1a70865 100644
--- a/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
+++ b/flink-metrics/flink-metrics-prometheus/src/test/java/org/apache/flink/metrics/prometheus/PrometheusReporterTest.java
@@ -157,15 +157,6 @@ public class PrometheusReporterTest extends TestLogger {
 	}
 
 	@Test
-	public void endpointIsUnavailableAfterReporterIsClosed() throws UnirestException {
-		MetricRegistryImpl registry = new MetricRegistryImpl(MetricRegistryConfiguration.fromConfiguration(createConfigWithOneReporter("test1",
"9400-9500")));
-		PrometheusReporter reporter = (PrometheusReporter) registry.getReporters().get(0);
-		reporter.close();
-		thrown.expect(UnirestException.class);
-		pollMetrics(reporter.getPort());
-	}
-
-	@Test
 	public void invalidCharactersAreReplacedWithUnderscore() {
 		assertThat(PrometheusReporter.replaceInvalidChars(""), equalTo(""));
 		assertThat(PrometheusReporter.replaceInvalidChars("abc"), equalTo("abc"));


Mime
View raw message