flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ches...@apache.org
Subject flink git commit: [FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase
Date Mon, 04 Dec 2017 14:56:20 GMT
Repository: flink
Updated Branches:
  refs/heads/release-1.4 cfd1b787b -> a86cb885c


[FLINK-8148][yarn/s3] fix test instability in YarnFileStageTestS3ITCase

Remove a check for a deleted directory since we may not see our own delete yet
with S3.

This closes #5066.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/a86cb885
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/a86cb885
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/a86cb885

Branch: refs/heads/release-1.4
Commit: a86cb885ce0ed4255354cf0012c7e7e5d88777e6
Parents: cfd1b78
Author: Nico Kruber <nico@data-artisans.com>
Authored: Fri Nov 24 14:54:41 2017 +0100
Committer: zentol <chesnay@apache.org>
Committed: Mon Dec 4 15:56:10 2017 +0100

----------------------------------------------------------------------
 .../src/test/java/org/apache/flink/yarn/YarnFileStageTest.java   | 2 +-
 .../java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java    | 4 ----
 2 files changed, 1 insertion(+), 5 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/a86cb885/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
----------------------------------------------------------------------
diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
index 4d38253..5cbe1be 100644
--- a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
+++ b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTest.java
@@ -139,7 +139,7 @@ public class YarnFileStageTest extends TestLogger {
 	 * @param addSchemeToLocalPath
 	 * 		whether add the <tt>file://</tt> scheme to the local path to copy from
 	 */
-	public static void testCopyFromLocalRecursive(
+	static void testCopyFromLocalRecursive(
 			FileSystem targetFileSystem,
 			Path targetDir,
 			TemporaryFolder tempFolder,

http://git-wip-us.apache.org/repos/asf/flink/blob/a86cb885/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
----------------------------------------------------------------------
diff --git a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
index 74fb596..e1e95b1 100644
--- a/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
+++ b/flink-yarn/src/test/java/org/apache/flink/yarn/YarnFileStageTestS3ITCase.java
@@ -42,7 +42,6 @@ import java.util.Map;
 import java.util.UUID;
 
 import static org.hamcrest.Matchers.greaterThan;
-import static org.junit.Assert.assertFalse;
 import static org.junit.Assert.assertThat;
 import static org.junit.Assume.assumeFalse;
 import static org.junit.Assume.assumeNoException;
@@ -166,9 +165,6 @@ public class YarnFileStageTestS3ITCase extends TestLogger {
 
 			YarnFileStageTest.testCopyFromLocalRecursive(fs.getHadoopFileSystem(),
 				new org.apache.hadoop.fs.Path(directory.toUri()), tempFolder, true);
-
-			// now directory must be gone
-			assertFalse(fs.exists(directory));
 		} finally {
 			// clean up
 			fs.delete(basePath, true);


Mime
View raw message