flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ches...@apache.org
Subject [3/7] flink git commit: [FLINK-7845][runtime] Make NettyMessage public
Date Tue, 14 Nov 2017 14:15:35 GMT
[FLINK-7845][runtime] Make NettyMessage public

This a walkaround strange javaassist bug. The issue should go away
once we upgrade netty dependency.

Please check the ticket for more information.

This closes #5007.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/6f9ab721
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/6f9ab721
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/6f9ab721

Branch: refs/heads/release-1.4
Commit: 6f9ab7217266f5458263fdd976214c1b4c552576
Parents: 8b7698d
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Authored: Mon Nov 13 16:51:18 2017 +0100
Committer: zentol <chesnay@apache.org>
Committed: Tue Nov 14 15:15:14 2017 +0100

----------------------------------------------------------------------
 .../org/apache/flink/runtime/io/network/netty/NettyMessage.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/6f9ab721/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
index e73f61d..89fb9e8 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/NettyMessage.java
@@ -52,8 +52,11 @@ import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
  * A simple and generic interface to serialize messages to Netty's buffer space.
+ *
+ * <p>This class must be public as long as we are using a Netty version prior to 4.0.45.
Please check FLINK-7845 for
+ * more information.
  */
-abstract class NettyMessage {
+public abstract class NettyMessage {
 
 	// ------------------------------------------------------------------------
 	// Note: Every NettyMessage subtype needs to have a public 0-argument


Mime
View raw message