flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trohrm...@apache.org
Subject [2/2] flink git commit: [hotfix] [tests] Remove AbstractTestBase from CsvOutputFormatITCase and TextOutputFormatITCase
Date Tue, 24 Oct 2017 15:16:46 GMT
[hotfix] [tests] Remove AbstractTestBase from CsvOutputFormatITCase and TextOutputFormatITCase


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/b0010888
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/b0010888
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/b0010888

Branch: refs/heads/master
Commit: b00108880a75d6a4acd52409adbdfe11b0d5b90e
Parents: 904c951
Author: Till Rohrmann <trohrmann@apache.org>
Authored: Mon Oct 23 17:15:07 2017 +0200
Committer: Till Rohrmann <trohrmann@apache.org>
Committed: Tue Oct 24 17:16:29 2017 +0200

----------------------------------------------------------------------
 .../streaming/scala/api/CsvOutputFormatITCase.java    | 14 ++------------
 .../streaming/scala/api/TextOutputFormatITCase.java   | 14 ++------------
 2 files changed, 4 insertions(+), 24 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/b0010888/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/CsvOutputFormatITCase.java
----------------------------------------------------------------------
diff --git a/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/CsvOutputFormatITCase.java
b/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/CsvOutputFormatITCase.java
index b5a6f47..fb7c765 100644
--- a/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/CsvOutputFormatITCase.java
+++ b/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/CsvOutputFormatITCase.java
@@ -17,12 +17,10 @@
 
 package org.apache.flink.streaming.scala.api;
 
-import org.apache.flink.configuration.Configuration;
 import org.apache.flink.core.fs.FileSystem;
 import org.apache.flink.streaming.api.scala.OutputFormatTestPrograms;
 import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase;
 import org.apache.flink.test.testdata.WordCountData;
-import org.apache.flink.test.util.AbstractTestBase;
 
 import org.junit.After;
 import org.junit.Before;
@@ -40,17 +38,10 @@ public class CsvOutputFormatITCase extends StreamingMultipleProgramsTestBase
 {
 
 	protected String resultPath;
 
-	public AbstractTestBase fileInfo = new AbstractTestBase(new Configuration()) {
-		@Override
-		public void startCluster() throws Exception {
-			super.startCluster();
-		}
-	};
-
 	@Before
 	public void createFile() throws Exception {
-		File f = fileInfo.createAndRegisterTempFile("result");
-		resultPath = f.toURI().toString();
+		File resultFile = createAndRegisterTempFile("result");
+		resultPath = resultFile.toURI().toString();
 	}
 
 	@Test
@@ -115,7 +106,6 @@ public class CsvOutputFormatITCase extends StreamingMultipleProgramsTestBase
 {
 	public void closeFile() throws Exception {
 		compareResultsByLinesInMemory(WordCountData.STREAMING_COUNTS_AS_TUPLES
 				.replaceAll("[\\\\(\\\\)]", ""), resultPath);
-		fileInfo.stopCluster();
 	}
 }
 

http://git-wip-us.apache.org/repos/asf/flink/blob/b0010888/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/TextOutputFormatITCase.java
----------------------------------------------------------------------
diff --git a/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/TextOutputFormatITCase.java
b/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/TextOutputFormatITCase.java
index 00452fb..84b81e2 100644
--- a/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/TextOutputFormatITCase.java
+++ b/flink-streaming-scala/src/test/java/org/apache/flink/streaming/scala/api/TextOutputFormatITCase.java
@@ -17,12 +17,10 @@
 
 package org.apache.flink.streaming.scala.api;
 
-import org.apache.flink.configuration.Configuration;
 import org.apache.flink.core.fs.FileSystem;
 import org.apache.flink.streaming.api.scala.OutputFormatTestPrograms;
 import org.apache.flink.streaming.util.StreamingMultipleProgramsTestBase;
 import org.apache.flink.test.testdata.WordCountData;
-import org.apache.flink.test.util.AbstractTestBase;
 
 import org.junit.After;
 import org.junit.Before;
@@ -40,17 +38,10 @@ public class TextOutputFormatITCase extends StreamingMultipleProgramsTestBase
{
 
 	protected String resultPath;
 
-	public AbstractTestBase fileInfo = new AbstractTestBase(new Configuration()) {
-		@Override
-		public void startCluster() throws Exception {
-			super.startCluster();
-		}
-	};
-
 	@Before
 	public void createFile() throws Exception {
-		File f = fileInfo.createAndRegisterTempFile("result");
-		resultPath = f.toURI().toString();
+		File resultFile = createAndRegisterTempFile("result");
+		resultPath = resultFile.toURI().toString();
 	}
 
 	@Test
@@ -77,7 +68,6 @@ public class TextOutputFormatITCase extends StreamingMultipleProgramsTestBase
{
 	@After
 	public void closeFile() throws Exception {
 		compareResultsByLinesInMemory(WordCountData.STREAMING_COUNTS_AS_TUPLES, resultPath);
-		fileInfo.stopCluster();
 	}
 
 }


Mime
View raw message