flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trohrm...@apache.org
Subject flink git commit: [hotfix] [rpc] Add more logging for endpoint shutdown
Date Wed, 11 Oct 2017 12:29:06 GMT
Repository: flink
Updated Branches:
  refs/heads/master 7697a3254 -> 7b9967005


[hotfix] [rpc] Add more logging for endpoint shutdown


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/7b996700
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/7b996700
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/7b996700

Branch: refs/heads/master
Commit: 7b99670053a1c76bb3134829e456037d42af5029
Parents: 7697a32
Author: Till Rohrmann <trohrmann@apache.org>
Authored: Wed Oct 11 14:28:42 2017 +0200
Committer: Till Rohrmann <trohrmann@apache.org>
Committed: Wed Oct 11 14:28:42 2017 +0200

----------------------------------------------------------------------
 .../java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java  | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/7b996700/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
index 2d98552..4ad7e70 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/rpc/akka/AkkaRpcService.java
@@ -309,7 +309,7 @@ public class AkkaRpcService implements RpcService {
 
 			if (fromThisService) {
 				ActorRef selfActorRef = akkaClient.getActorRef();
-				LOG.info("Trigger shut down of RPC endpoint {}.", selfActorRef.path());
+				LOG.info("Trigger shut down of RPC endpoint {}.", selfGateway.getAddress());
 
 				CompletableFuture<Boolean> akkaTerminationFuture = FutureUtils.toJava(
 					Patterns.gracefulStop(
@@ -324,11 +324,12 @@ public class AkkaRpcService implements RpcService {
 					.whenComplete(
 						(Boolean terminated, Throwable throwable) -> {
 							if (throwable != null) {
-								LOG.debug("Graceful RPC endpoint shutdown failed.", throwable);
+								LOG.debug("Graceful RPC endpoint shutdown failed. Shutting endpoint down hard now.",
throwable);
 
 								actorSystem.stop(selfActorRef);
 								selfGateway.getTerminationFuture().completeExceptionally(throwable);
 							} else {
+								LOG.info("RPC endpoint {} has been shut down.", selfGateway.getAddress());
 								selfGateway.getTerminationFuture().complete(null);
 							}
 						});


Mime
View raw message