flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From se...@apache.org
Subject [06/10] flink git commit: [FLINK-7739] [kafka connector] Fix test instabilities
Date Sun, 08 Oct 2017 19:38:16 GMT
[FLINK-7739] [kafka connector] Fix test instabilities

  - Set shorter heartbeats intervals. Default pause value of 60seconds is
    too large (tests would timeout before akka react)

  - Exclude netty dependency from zookeeper. Zookeeper was pulling in
    conflicting Netty version. Conflict was extremly subtle - TaskManager in
    Kafka tests was deadlocking in some rare corner cases.

This closes #4775


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/3581a335
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/3581a335
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/3581a335

Branch: refs/heads/master
Commit: 3581a3350892a5c584a617d1b66cffdada4e17dd
Parents: a8443a5
Author: Piotr Nowojski <piotr.nowojski@gmail.com>
Authored: Fri Sep 29 18:23:29 2017 +0200
Committer: Stephan Ewen <sewen@apache.org>
Committed: Fri Oct 6 20:12:51 2017 +0200

----------------------------------------------------------------------
 .../apache/flink/streaming/connectors/kafka/KafkaTestBase.java | 3 +++
 pom.xml                                                        | 6 ++++++
 2 files changed, 9 insertions(+)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/3581a335/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
----------------------------------------------------------------------
diff --git a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
index 19f38e2..f8792e5 100644
--- a/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
+++ b/flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTestBase.java
@@ -18,6 +18,7 @@
 package org.apache.flink.streaming.connectors.kafka;
 
 import org.apache.flink.client.program.ProgramInvocationException;
+import org.apache.flink.configuration.AkkaOptions;
 import org.apache.flink.configuration.ConfigConstants;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.MetricOptions;
@@ -121,6 +122,8 @@ public abstract class KafkaTestBase extends TestLogger {
 
 	protected static Configuration getFlinkConfiguration() {
 		Configuration flinkConfig = new Configuration();
+		flinkConfig.setString(AkkaOptions.WATCH_HEARTBEAT_PAUSE, "5 s");
+		flinkConfig.setString(AkkaOptions.WATCH_HEARTBEAT_INTERVAL, "1 s");
 		flinkConfig.setInteger(ConfigConstants.LOCAL_NUMBER_TASK_MANAGER, NUM_TMS);
 		flinkConfig.setInteger(ConfigConstants.TASK_MANAGER_NUM_TASK_SLOTS, TM_SLOTS);
 		flinkConfig.setLong(TaskManagerOptions.MANAGED_MEMORY_SIZE, 16L);

http://git-wip-us.apache.org/repos/asf/flink/blob/3581a335/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 7f09abc..524e718 100644
--- a/pom.xml
+++ b/pom.xml
@@ -460,6 +460,12 @@ under the License.
 						<groupId>org.slf4j</groupId>
 						<artifactId>slf4j-log4j12</artifactId>
 					</exclusion>
+					<!-- Netty from zookeeper is conflicting with akka's, which can cause occasional
deadlock inside
+					Netty threads -->
+					<exclusion>
+						<groupId>io.netty</groupId>
+						<artifactId>netty</artifactId>
+					</exclusion>
 				</exclusions>
 			</dependency>
 


Mime
View raw message