flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From k...@apache.org
Subject flink git commit: [FLINK-7617] [runtime] Remove string format in BitSet to improve the performance of BuildSideOuterjoin
Date Fri, 15 Sep 2017 01:06:34 GMT
Repository: flink
Updated Branches:
  refs/heads/release-1.3 c9d617b58 -> 7d99fd438


[FLINK-7617] [runtime] Remove string format in BitSet to improve the performance of BuildSideOuterjoin

This closes #4668.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/7d99fd43
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/7d99fd43
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/7d99fd43

Branch: refs/heads/release-1.3
Commit: 7d99fd438e5613f61647997959ea4ab5638d2f9f
Parents: c9d617b
Author: JingsongLi <lzljs3620320@aliyun.com>
Authored: Thu Sep 14 14:42:34 2017 +0800
Committer: Kurt Young <kurt@apache.org>
Committed: Fri Sep 15 09:05:44 2017 +0800

----------------------------------------------------------------------
 .../java/org/apache/flink/runtime/operators/util/BitSet.java   | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/7d99fd43/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
index be24ee2..b6e1e07 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/operators/util/BitSet.java
@@ -56,8 +56,7 @@ public class BitSet {
 	 * @param index - position
 	 */
 	public void set(int index) {
-		Preconditions.checkArgument(index < bitLength && index >= 0, 
-			String.format("Input Index[%d] is larger than BitSet available size[%d].", index, bitLength));
+		Preconditions.checkArgument(index < bitLength && index >= 0);
 
 		int byteIndex = (index & BYTE_POSITION_MASK) >>> 3;
 		byte current = memorySegment.get(offset + byteIndex);
@@ -72,8 +71,7 @@ public class BitSet {
 	 * @return - value at the bit position
 	 */
 	public boolean get(int index) {
-		Preconditions.checkArgument(index < bitLength && index >= 0,
-			String.format("Input Index[%d] is larger than BitSet available size[%d].", index, bitLength));
+		Preconditions.checkArgument(index < bitLength && index >= 0);
 		
 		int byteIndex = (index & BYTE_POSITION_MASK) >>> 3;
 		byte current = memorySegment.get(offset + byteIndex);


Mime
View raw message