flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ches...@apache.org
Subject [1/5] flink git commit: [FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime
Date Wed, 26 Jul 2017 10:16:07 GMT
Repository: flink
Updated Branches:
  refs/heads/master 449c84b0e -> 113b8c41d


[FLINK-7257] [runtime] Enable checkstyle for test files in flink-runtime

This closes #4394.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/0feb08b8
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/0feb08b8
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/0feb08b8

Branch: refs/heads/master
Commit: 0feb08b8b9c80f4323023ee8cb651d2b70686b41
Parents: 449c84b
Author: zentol <chesnay@apache.org>
Authored: Mon Jul 24 16:28:51 2017 +0200
Committer: zentol <chesnay@apache.org>
Committed: Wed Jul 26 10:49:57 2017 +0200

----------------------------------------------------------------------
 flink-runtime/pom.xml                           |   2 +-
 .../overlays/KeytabOverlayTest.java             |   1 -
 .../executiongraph/ExecutionGraphTestUtils.java |   1 -
 .../runtime/jobgraph/JobTaskVertexTest.java     |   5 +-
 .../jobgraph/jsonplan/JsonGeneratorTest.java    |   1 -
 .../operators/ReduceTaskExternalITCase.java     |   1 -
 .../resourcemanager/JobLeaderIdServiceTest.java |   1 -
 .../runtime/util/ClassLoaderUtilsTest.java      |   4 +-
 tools/maven/suppressions-runtime.xml            | 148 ++++++++++++++++---
 9 files changed, 131 insertions(+), 33 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/pom.xml
----------------------------------------------------------------------
diff --git a/flink-runtime/pom.xml b/flink-runtime/pom.xml
index f0c21f4..5d236bc 100644
--- a/flink-runtime/pom.xml
+++ b/flink-runtime/pom.xml
@@ -236,7 +236,7 @@ under the License.
 				<configuration>
 					<configLocation>/tools/maven/checkstyle.xml</configLocation>
 					<suppressionsLocation>/tools/maven/suppressions-runtime.xml</suppressionsLocation>
-					<includeTestSourceDirectory>false</includeTestSourceDirectory>
+					<includeTestSourceDirectory>true</includeTestSourceDirectory>
 					<logViolationsToConsole>true</logViolationsToConsole>
 					<failOnViolation>true</failOnViolation>
 				</configuration>

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlayTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlayTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlayTest.java
index 1847ec4..947d2ff 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlayTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/clusterframework/overlays/KeytabOverlayTest.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.clusterframework.overlays;
 
-import org.apache.flink.configuration.ConfigConstants;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.SecurityOptions;
 import org.apache.flink.core.fs.Path;

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
index dbbd3e0..a6b5a4b 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/executiongraph/ExecutionGraphTestUtils.java
@@ -24,7 +24,6 @@ import org.apache.flink.api.common.time.Time;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.metrics.groups.UnregisteredMetricsGroup;
 import org.apache.flink.runtime.akka.AkkaUtils;
-import org.apache.flink.runtime.checkpoint.CheckpointRecoveryFactory;
 import org.apache.flink.runtime.checkpoint.StandaloneCheckpointRecoveryFactory;
 import org.apache.flink.runtime.clusterframework.types.AllocationID;
 import org.apache.flink.runtime.clusterframework.types.ResourceID;

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
index d94b93e..970437a 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/JobTaskVertexTest.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.jobgraph;
 
-import org.apache.commons.lang3.SerializationUtils;
 import org.apache.flink.api.common.io.GenericInputFormat;
 import org.apache.flink.api.common.io.InitializeOnMaster;
 import org.apache.flink.api.common.io.InputFormat;
@@ -29,6 +28,8 @@ import org.apache.flink.core.io.GenericInputSplit;
 import org.apache.flink.core.io.InputSplit;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
 import org.apache.flink.runtime.operators.util.TaskConfig;
+import org.apache.flink.util.InstantiationUtil;
+
 import org.junit.Test;
 
 import java.io.IOException;
@@ -95,7 +96,7 @@ public class JobTaskVertexTest {
 				// all good
 			}
 			
-			OutputFormatVertex copy = SerializationUtils.clone(of);
+			OutputFormatVertex copy = InstantiationUtil.clone(of);
 			try {
 				copy.initializeOnMaster(cl);
 				fail("Did not throw expected exception.");

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java
index 62b9b40..e85b9eb 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/jobgraph/jsonplan/JsonGeneratorTest.java
@@ -21,7 +21,6 @@ package org.apache.flink.runtime.jobgraph.jsonplan;
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
 import com.fasterxml.jackson.databind.node.TextNode;
-import org.apache.flink.api.common.ExecutionConfig;
 import org.apache.flink.runtime.io.network.partition.ResultPartitionType;
 import org.apache.flink.runtime.jobgraph.DistributionPattern;
 import org.apache.flink.runtime.jobgraph.JobGraph;

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java
index 969f180..c706c1d 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/ReduceTaskExternalITCase.java
@@ -21,7 +21,6 @@ package org.apache.flink.runtime.operators;
 import java.util.ArrayList;
 import java.util.List;
 
-import org.apache.commons.lang.Validate;
 import org.apache.flink.api.common.ExecutionConfig;
 import org.apache.flink.api.common.functions.GroupCombineFunction;
 import org.apache.flink.api.common.functions.GroupReduceFunction;

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
index 149cc10..4d5964e 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/resourcemanager/JobLeaderIdServiceTest.java
@@ -22,7 +22,6 @@ import org.apache.flink.api.common.JobID;
 import org.apache.flink.api.common.time.Time;
 import org.apache.flink.runtime.concurrent.Future;
 import org.apache.flink.runtime.concurrent.ScheduledExecutor;
-import org.apache.flink.runtime.highavailability.HighAvailabilityServices;
 import org.apache.flink.runtime.highavailability.TestingHighAvailabilityServices;
 import org.apache.flink.runtime.leaderelection.TestingLeaderRetrievalService;
 import org.apache.flink.util.TestLogger;

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
index 7f6e1bd..abd0590 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/util/ClassLoaderUtilsTest.java
@@ -54,7 +54,9 @@ public class ClassLoaderUtilsTest {
 				e.printStackTrace();
 				fail("test setup broken: cannot create a valid jar file");
 			} finally {
-				if (jarFile != null) jarFile.close();
+				if (jarFile != null) {
+					jarFile.close();
+				}
 			}
 			
 			// file with some random contents

http://git-wip-us.apache.org/repos/asf/flink/blob/0feb08b8/tools/maven/suppressions-runtime.xml
----------------------------------------------------------------------
diff --git a/tools/maven/suppressions-runtime.xml b/tools/maven/suppressions-runtime.xml
index aad080c..74fbeac 100644
--- a/tools/maven/suppressions-runtime.xml
+++ b/tools/maven/suppressions-runtime.xml
@@ -26,76 +26,176 @@ under the License.
 	<suppress
 		files="(.*)runtime[/\\]blob[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]blob[/\\](.*)"
+		checks="AvoidStarImport|UnusedImport"/>
+	<suppress
 		files="(.*)runtime[/\\]checkpoint[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]checkpoint[/\\](.*)"
+		checks="AvoidStarImport|FileLength|UnusedImports|NeedBraces"/>
+	<suppress
 		files="(.*)runtime[/\\]client[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]client[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]clusterframework[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]clusterframework[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]concurrent[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]concurrent[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]execution[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]execution[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]executiongraph[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]executiongraph[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]highavailability[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]highavailability[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]instance[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]instance[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]io[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]io[/\\](.*)"
+		checks="AvoidStarImport|UnusedImports"/>
+	<suppress
 		files="(.*)runtime[/\\]jobgraph[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]jobgraph[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]jobmanager[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]jobmanager[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]jobmaster[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]jobmaster[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]leaderelection[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]leaderelection[/\\](.*)"
+		checks="AvoidStarImport|UnusedImports"/>
+	<suppress
 		files="(.*)runtime[/\\]messages[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]messages[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]minicluster[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]minicluster[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]operators[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]operators[/\\](.*)"
+		checks="AvoidStarImport|NeedBraces|UnusedImports"/>
+	<suppress
 		files="(.*)runtime[/\\]resourcemanager[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]resourcemanager[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]rpc[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]rpc[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]state[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]state[/\\](.*)"
+		checks="AvoidStarImport|NeedBraces"/>
+	<suppress
 		files="(.*)runtime[/\\]taskexecutor[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]taskexecutor[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]taskmanager[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]taskmanager[/\\](.*)"
+		checks="AvoidStarImport|UnusedImports"/>
+	<suppress
 		files="(.*)runtime[/\\]testutils[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]testutils[/\\](.*)"
+		checks="AvoidStarImport"/>
+	<suppress
 		files="(.*)runtime[/\\]util[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
-<suppress
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]util[/\\](.*)"
+		checks="AvoidStarImport|Needbraces|UnusedImports"/>
+	<suppress
 		files="(.*)runtime[/\\]zookeeper[/\\](.*)"
 		checks="NewlineAtEndOfFile|RegexpSingleline|TodoComment|RedundantImport|ImportOrder|RedundantModifier|JavadocMethod|JavadocParagraph|JavadocType|JavadocStyle|PackageName|TypeNameCheck|ConstantNameCheck|StaticVariableNameCheck|MemberNameCheck|MethodNameCheck|ParameterName|LocalFinalVariableName|LocalVariableName|LeftCurly|UpperEll|FallThrough|reliefPattern|SimplifyBooleanExpression|EmptyStatement|ModifierOrder|EmptyLineSeparator|WhitespaceAround|WhitespaceAfter|NoWhitespaceAfter|NoWhitespaceBefore|OperatorWrap|ParenPad"/>
+	<!--Only additional checks for test sources. Those checks were present in the "pre-strict"
checkstyle but were not applied to test sources. We do not want to suppress them for sources
directory-->
+	<suppress
+		files="(.*)test[/\\](.*)runtime[/\\]zookeeper[/\\](.*)"
+		checks="AvoidStarImport"/>
 </suppressions>


Mime
View raw message