flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzuli...@apache.org
Subject [2/8] flink git commit: [FLINK-6867] [elasticsearch] Fix instable Elasticsearch 1.x ITCases
Date Sat, 01 Jul 2017 12:19:53 GMT
[FLINK-6867] [elasticsearch] Fix instable Elasticsearch 1.x ITCases

The root cause for the instability in ES 1.x is that we're testing both
embedded client mode and transport client mode against the same
Elasticsearch environment. This commit removes the embedded mode
testing, as that method is generally discouraged anyways.

This closes #4191.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/0d02f26e
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/0d02f26e
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/0d02f26e

Branch: refs/heads/release-1.3
Commit: 0d02f26e76823731415936ccc211844a6057408a
Parents: 87ff289
Author: Tzu-Li (Gordon) Tai <tzulitai@apache.org>
Authored: Tue Jun 27 16:40:51 2017 +0800
Committer: Tzu-Li (Gordon) Tai <tzulitai@apache.org>
Committed: Sat Jul 1 16:18:40 2017 +0800

----------------------------------------------------------------------
 .../elasticsearch/ElasticsearchSinkITCase.java  | 31 --------------------
 1 file changed, 31 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/0d02f26e/flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
----------------------------------------------------------------------
diff --git a/flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
b/flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
index 3a7b113..6ce0b25 100644
--- a/flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
+++ b/flink-connectors/flink-connector-elasticsearch/src/test/java/org/apache/flink/streaming/connectors/elasticsearch/ElasticsearchSinkITCase.java
@@ -61,37 +61,6 @@ public class ElasticsearchSinkITCase extends ElasticsearchSinkTestBase
{
 	// -- Tests specific to Elasticsearch 1.x --
 
 	/**
-	 * Tests that the Elasticsearch sink works properly using an embedded node to connect to
Elasticsearch.
-	 */
-	@Test
-	public void testEmbeddedNode() throws Exception {
-		final String index = "embedded-node-test-index";
-
-		final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
-
-		DataStreamSource<Tuple2<Integer, String>> source = env.addSource(new SourceSinkDataTestKit.TestDataSourceFunction());
-
-		Map<String, String> userConfig = new HashMap<>();
-		// This instructs the sink to emit after every element, otherwise they would be buffered
-		userConfig.put(ElasticsearchSinkBase.CONFIG_KEY_BULK_FLUSH_MAX_ACTIONS, "1");
-		userConfig.put("cluster.name", CLUSTER_NAME);
-		userConfig.put("node.local", "true");
-
-		source.addSink(new ElasticsearchSink<>(
-			userConfig,
-			new SourceSinkDataTestKit.TestElasticsearchSinkFunction(index))
-		);
-
-		env.execute("Elasticsearch Embedded Node Test");
-
-		// verify the results
-		Client client = embeddedNodeEnv.getClient();
-		SourceSinkDataTestKit.verifyProducedSinkData(client, index);
-
-		client.close();
-	}
-
-	/**
 	 * Tests that behaviour of the deprecated {@link IndexRequestBuilder} constructor works
properly.
 	 */
 	@Test


Mime
View raw message