flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ches...@apache.org
Subject [5/5] flink git commit: [FLINK-6687] [web] Activate strict checkstyle for flink-runtime-web
Date Wed, 24 May 2017 19:59:59 GMT
[FLINK-6687] [web] Activate strict checkstyle for flink-runtime-web


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/d481f295
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/d481f295
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/d481f295

Branch: refs/heads/master
Commit: d481f295005461b31c952e9f1d45aa175d803b01
Parents: bf92055
Author: zentol <chesnay@apache.org>
Authored: Tue May 23 18:36:51 2017 +0200
Committer: zentol <chesnay@apache.org>
Committed: Wed May 24 20:21:01 2017 +0200

----------------------------------------------------------------------
 flink-runtime-web/pom.xml                       |  35 ++++
 .../webmonitor/BackPressureStatsTracker.java    |  10 +-
 .../webmonitor/ExecutionGraphHolder.java        |   9 +-
 .../runtime/webmonitor/HttpRequestHandler.java  |   7 +-
 .../runtime/webmonitor/JobManagerRetriever.java |  20 ++-
 .../webmonitor/PipelineErrorHandler.java        |   7 +-
 .../webmonitor/RuntimeMonitorHandler.java       |  17 +-
 .../webmonitor/RuntimeMonitorHandlerBase.java   |  12 +-
 .../runtime/webmonitor/StackTraceSample.java    |   4 +-
 .../webmonitor/StackTraceSampleCoordinator.java |   5 +-
 .../runtime/webmonitor/WebMonitorConfig.java    |   8 +-
 .../runtime/webmonitor/WebRuntimeMonitor.java   | 171 +++++++++----------
 .../runtime/webmonitor/files/MimeTypes.java     |  26 +--
 .../files/StaticFileServerHandler.java          |  37 ++--
 .../AbstractExecutionGraphRequestHandler.java   |  12 +-
 .../AbstractJobVertexRequestHandler.java        |   6 +-
 .../handlers/AbstractJsonRequestHandler.java    |   3 +-
 .../AbstractSubtaskAttemptRequestHandler.java   |   8 +-
 .../handlers/AbstractSubtaskRequestHandler.java |  10 +-
 .../handlers/ClusterOverviewHandler.java        |  14 +-
 .../handlers/ConstantTextHandler.java           |   3 +-
 .../handlers/CurrentJobIdsHandler.java          |  32 ++--
 .../handlers/CurrentJobsOverviewHandler.java    |  35 ++--
 .../handlers/DashboardConfigHandler.java        |  15 +-
 .../handlers/HandlerRedirectUtils.java          |  16 +-
 .../handlers/JarAccessDeniedHandler.java        |   3 +
 .../webmonitor/handlers/JarActionHandler.java   |  14 +-
 .../webmonitor/handlers/JarDeleteHandler.java   |   5 +-
 .../webmonitor/handlers/JarListHandler.java     |  18 +-
 .../webmonitor/handlers/JarPlanHandler.java     |   5 +-
 .../webmonitor/handlers/JarRunHandler.java      |   8 +-
 .../webmonitor/handlers/JarUploadHandler.java   |   8 +-
 .../handlers/JobAccumulatorsHandler.java        |  12 +-
 .../JobCancellationWithSavepointHandlers.java   |  41 ++---
 .../webmonitor/handlers/JobConfigHandler.java   |  19 ++-
 .../webmonitor/handlers/JobDetailsHandler.java  |  38 +++--
 .../handlers/JobExceptionsHandler.java          |  14 +-
 .../handlers/JobManagerConfigHandler.java       |   9 +-
 .../webmonitor/handlers/JobPlanHandler.java     |   5 +-
 .../handlers/JobVertexAccumulatorsHandler.java  |  19 ++-
 .../handlers/JobVertexBackPressureHandler.java  |   8 +-
 .../handlers/JobVertexDetailsHandler.java       |  24 +--
 .../handlers/JobVertexTaskManagersHandler.java  |  10 +-
 .../webmonitor/handlers/JsonFactory.java        |   7 +-
 .../webmonitor/handlers/RequestHandler.java     |   7 +-
 .../SubtaskCurrentAttemptDetailsHandler.java    |   2 +-
 ...taskExecutionAttemptAccumulatorsHandler.java |  22 ++-
 .../SubtaskExecutionAttemptDetailsHandler.java  |  14 +-
 .../SubtasksAllAccumulatorsHandler.java         |  19 ++-
 .../handlers/SubtasksTimesHandler.java          |  23 +--
 .../handlers/TaskManagerLogHandler.java         |  88 +++++-----
 .../handlers/TaskManagersHandler.java           |  31 ++--
 .../checkpoints/CheckpointConfigHandler.java    |   8 +-
 .../checkpoints/CheckpointStatsCache.java       |   3 +-
 .../CheckpointStatsDetailsHandler.java          |   8 +-
 .../CheckpointStatsDetailsSubtasksHandler.java  |  10 +-
 .../checkpoints/CheckpointStatsHandler.java     |   9 +-
 .../webmonitor/history/HistoryServer.java       |  23 +--
 .../history/HistoryServerArchiveFetcher.java    |  24 +--
 .../HistoryServerStaticFileServerHandler.java   |  13 +-
 .../metrics/AbstractMetricsHandler.java         |  16 +-
 .../metrics/JobManagerMetricsHandler.java       |   5 +-
 .../webmonitor/metrics/JobMetricsHandler.java   |   5 +-
 .../metrics/JobVertexMetricsHandler.java        |   5 +-
 .../webmonitor/metrics/MetricFetcher.java       |  29 ++--
 .../runtime/webmonitor/metrics/MetricStore.java |  16 +-
 .../metrics/TaskManagerMetricsHandler.java      |   5 +-
 .../webmonitor/utils/MutableIOMetrics.java      |  23 +--
 .../webmonitor/utils/WebFrontendBootstrap.java  |  17 +-
 .../BackPressureStatsTrackerITCase.java         |  10 +-
 .../BackPressureStatsTrackerTest.java           |   6 +-
 .../StackTraceSampleCoordinatorITCase.java      |   8 +-
 .../StackTraceSampleCoordinatorTest.java        |   4 +-
 .../runtime/webmonitor/WebMonitorUtilsTest.java |   7 +-
 .../webmonitor/WebRuntimeMonitorITCase.java     |  33 ++--
 .../runtime/webmonitor/files/MimeTypesTest.java |  10 +-
 .../handlers/ClusterOverviewHandlerTest.java    |   7 +-
 .../handlers/CurrentJobIdsHandlerTest.java      |   7 +-
 .../CurrentJobsOverviewHandlerTest.java         |  20 ++-
 .../handlers/DashboardConfigHandlerTest.java    |   9 +-
 .../handlers/HandlerRedirectUtilsTest.java      |  17 +-
 .../handlers/JarAccessDeniedHandlerTest.java    |   4 +
 .../handlers/JarActionHandlerTest.java          |   5 +-
 .../handlers/JarDeleteHandlerTest.java          |   4 +
 .../webmonitor/handlers/JarListHandlerTest.java |   4 +
 .../webmonitor/handlers/JarPlanHandlerTest.java |   4 +
 .../webmonitor/handlers/JarRunHandlerTest.java  |   4 +
 .../handlers/JarUploadHandlerTest.java          |   4 +
 .../handlers/JobAccumulatorsHandlerTest.java    |  11 +-
 .../handlers/JobCancellationHandlerTest.java    |   4 +
 ...obCancellationWithSavepointHandlersTest.java |  27 +--
 .../handlers/JobConfigHandlerTest.java          |   9 +-
 .../handlers/JobDetailsHandlerTest.java         |  15 +-
 .../handlers/JobExceptionsHandlerTest.java      |  11 +-
 .../handlers/JobManagerConfigHandlerTest.java   |   4 +
 .../webmonitor/handlers/JobPlanHandlerTest.java |   5 +
 .../handlers/JobStoppingHandlerTest.java        |   4 +
 .../JobVertexAccumulatorsHandlerTest.java       |  11 +-
 .../JobVertexBackPressureHandlerTest.java       |  12 +-
 .../handlers/JobVertexDetailsHandlerTest.java   |  11 +-
 .../JobVertexTaskManagersHandlerTest.java       |  11 +-
 ...SubtaskCurrentAttemptDetailsHandlerTest.java |   4 +
 ...ExecutionAttemptAccumulatorsHandlerTest.java |  13 +-
 ...btaskExecutionAttemptDetailsHandlerTest.java |  11 +-
 .../SubtasksAllAccumulatorsHandlerTest.java     |  13 +-
 .../handlers/SubtasksTimesHandlerTest.java      |  13 +-
 .../handlers/TaskManagerLogHandlerTest.java     |  33 ++--
 .../handlers/TaskManagersHandlerTest.java       |   7 +-
 .../CheckpointConfigHandlerTest.java            |   9 +-
 .../checkpoints/CheckpointStatsCacheTest.java   |   4 +
 .../CheckpointStatsDetailsHandlerTest.java      |  16 +-
 .../checkpoints/CheckpointStatsHandlerTest.java |  18 +-
 ...heckpointStatsSubtaskDetailsHandlerTest.java |  11 +-
 .../webmonitor/history/FsJobArchivistTest.java  |   4 +-
 ...istoryServerStaticFileServerHandlerTest.java |   7 +-
 .../webmonitor/history/HistoryServerTest.java   |  19 ++-
 .../metrics/AbstractMetricsHandlerTest.java     |  12 +-
 .../metrics/JobManagerMetricsHandlerTest.java   |  11 +-
 .../metrics/JobMetricsHandlerTest.java          |  11 +-
 .../metrics/JobVertexMetricsHandlerTest.java    |  11 +-
 .../webmonitor/metrics/MetricFetcherTest.java   |  29 ++--
 .../webmonitor/metrics/MetricStoreTest.java     |   9 +-
 .../metrics/TaskManagerMetricsHandlerTest.java  |  11 +-
 .../webmonitor/testutils/HttpTestClient.java    |  15 +-
 .../utils/ArchivedExecutionBuilder.java         |   4 +
 .../utils/ArchivedExecutionConfigBuilder.java   |   4 +
 .../utils/ArchivedExecutionGraphBuilder.java    |   4 +
 .../ArchivedExecutionJobVertexBuilder.java      |   4 +
 .../utils/ArchivedExecutionVertexBuilder.java   |   4 +
 .../utils/ArchivedJobGenerationUtils.java       |  19 ++-
 130 files changed, 1132 insertions(+), 714 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/pom.xml
----------------------------------------------------------------------
diff --git a/flink-runtime-web/pom.xml b/flink-runtime-web/pom.xml
index ef1580d..040e844 100644
--- a/flink-runtime-web/pom.xml
+++ b/flink-runtime-web/pom.xml
@@ -128,6 +128,41 @@ under the License.
 					</execution>
 				</executions>
 			</plugin>
+
+			<plugin>
+				<groupId>org.apache.maven.plugins</groupId>
+				<artifactId>maven-checkstyle-plugin</artifactId>
+				<version>2.17</version>
+				<dependencies>
+					<dependency>
+						<groupId>com.puppycrawl.tools</groupId>
+						<artifactId>checkstyle</artifactId>
+						<version>6.19</version>
+					</dependency>
+				</dependencies>
+				<configuration>
+					<configLocation>/tools/maven/strict-checkstyle.xml</configLocation>
+					<suppressionsLocation>/tools/maven/suppressions.xml</suppressionsLocation>
+					<includeTestSourceDirectory>true</includeTestSourceDirectory>
+					<logViolationsToConsole>true</logViolationsToConsole>
+					<failOnViolation>true</failOnViolation>
+				</configuration>
+				<executions>
+					<!--
+					Execute checkstyle after compilation but before tests.
+
+					This ensures that any parsing or type checking errors are from
+					javac, so they look as expected. Beyond that, we want to
+					fail as early as possible.
+					-->
+					<execution>
+						<phase>test-compile</phase>
+						<goals>
+							<goal>check</goal>
+						</goals>
+					</execution>
+				</executions>
+			</plugin>
 		</plugins>
 	</build>
 	

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
index 97de89b..894309c 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/BackPressureStatsTracker.java
@@ -18,9 +18,6 @@
 
 package org.apache.flink.runtime.webmonitor;
 
-import com.google.common.cache.Cache;
-import com.google.common.cache.CacheBuilder;
-import com.google.common.collect.Maps;
 import org.apache.flink.api.common.time.Time;
 import org.apache.flink.runtime.concurrent.BiFunction;
 import org.apache.flink.runtime.concurrent.Future;
@@ -28,9 +25,12 @@ import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
 import org.apache.flink.runtime.executiongraph.ExecutionJobVertex;
 import org.apache.flink.runtime.executiongraph.ExecutionVertex;
 import org.apache.flink.runtime.jobgraph.JobStatus;
+
+import com.google.common.cache.Cache;
+import com.google.common.cache.CacheBuilder;
+import com.google.common.collect.Maps;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import scala.Option;
 
 import java.util.Arrays;
 import java.util.HashSet;
@@ -41,6 +41,8 @@ import java.util.Set;
 import java.util.concurrent.Executor;
 import java.util.concurrent.TimeUnit;
 
+import scala.Option;
+
 import static org.apache.flink.util.Preconditions.checkArgument;
 import static org.apache.flink.util.Preconditions.checkNotNull;
 

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/ExecutionGraphHolder.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/ExecutionGraphHolder.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/ExecutionGraphHolder.java
index f9faa85..75b0475 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/ExecutionGraphHolder.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/ExecutionGraphHolder.java
@@ -27,18 +27,19 @@ import org.apache.flink.runtime.messages.JobManagerMessages;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+
+import java.util.WeakHashMap;
+
 import scala.concurrent.Await;
 import scala.concurrent.Future;
 import scala.concurrent.duration.FiniteDuration;
 
-import java.util.WeakHashMap;
-
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
  * Gateway to obtaining an {@link ExecutionGraph} from a source, like JobManager or Archive.
- * <p>
- * The holder will cache the ExecutionGraph behind a weak reference, which will be cleared
+ *
+ * <p>The holder will cache the ExecutionGraph behind a weak reference, which will be cleared
  * at some point once no one else is pointing to the ExecutionGraph.
  * Note that while the holder runs in the same JVM as the JobManager or Archive, the reference should
  * stay valid.

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
index bde9976..b481c78 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/HttpRequestHandler.java
@@ -26,6 +26,9 @@ package org.apache.flink.runtime.webmonitor;
  * https://github.com/netty/netty/blob/netty-4.0.31.Final/example/src/main/java/io/netty/example/http/upload/HttpUploadServerHandler.java
  *****************************************************************************/
 
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.util.ExceptionUtils;
+
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
@@ -48,8 +51,6 @@ import io.netty.handler.codec.http.multipart.HttpPostRequestDecoder;
 import io.netty.handler.codec.http.multipart.HttpPostRequestDecoder.EndOfDataDecoderException;
 import io.netty.handler.codec.http.multipart.InterfaceHttpData;
 import io.netty.handler.codec.http.multipart.InterfaceHttpData.HttpDataType;
-import org.apache.flink.configuration.ConfigConstants;
-import org.apache.flink.util.ExceptionUtils;
 
 import java.io.File;
 import java.io.IOException;
@@ -67,7 +68,7 @@ public class HttpRequestHandler extends SimpleChannelInboundHandler<HttpObject>
 
 	private static final Charset ENCODING = ConfigConstants.DEFAULT_CHARSET;
 
-	/** A decoder factory that always stores POST chunks on disk */
+	/** A decoder factory that always stores POST chunks on disk. */
 	private static final HttpDataFactory DATA_FACTORY = new DefaultHttpDataFactory(true);
 
 	private final File tmpDir;

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerRetriever.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerRetriever.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerRetriever.java
index 7aab31f..175a4b8 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerRetriever.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/JobManagerRetriever.java
@@ -18,19 +18,24 @@
 
 package org.apache.flink.runtime.webmonitor;
 
-import akka.actor.ActorRef;
-import akka.actor.ActorSystem;
-import akka.dispatch.Futures;
-import akka.dispatch.Mapper;
-import akka.dispatch.OnComplete;
 import org.apache.flink.runtime.akka.AkkaUtils;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.instance.AkkaActorGateway;
 import org.apache.flink.runtime.leaderretrieval.LeaderRetrievalListener;
 import org.apache.flink.runtime.messages.JobManagerMessages;
 import org.apache.flink.runtime.messages.JobManagerMessages.ResponseWebMonitorPort;
+
+import akka.actor.ActorRef;
+import akka.actor.ActorSystem;
+import akka.dispatch.Futures;
+import akka.dispatch.Mapper;
+import akka.dispatch.OnComplete;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
+
+import java.util.UUID;
+import java.util.concurrent.TimeoutException;
+
 import scala.Option;
 import scala.Tuple2;
 import scala.concurrent.Await;
@@ -39,9 +44,6 @@ import scala.concurrent.Promise;
 import scala.concurrent.duration.Deadline;
 import scala.concurrent.duration.FiniteDuration;
 
-import java.util.UUID;
-import java.util.concurrent.TimeoutException;
-
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
@@ -106,7 +108,7 @@ public class JobManagerRetriever implements LeaderRetrievalListener {
 		Future<Tuple2<ActorGateway, Integer>> gatewayPortFuture = null;
 		Deadline deadline = timeout.fromNow();
 
-		while(!deadline.isOverdue()) {
+		while (!deadline.isOverdue()) {
 			synchronized (waitLock) {
 				gatewayPortFuture = leaderGatewayPortFuture;
 

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
index 85b3b13..52622f6 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/PipelineErrorHandler.java
@@ -18,6 +18,9 @@
 
 package org.apache.flink.runtime.webmonitor;
 
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.util.ExceptionUtils;
+
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
@@ -26,8 +29,6 @@ import io.netty.handler.codec.http.DefaultFullHttpResponse;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponseStatus;
 import io.netty.handler.codec.http.HttpVersion;
-import org.apache.flink.configuration.ConfigConstants;
-import org.apache.flink.util.ExceptionUtils;
 import org.slf4j.Logger;
 
 /**
@@ -37,7 +38,7 @@ import org.slf4j.Logger;
 @ChannelHandler.Sharable
 public class PipelineErrorHandler extends SimpleChannelInboundHandler<Object> {
 
-	/** The logger to which the handler writes the log statements */
+	/** The logger to which the handler writes the log statements. */
 	private final Logger logger;
 
 	public PipelineErrorHandler(Logger logger) {

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
index 90fe2e0..a21a871 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandler.java
@@ -18,6 +18,11 @@
 
 package org.apache.flink.runtime.webmonitor;
 
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.runtime.instance.ActorGateway;
+import org.apache.flink.runtime.webmonitor.handlers.RequestHandler;
+import org.apache.flink.util.ExceptionUtils;
+
 import io.netty.buffer.ByteBuf;
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelHandler;
@@ -29,24 +34,18 @@ import io.netty.handler.codec.http.HttpResponseStatus;
 import io.netty.handler.codec.http.HttpVersion;
 import io.netty.handler.codec.http.router.KeepAliveWrite;
 import io.netty.handler.codec.http.router.Routed;
-
-import org.apache.flink.configuration.ConfigConstants;
-import org.apache.flink.runtime.instance.ActorGateway;
-import org.apache.flink.runtime.webmonitor.handlers.RequestHandler;
-import org.apache.flink.util.ExceptionUtils;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import scala.concurrent.Future;
-import scala.concurrent.duration.FiniteDuration;
-
 import java.net.InetSocketAddress;
 import java.net.URLDecoder;
 import java.nio.charset.Charset;
 import java.util.HashMap;
 import java.util.Map;
 
+import scala.concurrent.Future;
+import scala.concurrent.duration.FiniteDuration;
+
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java
index 3c1dcb6..99d5df5 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/RuntimeMonitorHandlerBase.java
@@ -18,15 +18,17 @@
 
 package org.apache.flink.runtime.webmonitor;
 
+import org.apache.flink.runtime.instance.ActorGateway;
+import org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils;
+import org.apache.flink.runtime.webmonitor.handlers.RequestHandler;
+
 import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
 import io.netty.channel.SimpleChannelInboundHandler;
 import io.netty.handler.codec.http.HttpResponse;
 import io.netty.handler.codec.http.router.KeepAliveWrite;
 import io.netty.handler.codec.http.router.Routed;
-import org.apache.flink.runtime.instance.ActorGateway;
-import org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils;
-import org.apache.flink.runtime.webmonitor.handlers.RequestHandler;
+
 import scala.Option;
 import scala.Tuple2;
 import scala.concurrent.Await;
@@ -50,11 +52,11 @@ public abstract class RuntimeMonitorHandlerBase extends SimpleChannelInboundHand
 
 	protected final FiniteDuration timeout;
 
-	/** Whether the web service has https enabled */
+	/** Whether the web service has https enabled. */
 	protected final boolean httpsEnabled;
 
 	protected String localJobManagerAddress;
-	
+
 	public RuntimeMonitorHandlerBase(
 		JobManagerRetriever retriever,
 		Future<String> localJobManagerAddressFuture,

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSample.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSample.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSample.java
index b2576b0..d60f8a4 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSample.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSample.java
@@ -33,7 +33,7 @@ import static org.apache.flink.util.Preconditions.checkArgument;
  */
 public class StackTraceSample {
 
-	/** ID of this sample (unique per job) */
+	/** ID of this sample (unique per job). */
 	private final int sampleId;
 
 	/** Time stamp, when the sample was triggered. */
@@ -46,7 +46,7 @@ public class StackTraceSample {
 	private final Map<ExecutionAttemptID, List<StackTraceElement[]>> stackTracesByTask;
 
 	/**
-	 * Creates a stack trace sample
+	 * Creates a stack trace sample.
 	 *
 	 * @param sampleId          ID of the sample.
 	 * @param startTime         Time stamp, when the sample was triggered.

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java
index 9d3b0f4..5a85343 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/StackTraceSampleCoordinator.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.webmonitor;
 
-import com.google.common.collect.Maps;
 import org.apache.flink.api.common.time.Time;
 import org.apache.flink.runtime.concurrent.BiFunction;
 import org.apache.flink.runtime.concurrent.CompletableFuture;
@@ -30,6 +29,8 @@ import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
 import org.apache.flink.runtime.executiongraph.ExecutionVertex;
 import org.apache.flink.runtime.messages.StackTraceSampleResponse;
 import org.apache.flink.util.Preconditions;
+
+import com.google.common.collect.Maps;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -57,7 +58,7 @@ public class StackTraceSampleCoordinator {
 
 	private final Object lock = new Object();
 
-	/** Executor used to run the futures */
+	/** Executor used to run the futures. */
 	private final Executor executor;
 
 	/** Time out after the expected sampling duration. */

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java
index 77537a2..84ca049 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorConfig.java
@@ -21,12 +21,14 @@ package org.apache.flink.runtime.webmonitor;
 import org.apache.flink.configuration.Configuration;
 import org.apache.flink.configuration.JobManagerOptions;
 
+/**
+ * Configuration object for {@link WebMonitor}.
+ */
 public class WebMonitorConfig {
 
-	/** The configuration queried by this config object */
+	/** The configuration queried by this config object. */
 	private final Configuration config;
 
-
 	public WebMonitorConfig(Configuration config) {
 		if (config == null) {
 			throw new NullPointerException();
@@ -45,7 +47,7 @@ public class WebMonitorConfig {
 	public long getRefreshInterval() {
 		return config.getLong(JobManagerOptions.WEB_REFRESH_INTERVAL);
 	}
-	
+
 	public boolean isProgramSubmitEnabled() {
 		return config.getBoolean(JobManagerOptions.WEB_SUBMIT_ENABLE);
 	}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
index 10d7c6c..535cc71 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/WebRuntimeMonitor.java
@@ -18,10 +18,6 @@
 
 package org.apache.flink.runtime.webmonitor;
 
-import akka.actor.ActorSystem;
-
-import io.netty.handler.codec.http.router.Router;
-
 import org.apache.flink.api.common.time.Time;
 import org.apache.flink.configuration.ConfigConstants;
 import org.apache.flink.configuration.Configuration;
@@ -67,8 +63,8 @@ import org.apache.flink.runtime.webmonitor.handlers.TaskManagersHandler;
 import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointConfigHandler;
 import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointStatsCache;
 import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointStatsDetailsHandler;
-import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointStatsHandler;
 import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointStatsDetailsSubtasksHandler;
+import org.apache.flink.runtime.webmonitor.handlers.checkpoints.CheckpointStatsHandler;
 import org.apache.flink.runtime.webmonitor.history.JsonArchivist;
 import org.apache.flink.runtime.webmonitor.metrics.JobManagerMetricsHandler;
 import org.apache.flink.runtime.webmonitor.metrics.JobMetricsHandler;
@@ -78,15 +74,13 @@ import org.apache.flink.runtime.webmonitor.metrics.TaskManagerMetricsHandler;
 import org.apache.flink.runtime.webmonitor.utils.WebFrontendBootstrap;
 import org.apache.flink.util.FileUtils;
 
+import akka.actor.ActorSystem;
+import io.netty.handler.codec.http.router.Router;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import scala.concurrent.ExecutionContext$;
-import scala.concurrent.ExecutionContextExecutor;
-import scala.concurrent.Promise;
-import scala.concurrent.duration.FiniteDuration;
-
 import javax.net.ssl.SSLContext;
+
 import java.io.File;
 import java.io.IOException;
 import java.util.UUID;
@@ -95,32 +89,37 @@ import java.util.concurrent.ForkJoinPool;
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.atomic.AtomicBoolean;
 
+import scala.concurrent.ExecutionContext$;
+import scala.concurrent.ExecutionContextExecutor;
+import scala.concurrent.Promise;
+import scala.concurrent.duration.FiniteDuration;
+
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
  * The root component of the web runtime monitor. This class starts the web server and creates
  * all request handlers for the REST API.
- * <p>
- * The web runtime monitor is based in Netty HTTP. It uses the Netty-Router library to route
+ *
+ * <p>The web runtime monitor is based in Netty HTTP. It uses the Netty-Router library to route
  * HTTP requests of different paths to different response handlers. In addition, it serves the static
  * files of the web frontend, such as HTML, CSS, or JS files.
  */
 public class WebRuntimeMonitor implements WebMonitor {
 
-	/** By default, all requests to the JobManager have a timeout of 10 seconds */
+	/** By default, all requests to the JobManager have a timeout of 10 seconds. */
 	public static final FiniteDuration DEFAULT_REQUEST_TIMEOUT = new FiniteDuration(10, TimeUnit.SECONDS);
 
-	/** Logger for web frontend startup / shutdown messages */
+	/** Logger for web frontend startup / shutdown messages. */
 	private static final Logger LOG = LoggerFactory.getLogger(WebRuntimeMonitor.class);
 
 	// ------------------------------------------------------------------------
 
-	/** Guarding concurrent modifications to the server channel pipeline during startup and shutdown */
+	/** Guarding concurrent modifications to the server channel pipeline during startup and shutdown. */
 	private final Object startupShutdownLock = new Object();
 
 	private final LeaderRetrievalService leaderRetrievalService;
 
-	/** LeaderRetrievalListener which stores the currently leading JobManager and its archive */
+	/** LeaderRetrievalListener which stores the currently leading JobManager and its archive. */
 	private final JobManagerRetriever retriever;
 
 	private final SSLContext serverSSLContext;
@@ -163,9 +162,9 @@ public class WebRuntimeMonitor implements WebMonitor {
 		if (configuredPort < 0) {
 			throw new IllegalArgumentException("Web frontend port is invalid: " + configuredPort);
 		}
-		
+
 		final WebMonitorUtils.LogFileLocation logFiles = WebMonitorUtils.LogFileLocation.find(config);
-		
+
 		// create an empty directory in temp for the web server
 		String rootDirFileName = "flink-web-" + UUID.randomUUID();
 		webRootDir = new File(getBaseDir(config), rootDirFileName);
@@ -236,42 +235,42 @@ public class WebRuntimeMonitor implements WebMonitor {
 
 		Router router = new Router();
 		// config how to interact with this web server
-		GET(router, new DashboardConfigHandler(cfg.getRefreshInterval()));
+		get(router, new DashboardConfigHandler(cfg.getRefreshInterval()));
 
 		// the overview - how many task managers, slots, free slots, ...
-		GET(router, new ClusterOverviewHandler(DEFAULT_REQUEST_TIMEOUT));
+		get(router, new ClusterOverviewHandler(DEFAULT_REQUEST_TIMEOUT));
 
 		// job manager configuration
-		GET(router, new JobManagerConfigHandler(config));
+		get(router, new JobManagerConfigHandler(config));
 
 		// overview over jobs
-		GET(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, true, true));
-		GET(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, true, false));
-		GET(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, false, true));
-
-		GET(router, new CurrentJobIdsHandler(DEFAULT_REQUEST_TIMEOUT));
-
-		GET(router, new JobDetailsHandler(currentGraphs, metricFetcher));
-
-		GET(router, new JobVertexDetailsHandler(currentGraphs, metricFetcher));
-		GET(router, new SubtasksTimesHandler(currentGraphs));
-		GET(router, new JobVertexTaskManagersHandler(currentGraphs, metricFetcher));
-		GET(router, new JobVertexAccumulatorsHandler(currentGraphs));
-		GET(router, new JobVertexBackPressureHandler(currentGraphs,	backPressureStatsTracker, refreshInterval));
-		GET(router, new JobVertexMetricsHandler(metricFetcher));
-		GET(router, new SubtasksAllAccumulatorsHandler(currentGraphs));
-		GET(router, new SubtaskCurrentAttemptDetailsHandler(currentGraphs, metricFetcher));
-		GET(router, new SubtaskExecutionAttemptDetailsHandler(currentGraphs, metricFetcher));
-		GET(router, new SubtaskExecutionAttemptAccumulatorsHandler(currentGraphs));
-
-		GET(router, new JobPlanHandler(currentGraphs));
-		GET(router, new JobConfigHandler(currentGraphs));
-		GET(router, new JobExceptionsHandler(currentGraphs));
-		GET(router, new JobAccumulatorsHandler(currentGraphs));
-		GET(router, new JobMetricsHandler(metricFetcher));
-
-		GET(router, new TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT, metricFetcher));
-		GET(router,
+		get(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, true, true));
+		get(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, true, false));
+		get(router, new CurrentJobsOverviewHandler(DEFAULT_REQUEST_TIMEOUT, false, true));
+
+		get(router, new CurrentJobIdsHandler(DEFAULT_REQUEST_TIMEOUT));
+
+		get(router, new JobDetailsHandler(currentGraphs, metricFetcher));
+
+		get(router, new JobVertexDetailsHandler(currentGraphs, metricFetcher));
+		get(router, new SubtasksTimesHandler(currentGraphs));
+		get(router, new JobVertexTaskManagersHandler(currentGraphs, metricFetcher));
+		get(router, new JobVertexAccumulatorsHandler(currentGraphs));
+		get(router, new JobVertexBackPressureHandler(currentGraphs,	backPressureStatsTracker, refreshInterval));
+		get(router, new JobVertexMetricsHandler(metricFetcher));
+		get(router, new SubtasksAllAccumulatorsHandler(currentGraphs));
+		get(router, new SubtaskCurrentAttemptDetailsHandler(currentGraphs, metricFetcher));
+		get(router, new SubtaskExecutionAttemptDetailsHandler(currentGraphs, metricFetcher));
+		get(router, new SubtaskExecutionAttemptAccumulatorsHandler(currentGraphs));
+
+		get(router, new JobPlanHandler(currentGraphs));
+		get(router, new JobConfigHandler(currentGraphs));
+		get(router, new JobExceptionsHandler(currentGraphs));
+		get(router, new JobAccumulatorsHandler(currentGraphs));
+		get(router, new JobMetricsHandler(metricFetcher));
+
+		get(router, new TaskManagersHandler(DEFAULT_REQUEST_TIMEOUT, metricFetcher));
+		get(router,
 			new TaskManagerLogHandler(
 				retriever,
 				context,
@@ -281,7 +280,7 @@ public class WebRuntimeMonitor implements WebMonitor {
 				config,
 				enableSSL,
 				blobView));
-		GET(router,
+		get(router,
 			new TaskManagerLogHandler(
 				retriever,
 				context,
@@ -291,7 +290,7 @@ public class WebRuntimeMonitor implements WebMonitor {
 				config,
 				enableSSL,
 				blobView));
-		GET(router, new TaskManagerMetricsHandler(metricFetcher));
+		get(router, new TaskManagerMetricsHandler(metricFetcher));
 
 		router
 			// log and stdout
@@ -303,51 +302,51 @@ public class WebRuntimeMonitor implements WebMonitor {
 				new StaticFileServerHandler(retriever, jobManagerAddressPromise.future(), timeout, logFiles.stdOutFile,
 					enableSSL));
 
-		GET(router, new JobManagerMetricsHandler(metricFetcher));
+		get(router, new JobManagerMetricsHandler(metricFetcher));
 
 		// Cancel a job via GET (for proper integration with YARN this has to be performed via GET)
-		GET(router, new JobCancellationHandler());
+		get(router, new JobCancellationHandler());
 		// DELETE is the preferred way of canceling a job (Rest-conform)
-		DELETE(router, new JobCancellationHandler());
+		delete(router, new JobCancellationHandler());
 
-		GET(router, triggerHandler);
-		GET(router, inProgressHandler);
+		get(router, triggerHandler);
+		get(router, inProgressHandler);
 
 		// stop a job via GET (for proper integration with YARN this has to be performed via GET)
-		GET(router, new JobStoppingHandler());
+		get(router, new JobStoppingHandler());
 		// DELETE is the preferred way of stopping a job (Rest-conform)
-		DELETE(router, new JobStoppingHandler());
+		delete(router, new JobStoppingHandler());
 
 		int maxCachedEntries = config.getInteger(JobManagerOptions.WEB_CHECKPOINTS_HISTORY_SIZE);
 		CheckpointStatsCache cache = new CheckpointStatsCache(maxCachedEntries);
 
 		// Register the checkpoint stats handlers
-		GET(router, new CheckpointStatsHandler(currentGraphs));
-		GET(router, new CheckpointConfigHandler(currentGraphs));
-		GET(router, new CheckpointStatsDetailsHandler(currentGraphs, cache));
-		GET(router, new CheckpointStatsDetailsSubtasksHandler(currentGraphs, cache));
+		get(router, new CheckpointStatsHandler(currentGraphs));
+		get(router, new CheckpointConfigHandler(currentGraphs));
+		get(router, new CheckpointStatsDetailsHandler(currentGraphs, cache));
+		get(router, new CheckpointStatsDetailsSubtasksHandler(currentGraphs, cache));
 
 		if (webSubmitAllow) {
 			// fetch the list of uploaded jars.
-			GET(router, new JarListHandler(uploadDir));
+			get(router, new JarListHandler(uploadDir));
 
 			// get plan for an uploaded jar
-			GET(router, new JarPlanHandler(uploadDir));
+			get(router, new JarPlanHandler(uploadDir));
 
 			// run a jar
-			POST(router, new JarRunHandler(uploadDir, timeout, config));
+			post(router, new JarRunHandler(uploadDir, timeout, config));
 
 			// upload a jar
-			POST(router, new JarUploadHandler(uploadDir));
+			post(router, new JarUploadHandler(uploadDir));
 
 			// delete an uploaded jar from submission interface
-			DELETE(router, new JarDeleteHandler(uploadDir));
+			delete(router, new JarDeleteHandler(uploadDir));
 		} else {
 			// send an Access Denied message
 			JarAccessDeniedHandler jad = new JarAccessDeniedHandler();
-			GET(router, jad);
-			POST(router, jad);
-			DELETE(router, jad);
+			get(router, jad);
+			post(router, jad);
+			delete(router, jad);
 		}
 
 		// this handler serves all the static contents
@@ -375,15 +374,15 @@ public class WebRuntimeMonitor implements WebMonitor {
 
 	/**
 	 * Returns an array of all {@link JsonArchivist}s that are relevant for the history server.
-	 * 
-	 * This method is static to allow easier access from the {@link MemoryArchivist}. Requiring a reference
+	 *
+	 * <p>This method is static to allow easier access from the {@link MemoryArchivist}. Requiring a reference
 	 * would imply that the WebRuntimeMonitor is always created before the archivist, which may not hold for all
 	 * deployment modes.
-	 * 
-	 * Similarly, no handler implements the JsonArchivist interface itself but instead contains a separate implementing
+	 *
+	 <p>Similarly, no handler implements the JsonArchivist interface itself but instead contains a separate implementing
 	 * class; otherwise we would either instantiate several handlers even though their main functionality isn't
 	 * required, or yet again require that the WebRuntimeMonitor is started before the archivist.
-	 * 
+	 *
 	 * @return array of all JsonArchivists relevant for the history server
 	 */
 	public static JsonArchivist[] getJsonArchivists() {
@@ -400,13 +399,13 @@ public class WebRuntimeMonitor implements WebMonitor {
 			new CheckpointConfigHandler.CheckpointConfigJsonArchivist(),
 			new CheckpointStatsDetailsHandler.CheckpointStatsDetailsJsonArchivist(),
 			new CheckpointStatsDetailsSubtasksHandler.CheckpointStatsDetailsSubtasksJsonArchivist(),
-				
+
 			new JobVertexDetailsHandler.JobVertexDetailsJsonArchivist(),
 			new SubtasksTimesHandler.SubtasksTimesJsonArchivist(),
 			new JobVertexTaskManagersHandler.JobVertexTaskManagersJsonArchivist(),
 			new JobVertexAccumulatorsHandler.JobVertexAccumulatorsJsonArchivist(),
 			new SubtasksAllAccumulatorsHandler.SubtasksAllAccumulatorsJsonArchivist(),
-			
+
 			new SubtaskExecutionAttemptDetailsHandler.SubtaskExecutionAttemptDetailsJsonArchivist(),
 			new SubtaskExecutionAttemptAccumulatorsHandler.SubtaskExecutionAttemptAccumulatorsJsonArchivist()
 			};
@@ -416,7 +415,7 @@ public class WebRuntimeMonitor implements WebMonitor {
 	@Override
 	public void start(String jobManagerAkkaUrl) throws Exception {
 		LOG.info("Starting with JobManager {} on port {}", jobManagerAkkaUrl, getServerPort());
-		
+
 		synchronized (startupShutdownLock) {
 			jobManagerAddressPromise.success(jobManagerAkkaUrl);
 			leaderRetrievalService.start(retriever);
@@ -487,31 +486,31 @@ public class WebRuntimeMonitor implements WebMonitor {
 	 * {@link RuntimeMonitorHandlerBase} with the given {@link Router} for the respective REST method.
 	 * The REST paths under which they are registered are defined by the handlers. **/
 
-	private void GET(Router router, RequestHandler handler) {
-		GET(router, handler(handler));
+	private void get(Router router, RequestHandler handler) {
+		get(router, handler(handler));
 	}
 
-	private void GET(Router router, RuntimeMonitorHandlerBase handler) {
+	private void get(Router router, RuntimeMonitorHandlerBase handler) {
 		for (String path : handler.getPaths()) {
 			router.GET(path, handler);
 		}
 	}
 
-	private void DELETE(Router router, RequestHandler handler) {
-		DELETE(router, handler(handler));
+	private void delete(Router router, RequestHandler handler) {
+		delete(router, handler(handler));
 	}
 
-	private void DELETE(Router router, RuntimeMonitorHandlerBase handler) {
+	private void delete(Router router, RuntimeMonitorHandlerBase handler) {
 		for (String path : handler.getPaths()) {
 			router.DELETE(path, handler);
 		}
 	}
 
-	private void POST(Router router, RequestHandler handler) {
-		POST(router, handler(handler));
+	private void post(Router router, RequestHandler handler) {
+		post(router, handler(handler));
 	}
 
-	private void POST(Router router, RuntimeMonitorHandlerBase handler) {
+	private void post(Router router, RuntimeMonitorHandlerBase handler) {
 		for (String path : handler.getPaths()) {
 			router.POST(path, handler);
 		}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/MimeTypes.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/MimeTypes.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/MimeTypes.java
index 668747c..4834cbc 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/MimeTypes.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/MimeTypes.java
@@ -22,23 +22,23 @@ import java.util.HashMap;
 
 /**
  * Simple utility class that resolves file extensions to MIME types.
- * <p>
- * There are various solutions built into Java that depend on extra resource and configuration
+ *
+ * <p>There are various solutions built into Java that depend on extra resource and configuration
  * files. They are designed to be composable and extensible, but also unfortunately tricky to control.
  * This is meant to be a simple solution that may eventually be subsumed by a better one.
  */
 public class MimeTypes {
 
-	/** The default mime type */
+	/** The default mime type. */
 	private static final String DEFAULT_MIME_TYPE = "application/octet-stream";
-	
-	/** The map with the constants */
+
+	/** The map with the constants. */
 	private static final HashMap<String, String> MIME_MAP = new HashMap<String, String>();
 
 	/**
 	 * Gets the MIME type for the file with the given extension. If the mime type is not recognized,
 	 * this method returns null.
-	 * 
+	 *
 	 * @param fileExtension The file extension.
 	 * @return The MIME type, or {@code null}, if the file extension is not recognized.
 	 */
@@ -68,7 +68,7 @@ public class MimeTypes {
 
 	/**
 	 * Gets the default MIME type, which is {@code "application/octet-stream"}.
-	 * 
+	 *
 	 * @return The default MIME type.
 	 */
 	public static String getDefaultMimeType() {
@@ -78,13 +78,13 @@ public class MimeTypes {
 	// ------------------------------------------------------------------------
 	//  prevent instantiation
 	// ------------------------------------------------------------------------
-	
+
 	private MimeTypes() {}
-	
+
 	// ------------------------------------------------------------------------
 	//  initialization
 	// ------------------------------------------------------------------------
-	
+
 	static {
 		// text types
 		MIME_MAP.put("html", "text/html");
@@ -96,11 +96,11 @@ public class MimeTypes {
 		MIME_MAP.put("err", "text/plain");
 		MIME_MAP.put("xml", "text/xml");
 		MIME_MAP.put("csv", "text/csv");
-		
+
 		// application types
 		MIME_MAP.put("js", "application/javascript");
 		MIME_MAP.put("json", "application/json");
-		
+
 		// image types
 		MIME_MAP.put("png", "image/png");
 		MIME_MAP.put("jpg", "image/jpeg");
@@ -110,7 +110,7 @@ public class MimeTypes {
 		MIME_MAP.put("tiff", "image/tiff");
 		MIME_MAP.put("tff", "image/tiff");
 		MIME_MAP.put("bmp", "image/bmp");
-		
+
 		// fonts
 		MIME_MAP.put("woff", "application/font-woff");
 		MIME_MAP.put("woff2", "application/font-woff2");

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
index 406baf0..4efa926 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/files/StaticFileServerHandler.java
@@ -26,6 +26,10 @@ package org.apache.flink.runtime.webmonitor.files;
  * https://github.com/netty/netty/blob/4.0/example/src/main/java/io/netty/example/http/file/HttpStaticFileServerHandler.java
  *****************************************************************************/
 
+import org.apache.flink.runtime.instance.ActorGateway;
+import org.apache.flink.runtime.webmonitor.JobManagerRetriever;
+import org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils;
+
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelFuture;
 import io.netty.channel.ChannelFutureListener;
@@ -47,16 +51,8 @@ import io.netty.handler.codec.http.router.Routed;
 import io.netty.handler.ssl.SslHandler;
 import io.netty.handler.stream.ChunkedFile;
 import io.netty.util.CharsetUtil;
-import org.apache.flink.runtime.instance.ActorGateway;
-import org.apache.flink.runtime.webmonitor.JobManagerRetriever;
-import org.apache.flink.runtime.webmonitor.handlers.HandlerRedirectUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import scala.Option;
-import scala.Tuple2;
-import scala.concurrent.Await;
-import scala.concurrent.Future;
-import scala.concurrent.duration.FiniteDuration;
 
 import java.io.File;
 import java.io.FileNotFoundException;
@@ -75,6 +71,12 @@ import java.util.GregorianCalendar;
 import java.util.Locale;
 import java.util.TimeZone;
 
+import scala.Option;
+import scala.Tuple2;
+import scala.concurrent.Await;
+import scala.concurrent.Future;
+import scala.concurrent.duration.FiniteDuration;
+
 import static io.netty.handler.codec.http.HttpHeaders.Names.CACHE_CONTROL;
 import static io.netty.handler.codec.http.HttpHeaders.Names.CONNECTION;
 import static io.netty.handler.codec.http.HttpHeaders.Names.CONTENT_TYPE;
@@ -99,34 +101,33 @@ import static org.apache.flink.util.Preconditions.checkNotNull;
 @ChannelHandler.Sharable
 public class StaticFileServerHandler extends SimpleChannelInboundHandler<Routed> {
 
-	/** Default logger, if none is specified */
+	/** Default logger, if none is specified. */
 	private static final Logger DEFAULT_LOGGER = LoggerFactory.getLogger(StaticFileServerHandler.class);
 
-	/** Timezone in which this server answers its "if-modified" requests */
+	/** Timezone in which this server answers its "if-modified" requests. */
 	private static final TimeZone GMT_TIMEZONE = TimeZone.getTimeZone("GMT");
 
-	/** Date format for HTTP */
+	/** Date format for HTTP. */
 	public static final String HTTP_DATE_FORMAT = "EEE, dd MMM yyyy HH:mm:ss zzz";
 
-	/** Be default, we allow files to be cached for 5 minutes */
+	/** Be default, we allow files to be cached for 5 minutes. */
 	private static final int HTTP_CACHE_SECONDS = 300;
 
 	// ------------------------------------------------------------------------
 
-	/** JobManager retriever */
 	private final JobManagerRetriever retriever;
 
 	private final Future<String> localJobManagerAddressFuture;
 
 	private final FiniteDuration timeout;
 
-	/** The path in which the static documents are */
+	/** The path in which the static documents are. */
 	private final File rootPath;
 
-	/** Whether the web service has https enabled */
+	/** Whether the web service has https enabled. */
 	private final boolean httpsEnabled;
 
-	/** The log for all error reporting */
+	/** The log for all error reporting. */
 	private final Logger logger;
 
 	private String localJobManagerAddress;
@@ -218,7 +219,7 @@ public class StaticFileServerHandler extends SimpleChannelInboundHandler<Routed>
 			// file does not exist. Try to load it with the classloader
 			ClassLoader cl = StaticFileServerHandler.class.getClassLoader();
 
-			try(InputStream resourceStream = cl.getResourceAsStream("web" + requestPath)) {
+			try (InputStream resourceStream = cl.getResourceAsStream("web" + requestPath)) {
 				boolean success = false;
 				try {
 					if (resourceStream != null) {
@@ -282,7 +283,7 @@ public class StaticFileServerHandler extends SimpleChannelInboundHandler<Routed>
 				return;
 			}
 		}
-		
+
 		if (logger.isDebugEnabled()) {
 			logger.debug("Responding with file '" + file.getAbsolutePath() + '\'');
 		}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractExecutionGraphRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractExecutionGraphRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractExecutionGraphRequestHandler.java
index 8cd70e9..d6c17af 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractExecutionGraphRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractExecutionGraphRequestHandler.java
@@ -31,9 +31,9 @@ import java.util.Map;
  * that can be retrieved via "jobid" parameter.
  */
 public abstract class AbstractExecutionGraphRequestHandler extends AbstractJsonRequestHandler {
-	
+
 	private final ExecutionGraphHolder executionGraphHolder;
-	
+
 	public AbstractExecutionGraphRequestHandler(ExecutionGraphHolder executionGraphHolder) {
 		this.executionGraphHolder = executionGraphHolder;
 	}
@@ -50,16 +50,16 @@ public abstract class AbstractExecutionGraphRequestHandler extends AbstractJsonR
 			jid = JobID.fromHexString(jidString);
 		}
 		catch (Exception e) {
-			throw new RuntimeException("Invalid JobID string '" + jidString + "': " + e.getMessage()); 
+			throw new RuntimeException("Invalid JobID string '" + jidString + "': " + e.getMessage());
 		}
-		
+
 		AccessExecutionGraph eg = executionGraphHolder.getExecutionGraph(jid, jobManager);
 		if (eg == null) {
 			throw new NotFoundException("Could not find job with id " + jid);
 		}
-		
+
 		return handleRequest(eg, pathParams);
 	}
-	
+
 	public abstract String handleRequest(AccessExecutionGraph graph, Map<String, String> params) throws Exception;
 }

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJobVertexRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJobVertexRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJobVertexRequestHandler.java
index 38243e5..af9fc6c 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJobVertexRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJobVertexRequestHandler.java
@@ -27,10 +27,10 @@ import java.util.Map;
 
 /**
  * Base class for request handlers whose response depends on a specific job vertex (defined
- * via the "vertexid" parameter) in a specific job, defined via (defined voa the "jobid" parameter).  
+ * via the "vertexid" parameter) in a specific job, defined via (defined voa the "jobid" parameter).
  */
 public abstract class AbstractJobVertexRequestHandler extends AbstractExecutionGraphRequestHandler {
-	
+
 	public AbstractJobVertexRequestHandler(ExecutionGraphHolder executionGraphHolder) {
 		super(executionGraphHolder);
 	}
@@ -65,6 +65,6 @@ public abstract class AbstractJobVertexRequestHandler extends AbstractExecutionG
 			return null;
 		}
 	}
-	
+
 	public abstract String handleRequest(AccessExecutionJobVertex jobVertex, Map<String, String> params) throws Exception;
 }

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJsonRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJsonRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJsonRequestHandler.java
index ae163cb..1d317c4 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJsonRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractJsonRequestHandler.java
@@ -18,13 +18,14 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
+import org.apache.flink.runtime.instance.ActorGateway;
+
 import io.netty.buffer.Unpooled;
 import io.netty.handler.codec.http.DefaultFullHttpResponse;
 import io.netty.handler.codec.http.FullHttpResponse;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponseStatus;
 import io.netty.handler.codec.http.HttpVersion;
-import org.apache.flink.runtime.instance.ActorGateway;
 
 import java.nio.charset.Charset;
 import java.util.Map;

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskAttemptRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskAttemptRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskAttemptRequestHandler.java
index 1eab21c..2792008 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskAttemptRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskAttemptRequestHandler.java
@@ -28,14 +28,14 @@ import java.util.Map;
  * Base class for request handlers whose response depends on a specific subtask execution attempt
  * (defined via the "attempt" parameter) of a specific subtask (defined via the
  * "subtasknum" parameter) in a specific job vertex (defined via the "vertexid" parameter) in a
- * specific job, defined via (defined voa the "jobid" parameter).  
+ * specific job, defined via (defined voa the "jobid" parameter).
  */
 public abstract class AbstractSubtaskAttemptRequestHandler extends AbstractSubtaskRequestHandler {
-	
+
 	public AbstractSubtaskAttemptRequestHandler(ExecutionGraphHolder executionGraphHolder) {
 		super(executionGraphHolder);
 	}
-	
+
 	@Override
 	public String handleRequest(AccessExecutionVertex vertex, Map<String, String> params) throws Exception {
 		final String attemptNumberString = params.get("attempt");
@@ -50,7 +50,7 @@ public abstract class AbstractSubtaskAttemptRequestHandler extends AbstractSubta
 		catch (NumberFormatException e) {
 			throw new RuntimeException("Invalid attempt number parameter");
 		}
-		
+
 		final AccessExecution currentAttempt = vertex.getCurrentExecutionAttempt();
 		if (attempt == currentAttempt.getAttemptNumber()) {
 			return handleRequest(currentAttempt, params);

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskRequestHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskRequestHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskRequestHandler.java
index d6b279c..b977228 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskRequestHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/AbstractSubtaskRequestHandler.java
@@ -27,10 +27,10 @@ import java.util.Map;
 /**
  * Base class for request handlers whose response depends on a specific subtask (defined via the
  * "subtasknum" parameter) in a specific job vertex (defined via the "vertexid" parameter) in a
- * specific job, defined via (defined voa the "jobid" parameter).  
+ * specific job, defined via (defined voa the "jobid" parameter).
  */
 public abstract class AbstractSubtaskRequestHandler extends AbstractJobVertexRequestHandler {
-	
+
 	public AbstractSubtaskRequestHandler(ExecutionGraphHolder executionGraphHolder) {
 		super(executionGraphHolder);
 	}
@@ -49,11 +49,11 @@ public abstract class AbstractSubtaskRequestHandler extends AbstractJobVertexReq
 		catch (NumberFormatException e) {
 			throw new RuntimeException("Invalid subtask number parameter");
 		}
-		
+
 		if (subtask < 0 || subtask >= jobVertex.getParallelism()) {
-			throw new RuntimeException("subtask does not exist: " + subtask); 
+			throw new RuntimeException("subtask does not exist: " + subtask);
 		}
-		
+
 		final AccessExecutionVertex vertex = jobVertex.getTaskVertices()[subtask];
 		return handleRequest(vertex, params);
 	}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
index 2bd055d..816ef24 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ClusterOverviewHandler.java
@@ -18,18 +18,20 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.messages.webmonitor.RequestStatusOverview;
 import org.apache.flink.runtime.messages.webmonitor.StatusOverview;
 import org.apache.flink.runtime.util.EnvironmentInformation;
-import scala.concurrent.Await;
-import scala.concurrent.Future;
-import scala.concurrent.duration.FiniteDuration;
+
+import com.fasterxml.jackson.core.JsonGenerator;
 
 import java.io.StringWriter;
 import java.util.Map;
 
+import scala.concurrent.Await;
+import scala.concurrent.Future;
+import scala.concurrent.duration.FiniteDuration;
+
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
@@ -45,7 +47,7 @@ public class ClusterOverviewHandler extends AbstractJsonRequestHandler {
 	private static final String commitID = EnvironmentInformation.getRevisionInformation().commitId;
 
 	private final FiniteDuration timeout;
-	
+
 	public ClusterOverviewHandler(FiniteDuration timeout) {
 		this.timeout = checkNotNull(timeout);
 	}
@@ -64,7 +66,7 @@ public class ClusterOverviewHandler extends AbstractJsonRequestHandler {
 				StatusOverview overview = (StatusOverview) Await.result(future, timeout);
 
 				StringWriter writer = new StringWriter();
-				JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
+				JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
 
 				gen.writeStartObject();
 				gen.writeNumberField("taskmanagers", overview.getNumTaskManagersConnected());

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ConstantTextHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ConstantTextHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ConstantTextHandler.java
index 53f9f04..61e2958 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ConstantTextHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/ConstantTextHandler.java
@@ -18,6 +18,8 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
+import org.apache.flink.configuration.ConfigConstants;
+
 import io.netty.buffer.Unpooled;
 import io.netty.channel.ChannelHandler;
 import io.netty.channel.ChannelHandlerContext;
@@ -29,7 +31,6 @@ import io.netty.handler.codec.http.HttpResponseStatus;
 import io.netty.handler.codec.http.HttpVersion;
 import io.netty.handler.codec.http.router.KeepAliveWrite;
 import io.netty.handler.codec.http.router.Routed;
-import org.apache.flink.configuration.ConfigConstants;
 
 /**
  * Responder that returns a constant String.

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobIdsHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobIdsHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobIdsHandler.java
index 94b1c16..9d0b863 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobIdsHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobIdsHandler.java
@@ -18,18 +18,20 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.api.common.JobID;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.messages.webmonitor.JobsWithIDsOverview;
 import org.apache.flink.runtime.messages.webmonitor.RequestJobsWithIDsOverview;
-import scala.concurrent.Await;
-import scala.concurrent.Future;
-import scala.concurrent.duration.FiniteDuration;
+
+import com.fasterxml.jackson.core.JsonGenerator;
 
 import java.io.StringWriter;
 import java.util.Map;
 
+import scala.concurrent.Await;
+import scala.concurrent.Future;
+import scala.concurrent.duration.FiniteDuration;
+
 import static java.util.Objects.requireNonNull;
 
 /**
@@ -42,7 +44,7 @@ public class CurrentJobIdsHandler extends AbstractJsonRequestHandler {
 	private static final String CURRENT_JOB_IDS_REST_PATH = "/jobs";
 
 	private final FiniteDuration timeout;
-	
+
 	public CurrentJobIdsHandler(FiniteDuration timeout) {
 		this.timeout = requireNonNull(timeout);
 	}
@@ -51,7 +53,7 @@ public class CurrentJobIdsHandler extends AbstractJsonRequestHandler {
 	public String[] getPaths() {
 		return new String[]{CURRENT_JOB_IDS_REST_PATH};
 	}
-	
+
 	@Override
 	public String handleJsonRequest(Map<String, String> pathParams, Map<String, String> queryParams, ActorGateway jobManager) throws Exception {
 		// we need no parameters, get all requests
@@ -59,38 +61,38 @@ public class CurrentJobIdsHandler extends AbstractJsonRequestHandler {
 			if (jobManager != null) {
 				Future<Object> future = jobManager.ask(RequestJobsWithIDsOverview.getInstance(), timeout);
 				JobsWithIDsOverview overview = (JobsWithIDsOverview) Await.result(future, timeout);
-	
+
 				StringWriter writer = new StringWriter();
-				JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
-	
+				JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
+
 				gen.writeStartObject();
-	
+
 				gen.writeArrayFieldStart("jobs-running");
 				for (JobID jid : overview.getJobsRunningOrPending()) {
 					gen.writeString(jid.toString());
 				}
 				gen.writeEndArray();
-	
+
 				gen.writeArrayFieldStart("jobs-finished");
 				for (JobID jid : overview.getJobsFinished()) {
 					gen.writeString(jid.toString());
 				}
 				gen.writeEndArray();
-	
+
 				gen.writeArrayFieldStart("jobs-cancelled");
 				for (JobID jid : overview.getJobsCancelled()) {
 					gen.writeString(jid.toString());
 				}
 				gen.writeEndArray();
-	
+
 				gen.writeArrayFieldStart("jobs-failed");
 				for (JobID jid : overview.getJobsFailed()) {
 					gen.writeString(jid.toString());
 				}
 				gen.writeEndArray();
-	
+
 				gen.writeEndObject();
-	
+
 				gen.close();
 				return writer.toString();
 			}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobsOverviewHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobsOverviewHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobsOverviewHandler.java
index 60a2b27..d0518c8 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobsOverviewHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/CurrentJobsOverviewHandler.java
@@ -18,19 +18,17 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.runtime.execution.ExecutionState;
 import org.apache.flink.runtime.executiongraph.AccessExecutionGraph;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.messages.webmonitor.JobDetails;
 import org.apache.flink.runtime.messages.webmonitor.MultipleJobsDetails;
 import org.apache.flink.runtime.messages.webmonitor.RequestJobDetails;
+import org.apache.flink.runtime.webmonitor.WebMonitorUtils;
 import org.apache.flink.runtime.webmonitor.history.ArchivedJson;
 import org.apache.flink.runtime.webmonitor.history.JsonArchivist;
-import org.apache.flink.runtime.webmonitor.WebMonitorUtils;
-import scala.concurrent.Await;
-import scala.concurrent.Future;
-import scala.concurrent.duration.FiniteDuration;
+
+import com.fasterxml.jackson.core.JsonGenerator;
 
 import java.io.IOException;
 import java.io.StringWriter;
@@ -38,6 +36,10 @@ import java.util.Collection;
 import java.util.Collections;
 import java.util.Map;
 
+import scala.concurrent.Await;
+import scala.concurrent.Future;
+import scala.concurrent.duration.FiniteDuration;
+
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
@@ -50,11 +52,10 @@ public class CurrentJobsOverviewHandler extends AbstractJsonRequestHandler {
 	private static final String COMPLETED_JOBS_REST_PATH = "/joboverview/completed";
 
 	private final FiniteDuration timeout;
-	
+
 	private final boolean includeRunningJobs;
 	private final boolean includeFinishedJobs;
 
-	
 	public CurrentJobsOverviewHandler(
 			FiniteDuration timeout,
 			boolean includeRunningJobs,
@@ -83,23 +84,22 @@ public class CurrentJobsOverviewHandler extends AbstractJsonRequestHandler {
 			if (jobManager != null) {
 				Future<Object> future = jobManager.ask(
 						new RequestJobDetails(includeRunningJobs, includeFinishedJobs), timeout);
-				
+
 				MultipleJobsDetails result = (MultipleJobsDetails) Await.result(future, timeout);
-	
+
 				final long now = System.currentTimeMillis();
-	
+
 				StringWriter writer = new StringWriter();
-				JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
+				JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
 				gen.writeStartObject();
-				
-				
+
 				if (includeRunningJobs && includeFinishedJobs) {
 					gen.writeArrayFieldStart("running");
 					for (JobDetails detail : result.getRunningJobs()) {
 						writeJobDetailOverviewAsJson(detail, gen, now);
 					}
 					gen.writeEndArray();
-	
+
 					gen.writeArrayFieldStart("finished");
 					for (JobDetails detail : result.getFinishedJobs()) {
 						writeJobDetailOverviewAsJson(detail, gen, now);
@@ -113,7 +113,7 @@ public class CurrentJobsOverviewHandler extends AbstractJsonRequestHandler {
 					}
 					gen.writeEndArray();
 				}
-	
+
 				gen.writeEndObject();
 				gen.close();
 				return writer.toString();
@@ -127,12 +127,15 @@ public class CurrentJobsOverviewHandler extends AbstractJsonRequestHandler {
 		}
 	}
 
+	/**
+	 * Archivist for the CurrentJobsOverviewHandler.
+	 */
 	public static class CurrentJobsOverviewJsonArchivist implements JsonArchivist {
 
 		@Override
 		public Collection<ArchivedJson> archiveJsonWithPath(AccessExecutionGraph graph) throws IOException {
 			StringWriter writer = new StringWriter();
-			try (JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer)) {
+			try (JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer)) {
 				gen.writeStartObject();
 				gen.writeArrayFieldStart("running");
 				gen.writeEndArray();

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/DashboardConfigHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/DashboardConfigHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/DashboardConfigHandler.java
index 6ad024f..312c890 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/DashboardConfigHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/DashboardConfigHandler.java
@@ -18,10 +18,11 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.util.EnvironmentInformation;
 
+import com.fasterxml.jackson.core.JsonGenerator;
+
 import java.io.IOException;
 import java.io.StringWriter;
 import java.util.Map;
@@ -34,10 +35,10 @@ import java.util.TimeZone;
  */
 public class DashboardConfigHandler extends AbstractJsonRequestHandler {
 
-	private static String DASHBOARD_CONFIG_REST_PATH = "/config";
-	
+	private static final String DASHBOARD_CONFIG_REST_PATH = "/config";
+
 	private final String configString;
-	
+
 	public DashboardConfigHandler(long refreshInterval) {
 		try {
 			this.configString = createConfigJson(refreshInterval);
@@ -52,7 +53,7 @@ public class DashboardConfigHandler extends AbstractJsonRequestHandler {
 	public String[] getPaths() {
 		return new String[]{DASHBOARD_CONFIG_REST_PATH};
 	}
-	
+
 	@Override
 	public String handleJsonRequest(Map<String, String> pathParams, Map<String, String> queryParams, ActorGateway jobManager) throws Exception {
 		return this.configString;
@@ -60,8 +61,8 @@ public class DashboardConfigHandler extends AbstractJsonRequestHandler {
 
 	public static String createConfigJson(long refreshInterval) throws IOException {
 		StringWriter writer = new StringWriter();
-		JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
-	
+		JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
+
 		TimeZone timeZone = TimeZone.getDefault();
 		String timeZoneName = timeZone.getDisplayName();
 		long timeZoneOffset = timeZone.getRawOffset();

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtils.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtils.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtils.java
index 144e519..510291a 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtils.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/HandlerRedirectUtils.java
@@ -18,23 +18,25 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
+import org.apache.flink.configuration.ConfigConstants;
+import org.apache.flink.runtime.akka.AkkaUtils;
+import org.apache.flink.runtime.instance.ActorGateway;
+import org.apache.flink.runtime.webmonitor.files.MimeTypes;
+
 import io.netty.buffer.Unpooled;
 import io.netty.handler.codec.http.DefaultFullHttpResponse;
 import io.netty.handler.codec.http.HttpHeaders;
 import io.netty.handler.codec.http.HttpResponse;
 import io.netty.handler.codec.http.HttpResponseStatus;
 import io.netty.handler.codec.http.HttpVersion;
-import org.apache.flink.configuration.ConfigConstants;
-import org.apache.flink.runtime.akka.AkkaUtils;
-import org.apache.flink.runtime.instance.ActorGateway;
-import org.apache.flink.runtime.webmonitor.files.MimeTypes;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import scala.Tuple2;
 
 import java.util.regex.Matcher;
 import java.util.regex.Pattern;
 
+import scala.Tuple2;
+
 import static org.apache.flink.util.Preconditions.checkNotNull;
 
 /**
@@ -48,8 +50,8 @@ public class HandlerRedirectUtils {
 
 	private static final Logger LOG = LoggerFactory.getLogger(HandlerRedirectUtils.class);
 
-	/** Pattern to extract the host from an remote Akka URL */
-	private final static Pattern LeaderAddressHostPattern = Pattern.compile("^.+@(.+):([0-9]+)/user/.+$");
+	/** Pattern to extract the host from an remote Akka URL. */
+	private static final Pattern LeaderAddressHostPattern = Pattern.compile("^.+@(.+):([0-9]+)/user/.+$");
 
 	public static String getRedirectAddress(
 			String localJobManagerAddress,

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarAccessDeniedHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarAccessDeniedHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarAccessDeniedHandler.java
index f0e3faf..4a21fec 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarAccessDeniedHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarAccessDeniedHandler.java
@@ -22,6 +22,9 @@ import org.apache.flink.runtime.instance.ActorGateway;
 
 import java.util.Map;
 
+/**
+ * Handler to deny access to jar-related REST calls.
+ */
 public class JarAccessDeniedHandler extends AbstractJsonRequestHandler {
 
 	private static final String ERROR_MESSAGE = "{\"error\": \"Web submission interface is not " +

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java
index 5abe117..d86a21b 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarActionHandler.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.annotation.VisibleForTesting;
 import org.apache.flink.api.java.tuple.Tuple2;
 import org.apache.flink.client.program.ClusterClient;
@@ -38,6 +37,8 @@ import org.apache.flink.runtime.jobgraph.JobGraph;
 import org.apache.flink.runtime.jobgraph.SavepointRestoreSettings;
 import org.apache.flink.util.ExceptionUtils;
 
+import com.fasterxml.jackson.core.JsonGenerator;
+
 import java.io.File;
 import java.io.StringWriter;
 import java.net.URISyntaxException;
@@ -50,10 +51,9 @@ import java.util.Map;
  * Abstract handler for fetching plan for a jar or running a jar.
  */
 public abstract class JarActionHandler extends AbstractJsonRequestHandler {
-	
+
 	private final File jarDir;
 
-	
 	public JarActionHandler(File jarDirectory) {
 		jarDir = jarDirectory;
 	}
@@ -96,13 +96,13 @@ public abstract class JarActionHandler extends AbstractJsonRequestHandler {
 
 	protected String sendError(Exception e) throws Exception {
 		StringWriter writer = new StringWriter();
-		JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
-		
+		JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
+
 		gen.writeStartObject();
 		gen.writeStringField("error", ExceptionUtils.stringifyException(e));
 		gen.writeEndObject();
 		gen.close();
-		
+
 		return writer.toString();
 	}
 
@@ -162,7 +162,7 @@ public abstract class JarActionHandler extends AbstractJsonRequestHandler {
 			// Program args
 			String[] programArgs = new String[0];
 			String programArgsOpt = queryParams.get("program-args");
-			if (programArgsOpt!= null && !programArgsOpt.equals("")) {
+			if (programArgsOpt != null && !programArgsOpt.equals("")) {
 				List<String> args = tokenizeArguments(programArgsOpt);
 				programArgs = args.toArray(new String[args.size()]);
 			}

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java
index f3bf231..2572a76 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarDeleteHandler.java
@@ -18,9 +18,10 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.runtime.instance.ActorGateway;
 
+import com.fasterxml.jackson.core.JsonGenerator;
+
 import java.io.File;
 import java.io.FilenameFilter;
 import java.io.StringWriter;
@@ -60,7 +61,7 @@ public class JarDeleteHandler extends AbstractJsonRequestHandler {
 				success = success || f.delete();
 			}
 			StringWriter writer = new StringWriter();
-			JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
+			JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
 			gen.writeStartObject();
 			if (!success) {
 				// this seems to always fail on Windows.

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java
index 81b5e34..4dd20b1 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarListHandler.java
@@ -18,11 +18,12 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.client.program.PackagedProgram;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.webmonitor.RuntimeMonitorHandler;
 
+import com.fasterxml.jackson.core.JsonGenerator;
+
 import java.io.File;
 import java.io.FilenameFilter;
 import java.io.IOException;
@@ -31,6 +32,9 @@ import java.util.Map;
 import java.util.jar.JarFile;
 import java.util.jar.Manifest;
 
+/**
+ * Handle request for listing uploaded jars.
+ */
 public class JarListHandler extends AbstractJsonRequestHandler {
 
 	static final String JAR_LIST_REST_PATH = "/jars";
@@ -50,8 +54,8 @@ public class JarListHandler extends AbstractJsonRequestHandler {
 	public String handleJsonRequest(Map<String, String> pathParams, Map<String, String> queryParams, ActorGateway jobManager) throws Exception {
 		try {
 			StringWriter writer = new StringWriter();
-			JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
-			
+			JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
+
 			gen.writeStartObject();
 			gen.writeStringField("address", queryParams.get(RuntimeMonitorHandler.WEB_MONITOR_ADDRESS_KEY));
 			gen.writeArrayFieldStart("files");
@@ -62,11 +66,11 @@ public class JarListHandler extends AbstractJsonRequestHandler {
 					return name.endsWith(".jar");
 				}
 			});
-			
+
 			for (File f : list) {
 				// separate the uuid and the name parts.
 				String id = f.getName();
-				
+
 				int startIndex = id.indexOf("_");
 				if (startIndex < 0) {
 					continue;
@@ -75,13 +79,13 @@ public class JarListHandler extends AbstractJsonRequestHandler {
 				if (name.length() < 5 || !name.endsWith(".jar")) {
 					continue;
 				}
-				
+
 				gen.writeStartObject();
 				gen.writeStringField("id", id);
 				gen.writeStringField("name", name);
 				gen.writeNumberField("uploaded", f.lastModified());
 				gen.writeArrayFieldStart("entry");
-				
+
 				String[] classes = new String[0];
 				try {
 					JarFile jar = new JarFile(f);

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
index d121119..1b25e7f 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarPlanHandler.java
@@ -18,11 +18,12 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.jobgraph.JobGraph;
 import org.apache.flink.runtime.jobgraph.jsonplan.JsonPlanGenerator;
 
+import com.fasterxml.jackson.core.JsonGenerator;
+
 import java.io.File;
 import java.io.StringWriter;
 import java.util.Map;
@@ -49,7 +50,7 @@ public class JarPlanHandler extends JarActionHandler {
 			JarActionHandlerConfig config = JarActionHandlerConfig.fromParams(pathParams, queryParams);
 			JobGraph graph = getJobGraphAndClassLoader(config).f0;
 			StringWriter writer = new StringWriter();
-			JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
+			JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
 			gen.writeStartObject();
 			gen.writeFieldName("plan");
 			gen.writeRawValue(JsonPlanGenerator.generatePlan(graph));

http://git-wip-us.apache.org/repos/asf/flink/blob/d481f295/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
----------------------------------------------------------------------
diff --git a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
index 5f39e19..9a7cabe 100644
--- a/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
+++ b/flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/handlers/JarRunHandler.java
@@ -18,7 +18,6 @@
 
 package org.apache.flink.runtime.webmonitor.handlers;
 
-import com.fasterxml.jackson.core.JsonGenerator;
 import org.apache.flink.api.java.tuple.Tuple2;
 import org.apache.flink.client.program.ProgramInvocationException;
 import org.apache.flink.configuration.Configuration;
@@ -26,13 +25,16 @@ import org.apache.flink.runtime.client.JobClient;
 import org.apache.flink.runtime.client.JobExecutionException;
 import org.apache.flink.runtime.instance.ActorGateway;
 import org.apache.flink.runtime.jobgraph.JobGraph;
-import scala.concurrent.duration.FiniteDuration;
+
+import com.fasterxml.jackson.core.JsonGenerator;
 
 import java.io.File;
 import java.io.IOException;
 import java.io.StringWriter;
 import java.util.Map;
 
+import scala.concurrent.duration.FiniteDuration;
+
 /**
  * This handler handles requests to fetch plan for a jar.
  */
@@ -72,7 +74,7 @@ public class JarRunHandler extends JarActionHandler {
 			}
 
 			StringWriter writer = new StringWriter();
-			JsonGenerator gen = JsonFactory.jacksonFactory.createGenerator(writer);
+			JsonGenerator gen = JsonFactory.JACKSON_FACTORY.createGenerator(writer);
 			gen.writeStartObject();
 			gen.writeStringField("jobid", graph.f0.getJobID().toString());
 			gen.writeEndObject();


Mime
View raw message