flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From g...@apache.org
Subject flink git commit: [FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to SingleInputPlanNode
Date Thu, 06 Apr 2017 01:19:48 GMT
Repository: flink
Updated Branches:
  refs/heads/release-1.2 f8255880c -> fea5d1fef


[FLINK-2814] [optimizer] DualInputPlanNode cannot be cast to SingleInputPlanNode

WorksetIterationNode#instantiate loops over all solution and work set
candidates. Since the solution set reference is modified in place when
the predecessor node can be used in its place, swith this variable to
the inner loop.

This closes #3563


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/fea5d1fe
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/fea5d1fe
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/fea5d1fe

Branch: refs/heads/release-1.2
Commit: fea5d1fef24032f5aad863561deaca63d2cc0a28
Parents: f825588
Author: Greg Hogan <code@greghogan.com>
Authored: Fri Mar 17 12:09:34 2017 -0400
Committer: Greg Hogan <code@greghogan.com>
Committed: Wed Apr 5 21:19:03 2017 -0400

----------------------------------------------------------------------
 .../org/apache/flink/optimizer/dag/WorksetIterationNode.java     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/fea5d1fe/flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/WorksetIterationNode.java
----------------------------------------------------------------------
diff --git a/flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/WorksetIterationNode.java
b/flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/WorksetIterationNode.java
index d7ccaca..e62e727 100644
--- a/flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/WorksetIterationNode.java
+++ b/flink-optimizer/src/main/java/org/apache/flink/optimizer/dag/WorksetIterationNode.java
@@ -431,8 +431,8 @@ public class WorksetIterationNode extends TwoInputNode implements IterationNode
 		LocalProperties lp = LocalProperties.EMPTY.addUniqueFields(this.solutionSetKeyFields);
 		
 		// take all combinations of solution set delta and workset plans
-		for (PlanNode solutionSetCandidate : solutionSetDeltaCandidates) {
-			for (PlanNode worksetCandidate : worksetCandidates) {
+		for (PlanNode worksetCandidate : worksetCandidates) {
+			for (PlanNode solutionSetCandidate : solutionSetDeltaCandidates) {
 				// check whether they have the same operator at their latest branching point
 				if (this.singleRoot.areBranchCompatible(solutionSetCandidate, worksetCandidate)) {
 					


Mime
View raw message