flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljos...@apache.org
Subject [21/23] flink git commit: [FLINK-6107] Enable WhitespaceAround check in streaming checkstyle
Date Wed, 26 Apr 2017 10:07:43 GMT
[FLINK-6107] Enable WhitespaceAround check in streaming checkstyle


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/76a7783f
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/76a7783f
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/76a7783f

Branch: refs/heads/master
Commit: 76a7783f49b51f31515b6085c3c69084bdd1686a
Parents: 226aebc
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Authored: Sun Mar 19 15:02:00 2017 +0100
Committer: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Committed: Wed Apr 26 10:36:50 2017 +0200

----------------------------------------------------------------------
 .../api/datastream/StreamProjection.java        |  6 ++---
 .../environment/StreamExecutionEnvironment.java |  2 +-
 .../ContinuousFileMonitoringFunction.java       |  2 +-
 .../source/TimestampedFileInputSplit.java       |  4 +--
 ...BoundedOutOfOrdernessTimestampExtractor.java |  8 +++---
 .../flink/streaming/api/graph/StreamGraph.java  |  2 +-
 .../api/operators/AbstractStreamOperator.java   |  2 +-
 .../streaming/api/operators/StreamSource.java   |  4 +--
 .../api/windowing/evictors/TimeEvictor.java     |  4 +--
 .../streaming/runtime/io/BufferSpiller.java     |  2 +-
 .../windowing/EvictingWindowOperator.java       |  2 +-
 .../operators/windowing/WindowOperator.java     |  2 +-
 .../streaming/runtime/tasks/OperatorChain.java  |  2 +-
 .../streaming/util/typeutils/FieldAccessor.java | 12 ++++-----
 .../util/typeutils/FieldAccessorFactory.java    | 10 +++----
 tools/maven/strict-checkstyle.xml               | 28 ++++++++++----------
 16 files changed, 46 insertions(+), 46 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/StreamProjection.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/StreamProjection.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/StreamProjection.java
index e1e56fd..45e2db4 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/StreamProjection.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/StreamProjection.java
@@ -63,15 +63,15 @@ public class StreamProjection<IN> {
 		if (!dataStream.getType().isTupleType()) {
 			throw new RuntimeException("Only Tuple DataStreams can be projected");
 		}
-		if(fieldIndexes.length == 0) {
+		if (fieldIndexes.length == 0) {
 			throw new IllegalArgumentException("project() needs to select at least one (1) field.");
-		} else if(fieldIndexes.length > Tuple.MAX_ARITY - 1) {
+		} else if (fieldIndexes.length > Tuple.MAX_ARITY - 1) {
 			throw new IllegalArgumentException(
 					"project() may select only up to (" + (Tuple.MAX_ARITY - 1) + ") fields.");
 		}
 
 		int maxFieldIndex = (dataStream.getType()).getArity();
-		for(int i = 0; i < fieldIndexes.length; i++) {
+		for (int i = 0; i < fieldIndexes.length; i++) {
 			Preconditions.checkElementIndex(fieldIndexes[i], maxFieldIndex);
 		}
 

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
index 7a6c7d6..8787e48 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/environment/StreamExecutionEnvironment.java
@@ -1430,7 +1430,7 @@ public abstract class StreamExecutionEnvironment {
 	@SuppressWarnings("unchecked")
 	public <OUT> DataStreamSource<OUT> addSource(SourceFunction<OUT> function,
String sourceName, TypeInformation<OUT> typeInfo) {
 
-		if(typeInfo == null) {
+		if (typeInfo == null) {
 			if (function instanceof ResultTypeQueryable) {
 				typeInfo = ((ResultTypeQueryable<OUT>) function).getProducedType();
 			} else {

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
index 1b76733..332d362 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/ContinuousFileMonitoringFunction.java
@@ -158,7 +158,7 @@ public class ContinuousFileMonitoringFunction<OUT>
 				// The two should be mutually exclusive for the operator, thus we throw the exception.
 
 				throw new IllegalArgumentException(
-					"The " + getClass().getSimpleName() +" has already restored from a previous Flink version.");
+					"The " + getClass().getSimpleName() + " has already restored from a previous Flink version.");
 
 			} else if (retrievedStates.size() == 1) {
 				this.globalModificationTime = retrievedStates.get(0);

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/TimestampedFileInputSplit.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/TimestampedFileInputSplit.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/TimestampedFileInputSplit.java
index 28432c5..ddc3559 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/TimestampedFileInputSplit.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/TimestampedFileInputSplit.java
@@ -59,7 +59,7 @@ public class TimestampedFileInputSplit extends FileInputSplit implements
Compara
 		super(num, file, start, length, hosts);
 
 		Preconditions.checkArgument(modificationTime >= 0 || modificationTime == Long.MIN_VALUE,
-			"Invalid File Split Modification Time: "+ modificationTime +".");
+			"Invalid File Split Modification Time: " + modificationTime + ".");
 
 		this.modificationTime = modificationTime;
 	}
@@ -133,7 +133,7 @@ public class TimestampedFileInputSplit extends FileInputSplit implements
Compara
 
 	@Override
 	public String toString() {
-		return "[" + getSplitNumber() + "] " + getPath() +" mod@ "+
+		return "[" + getSplitNumber() + "] " + getPath() + " mod@ " +
 			modificationTime + " : " + getStart() + " + " + getLength();
 	}
 }

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/timestamps/BoundedOutOfOrdernessTimestampExtractor.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/timestamps/BoundedOutOfOrdernessTimestampExtractor.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/timestamps/BoundedOutOfOrdernessTimestampExtractor.java
index cb1e2ca..982c283 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/timestamps/BoundedOutOfOrdernessTimestampExtractor.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/timestamps/BoundedOutOfOrdernessTimestampExtractor.java
@@ -45,9 +45,9 @@ public abstract class BoundedOutOfOrdernessTimestampExtractor<T> implements
Assi
 	private final long maxOutOfOrderness;
 
 	public BoundedOutOfOrdernessTimestampExtractor(Time maxOutOfOrderness) {
-		if(maxOutOfOrderness.toMilliseconds() < 0) {
+		if (maxOutOfOrderness.toMilliseconds() < 0) {
 			throw new RuntimeException("Tried to set the maximum allowed " +
-				"lateness to "+ maxOutOfOrderness +". This parameter cannot be negative.");
+				"lateness to " + maxOutOfOrderness + ". This parameter cannot be negative.");
 		}
 		this.maxOutOfOrderness = maxOutOfOrderness.toMilliseconds();
 		this.currentMaxTimestamp = Long.MIN_VALUE + this.maxOutOfOrderness;
@@ -69,7 +69,7 @@ public abstract class BoundedOutOfOrdernessTimestampExtractor<T> implements
Assi
 	public final Watermark getCurrentWatermark() {
 		// this guarantees that the watermark never goes backwards.
 		long potentialWM = currentMaxTimestamp - maxOutOfOrderness;
-		if(potentialWM >= lastEmittedWatermark) {
+		if (potentialWM >= lastEmittedWatermark) {
 			lastEmittedWatermark = potentialWM;
 		}
 		return new Watermark(lastEmittedWatermark);
@@ -78,7 +78,7 @@ public abstract class BoundedOutOfOrdernessTimestampExtractor<T> implements
Assi
 	@Override
 	public final long extractTimestamp(T element, long previousElementTimestamp) {
 		long timestamp = extractTimestamp(element);
-		if(timestamp > currentMaxTimestamp) {
+		if (timestamp > currentMaxTimestamp) {
 			currentMaxTimestamp = timestamp;
 		}
 		return timestamp;

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
index 11e40d2..5dd651c 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/graph/StreamGraph.java
@@ -159,7 +159,7 @@ public class StreamGraph extends StreamingPlan {
 
 
 	public boolean isIterative() {
-		return!vertexIDtoLoopTimeout.isEmpty();
+		return !vertexIDtoLoopTimeout.isEmpty();
 	}
 
 	public <IN, OUT> void addSource(Integer vertexID,

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
index 72ab6dd..1ef8614 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/AbstractStreamOperator.java
@@ -786,7 +786,7 @@ public abstract class AbstractStreamOperator<OUT>
 					// ConcurrentModificationExceptions. To avoid unnecessary blocking
 					// of the reportLatency() method, we retry this operation until
 					// it succeeds.
-				} catch(ConcurrentModificationException ignore) {
+				} catch (ConcurrentModificationException ignore) {
 					LOG.debug("Unable to report latency statistics", ignore);
 				}
 			}

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
index 3705068..b7f0d80 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/operators/StreamSource.java
@@ -63,7 +63,7 @@ public class StreamSource<OUT, SRC extends SourceFunction<OUT>>
 		final TimeCharacteristic timeCharacteristic = getOperatorConfig().getTimeCharacteristic();
 
 		LatencyMarksEmitter latencyEmitter = null;
-		if(getExecutionConfig().isLatencyTrackingEnabled()) {
+		if (getExecutionConfig().isLatencyTrackingEnabled()) {
 			latencyEmitter = new LatencyMarksEmitter<>(
 				getProcessingTimeService(),
 				collector,
@@ -95,7 +95,7 @@ public class StreamSource<OUT, SRC extends SourceFunction<OUT>>
 		} finally {
 			// make sure that the context is closed in any case
 			ctx.close();
-			if(latencyEmitter != null) {
+			if (latencyEmitter != null) {
 				latencyEmitter.close();
 			}
 		}

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
index 393a56b..725b0bd 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/windowing/evictors/TimeEvictor.java
@@ -51,14 +51,14 @@ public class TimeEvictor<W extends Window> implements Evictor<Object,
W> {
 
 	@Override
 	public void evictBefore(Iterable<TimestampedValue<Object>> elements, int size,
W window, EvictorContext ctx) {
-		if(!doEvictAfter) {
+		if (!doEvictAfter) {
 			evict(elements, size, ctx);
 		}
 	}
 
 	@Override
 	public void evictAfter(Iterable<TimestampedValue<Object>> elements, int size,
W window, EvictorContext ctx) {
-		if(doEvictAfter) {
+		if (doEvictAfter) {
 			evict(elements, size, ctx);
 		}
 	}

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
index fc2e376..df60b75 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/io/BufferSpiller.java
@@ -255,7 +255,7 @@ public class BufferSpiller {
 
 	@SuppressWarnings("resource")
 	private void createSpillingChannel() throws IOException {
-		currentSpillFile = new File(tempDir, spillFilePrefix + (fileCounter++) +".buffer");
+		currentSpillFile = new File(tempDir, spillFilePrefix + (fileCounter++) + ".buffer");
 		currentChannel = new RandomAccessFile(currentSpillFile, "rw").getChannel();
 	}
 

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
index 3c98223..f9654e5 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/EvictingWindowOperator.java
@@ -354,7 +354,7 @@ public class EvictingWindowOperator<K, IN, OUT, W extends Window>
 		//work around to fix FLINK-4369, remove the evicted elements from the windowState.
 		//this is inefficient, but there is no other way to remove elements from ListState, which
is an AppendingState.
 		windowState.clear();
-		for(TimestampedValue<IN> record : recordsWithTimestamp) {
+		for (TimestampedValue<IN> record : recordsWithTimestamp) {
 			windowState.add(record.getStreamRecord());
 		}
 	}

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
index c87ac63..8d8f6b5 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/operators/windowing/WindowOperator.java
@@ -1202,7 +1202,7 @@ public class WindowOperator<K, IN, ACC, OUT, W extends Window>
 
 		// just to read all the rest, although we do not really use this information.
 		int numProcessingTimeTimerTimestamp = in.readInt();
-		for (int i = 0; i< numProcessingTimeTimerTimestamp; i++) {
+		for (int i = 0; i < numProcessingTimeTimerTimestamp; i++) {
 			in.readLong();
 			in.readInt();
 		}

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
index d96a386..98fe1d0 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/OperatorChain.java
@@ -561,7 +561,7 @@ public class OperatorChain<OUT, OP extends StreamOperator<OUT>>
implements Strea
 		public void emitLatencyMarker(LatencyMarker latencyMarker) {
 			if (outputs.length <= 0) {
 				// ignore
-			} else if(outputs.length == 1) {
+			} else if (outputs.length == 1) {
 				outputs[0].emitLatencyMarker(latencyMarker);
 			} else {
 				// randomly select an output

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
index c087e70..90c89ac 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessor.java
@@ -120,7 +120,7 @@ public abstract class FieldAccessor<T, F> implements Serializable
{
 		private final int pos;
 
 		public ArrayFieldAccessor(int pos, TypeInformation typeInfo) {
-			if(pos < 0) {
+			if (pos < 0) {
 				throw new CompositeType.InvalidFieldReferenceException("The " + ((Integer) pos).toString()
+ ". field selected on" +
 					" an array, which is an invalid index.");
 			}
@@ -156,7 +156,7 @@ public abstract class FieldAccessor<T, F> implements Serializable
{
 		SimpleTupleFieldAccessor(int pos, TypeInformation<T> typeInfo) {
 			checkNotNull(typeInfo, "typeInfo must not be null.");
 			int arity = ((TupleTypeInfo) typeInfo).getArity();
-			if(pos < 0 || pos >= arity) {
+			if (pos < 0 || pos >= arity) {
 				throw new CompositeType.InvalidFieldReferenceException(
 					"Tried to select " + ((Integer) pos).toString() + ". field on \"" +
 					typeInfo.toString() + "\", which is an invalid index.");
@@ -196,13 +196,13 @@ public abstract class FieldAccessor<T, F> implements Serializable
{
 			checkNotNull(innerAccessor, "innerAccessor must not be null.");
 
 			int arity = ((TupleTypeInfo) typeInfo).getArity();
-			if(pos < 0 || pos >= arity) {
+			if (pos < 0 || pos >= arity) {
 				throw new CompositeType.InvalidFieldReferenceException(
 					"Tried to select " + ((Integer) pos).toString() + ". field on \"" +
 						typeInfo.toString() + "\", which is an invalid index.");
 			}
 
-			if(pos < 0) {
+			if (pos < 0) {
 				throw new CompositeType.InvalidFieldReferenceException("Tried to select " + ((Integer)
pos).toString() + ". field.");
 			}
 
@@ -302,7 +302,7 @@ public abstract class FieldAccessor<T, F> implements Serializable
{
 		SimpleProductFieldAccessor(int pos, TypeInformation<T> typeInfo, ExecutionConfig
config) {
 			checkNotNull(typeInfo, "typeInfo must not be null.");
 			int arity = ((TupleTypeInfoBase) typeInfo).getArity();
-			if(pos < 0 || pos >= arity) {
+			if (pos < 0 || pos >= arity) {
 				throw new CompositeType.InvalidFieldReferenceException(
 					"Tried to select " + ((Integer) pos).toString() + ". field on \"" +
 						typeInfo.toString() + "\", which is an invalid index.");
@@ -346,7 +346,7 @@ public abstract class FieldAccessor<T, F> implements Serializable
{
 
 		RecursiveProductFieldAccessor(int pos, TypeInformation<T> typeInfo, FieldAccessor<R,
F> innerAccessor, ExecutionConfig config) {
 			int arity = ((TupleTypeInfoBase) typeInfo).getArity();
-			if(pos < 0 || pos >= arity) {
+			if (pos < 0 || pos >= arity) {
 				throw new CompositeType.InvalidFieldReferenceException(
 					"Tried to select " + ((Integer) pos).toString() + ". field on \"" +
 						typeInfo.toString() + "\", which is an invalid index.");

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
index 893c640..c46422f 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/util/typeutils/FieldAccessorFactory.java
@@ -198,21 +198,21 @@ public class FieldAccessorFactory implements Serializable {
 	// --------------------------------------------------------------------------------------------------
 
 	private  static final String REGEX_FIELD = "[\\p{L}\\p{Digit}_\\$]*"; // This can start
with a digit (because of Tuples)
-	private static final String REGEX_NESTED_FIELDS = "("+REGEX_FIELD+")(\\.(.+))?";
+	private static final String REGEX_NESTED_FIELDS = "(" + REGEX_FIELD + ")(\\.(.+))?";
 	private static final String REGEX_NESTED_FIELDS_WILDCARD = REGEX_NESTED_FIELDS
-		+"|\\"+ Keys.ExpressionKeys.SELECT_ALL_CHAR
-		+"|\\"+ Keys.ExpressionKeys.SELECT_ALL_CHAR_SCALA;
+		+ "|\\" + Keys.ExpressionKeys.SELECT_ALL_CHAR
+		+ "|\\" + Keys.ExpressionKeys.SELECT_ALL_CHAR_SCALA;
 
 	private static final Pattern PATTERN_NESTED_FIELDS_WILDCARD = Pattern.compile(REGEX_NESTED_FIELDS_WILDCARD);
 
 	private static FieldExpression decomposeFieldExpression(String fieldExpression) {
 		Matcher matcher = PATTERN_NESTED_FIELDS_WILDCARD.matcher(fieldExpression);
 		if (!matcher.matches()) {
-			throw new CompositeType.InvalidFieldReferenceException("Invalid field expression \""+fieldExpression+"\".");
+			throw new CompositeType.InvalidFieldReferenceException("Invalid field expression \"" +
fieldExpression + "\".");
 		}
 
 		String head = matcher.group(0);
-		if(head.equals(Keys.ExpressionKeys.SELECT_ALL_CHAR) || head.equals(Keys.ExpressionKeys.SELECT_ALL_CHAR_SCALA))
{
+		if (head.equals(Keys.ExpressionKeys.SELECT_ALL_CHAR) || head.equals(Keys.ExpressionKeys.SELECT_ALL_CHAR_SCALA))
{
 			throw new CompositeType.InvalidFieldReferenceException("No wildcards are allowed here.");
 		} else {
 			head = matcher.group(1);

http://git-wip-us.apache.org/repos/asf/flink/blob/76a7783f/tools/maven/strict-checkstyle.xml
----------------------------------------------------------------------
diff --git a/tools/maven/strict-checkstyle.xml b/tools/maven/strict-checkstyle.xml
index 48cb511..e89311d 100644
--- a/tools/maven/strict-checkstyle.xml
+++ b/tools/maven/strict-checkstyle.xml
@@ -478,20 +478,20 @@ This file is based on the checkstyle file of Apache Beam.
 
     -->
 
-    <!--<module name="WhitespaceAround">-->
-      <!--&lt;!&ndash; Checks that various tokens are surrounded by whitespace.-->
-           <!--This includes most binary operators and keywords followed-->
-           <!--by regular or curly braces.-->
-      <!--&ndash;&gt;-->
-      <!--<property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR,-->
-        <!--BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN,-->
-        <!--EQUAL, GE, GT, LAND, LE, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE,-->
-        <!--LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN,-->
-        <!--LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS,-->
-        <!--MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION,-->
-        <!--SL, SL_ASSIGN, SR_ASSIGN, STAR, STAR_ASSIGN"/>-->
-      <!--<property name="severity" value="error"/>-->
-    <!--</module>-->
+    <module name="WhitespaceAround">
+      <!-- Checks that various tokens are surrounded by whitespace.
+           This includes most binary operators and keywords followed
+           by regular or curly braces.
+      -->
+      <property name="tokens" value="ASSIGN, BAND, BAND_ASSIGN, BOR,
+        BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN,
+        EQUAL, GE, GT, LAND, LE, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE,
+        LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN,
+        LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS,
+        MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION,
+        SL, SL_ASSIGN, SR_ASSIGN, STAR, STAR_ASSIGN"/>
+      <property name="severity" value="error"/>
+    </module>
 
     <module name="WhitespaceAfter">
       <!-- Checks that commas, semicolons and typecasts are followed by


Mime
View raw message