Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 93D2D200BE3 for ; Wed, 7 Dec 2016 17:14:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 927AC160AF9; Wed, 7 Dec 2016 16:14:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id DD5BD160B0C for ; Wed, 7 Dec 2016 17:14:09 +0100 (CET) Received: (qmail 10670 invoked by uid 500); 7 Dec 2016 16:14:09 -0000 Mailing-List: contact commits-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list commits@flink.apache.org Received: (qmail 10661 invoked by uid 99); 7 Dec 2016 16:14:09 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Dec 2016 16:14:09 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id DA513E7DFC; Wed, 7 Dec 2016 16:14:08 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: uce@apache.org To: commits@flink.apache.org Date: Wed, 07 Dec 2016 16:14:09 -0000 Message-Id: <24a5798617c34a449ada55744b9f0d48@git.apache.org> In-Reply-To: <171fd00ec8104ebd8b05df6ba61272e6@git.apache.org> References: <171fd00ec8104ebd8b05df6ba61272e6@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: [2/2] flink git commit: [FLINK-5275] [execgraph] Give more detailed error message if InputChannel deployment fails archived-at: Wed, 07 Dec 2016 16:14:10 -0000 [FLINK-5275] [execgraph] Give more detailed error message if InputChannel deployment fails Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/4410c04a Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/4410c04a Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/4410c04a Branch: refs/heads/master Commit: 4410c04a68c7b247bb3d7113e5f40f2a9c2165af Parents: 555a687 Author: Ufuk Celebi Authored: Wed Dec 7 13:48:25 2016 +0100 Committer: Ufuk Celebi Committed: Wed Dec 7 17:14:00 2016 +0100 ---------------------------------------------------------------------- .../InputChannelDeploymentDescriptor.java | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/4410c04a/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java b/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java index 9b3ce5f..9bf3bd5 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/deployment/InputChannelDeploymentDescriptor.java @@ -131,8 +131,21 @@ public class InputChannelDeploymentDescriptor implements Serializable { else if (allowLazyDeployment) { // The producing task might not have registered the partition yet partitionLocation = ResultPartitionLocation.createUnknown(); - } else { - throw new ExecutionGraphException("Trying to eagerly schedule a task whose inputs are not ready."); + } + else if (producerState == ExecutionState.CANCELING + || producerState == ExecutionState.CANCELED + || producerState == ExecutionState.FAILED) { + String msg = "Trying to schedule a task whose inputs were canceled or failed. " + + "The producer is in state " + producerState + "."; + throw new ExecutionGraphException(msg); + } + else { + String msg = String.format("Trying to eagerly schedule a task whose inputs " + + "are not ready (partition consumable? %s, producer state: %s, producer slot: %s).", + consumedPartition.isConsumable(), + producerState, + producerSlot); + throw new ExecutionGraphException(msg); } final ResultPartitionID consumedPartitionId = new ResultPartitionID(