flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From trohrm...@apache.org
Subject [1/6] flink git commit: [FLINK-5171] [runtime] fix wrong use of Preconditions.checkState in TaskManagerRunner
Date Mon, 28 Nov 2016 16:22:13 GMT
Repository: flink
Updated Branches:
  refs/heads/flip-6 8f45e314a -> 4afcc4abd


[FLINK-5171] [runtime] fix wrong use of Preconditions.checkState in TaskManagerRunner

This closes #2880.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/09ec78a5
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/09ec78a5
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/09ec78a5

Branch: refs/heads/flip-6
Commit: 09ec78a5bd5db1b74c267c8a69e182543135a161
Parents: 8f45e31
Author: shuai.xus <shuai.xus@alibaba-inc.com>
Authored: Mon Nov 28 17:21:26 2016 +0800
Committer: Till Rohrmann <trohrmann@apache.org>
Committed: Mon Nov 28 17:11:28 2016 +0100

----------------------------------------------------------------------
 .../org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/09ec78a5/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
index 99a7c5d..a18ff40 100644
--- a/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
+++ b/flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskManagerRunner.java
@@ -185,7 +185,7 @@ public class TaskManagerRunner implements FatalErrorHandler {
 
 		final int rpcPort = configuration.getInteger(ConfigConstants.TASK_MANAGER_IPC_PORT_KEY,
0);
 
-		Preconditions.checkState(rpcPort < 0 || rpcPort >65535, "Invalid value for " +
+		Preconditions.checkState(rpcPort >= 0 && rpcPort <= 65535, "Invalid value
for " +
 				"'%s' (port for the TaskManager actor system) : %d - Leave config parameter empty or
" +
 				"use 0 to let the system choose port automatically.",
 			ConfigConstants.TASK_MANAGER_IPC_PORT_KEY, rpcPort);


Mime
View raw message