Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7434F200B85 for ; Thu, 15 Sep 2016 19:18:40 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 72AEB160ABA; Thu, 15 Sep 2016 17:18:40 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 92DB7160ADA for ; Thu, 15 Sep 2016 19:18:39 +0200 (CEST) Received: (qmail 95359 invoked by uid 500); 15 Sep 2016 17:18:38 -0000 Mailing-List: contact commits-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list commits@flink.apache.org Received: (qmail 95247 invoked by uid 99); 15 Sep 2016 17:18:38 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 15 Sep 2016 17:18:38 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 880DEE09C6; Thu, 15 Sep 2016 17:18:38 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: chesnay@apache.org To: commits@flink.apache.org Date: Thu, 15 Sep 2016 17:18:41 -0000 Message-Id: <7c4bb6815b4d466a9bd872cc947dde44@git.apache.org> In-Reply-To: References: X-Mailer: ASF-Git Admin Mailer Subject: [4/4] flink git commit: [hotfix] [metrics] Add missing @Internal annotations archived-at: Thu, 15 Sep 2016 17:18:40 -0000 [hotfix] [metrics] Add missing @Internal annotations Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/0492dcc8 Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/0492dcc8 Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/0492dcc8 Branch: refs/heads/master Commit: 0492dcc8e2d7fb21ee817f5cf5cc39a8b091ba9c Parents: 70704de Author: zentol Authored: Fri Aug 19 11:46:14 2016 +0200 Committer: zentol Committed: Thu Sep 15 19:17:53 2016 +0200 ---------------------------------------------------------------------- .../apache/flink/runtime/metrics/groups/AbstractMetricGroup.java | 2 ++ .../apache/flink/runtime/metrics/groups/ComponentMetricGroup.java | 2 ++ .../apache/flink/runtime/metrics/groups/GenericMetricGroup.java | 2 ++ .../flink/runtime/metrics/groups/JobManagerJobMetricGroup.java | 2 ++ .../apache/flink/runtime/metrics/groups/OperatorMetricGroup.java | 2 ++ .../flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java | 2 ++ .../flink/runtime/metrics/groups/TaskManagerMetricGroup.java | 2 ++ .../org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java | 2 ++ 8 files changed, 16 insertions(+) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java index 75476a6..d9338ec 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/AbstractMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.metrics.CharacterFilter; import org.apache.flink.metrics.Counter; import org.apache.flink.metrics.Gauge; @@ -57,6 +58,7 @@ import static org.apache.flink.util.Preconditions.checkNotNull; * * @param The type of the parent MetricGroup */ +@Internal public abstract class AbstractMetricGroup> implements MetricGroup { /** shared logger */ http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java index 9a93fbd..9f0f483 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/ComponentMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.runtime.metrics.MetricRegistry; import java.util.HashMap; @@ -38,6 +39,7 @@ import java.util.Map; * * @param

The type of the parent MetricGroup. */ +@Internal public abstract class ComponentMetricGroup

> extends AbstractMetricGroup

{ /** http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/GenericMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/GenericMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/GenericMetricGroup.java index ab6418d..54fbed4 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/GenericMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/GenericMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.metrics.CharacterFilter; import org.apache.flink.runtime.metrics.MetricRegistry; import org.apache.flink.runtime.metrics.dump.QueryScopeInfo; @@ -26,6 +27,7 @@ import org.apache.flink.runtime.metrics.dump.QueryScopeInfo; * A simple named {@link org.apache.flink.metrics.MetricGroup} that is used to hold * subgroups of metrics. */ +@Internal public class GenericMetricGroup extends AbstractMetricGroup> { /** The name of this group */ private String name; http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerJobMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerJobMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerJobMetricGroup.java index 9d384d8..c4902e8 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerJobMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/JobManagerJobMetricGroup.java @@ -17,6 +17,7 @@ */ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.api.common.JobID; import org.apache.flink.runtime.metrics.MetricRegistry; @@ -29,6 +30,7 @@ import static org.apache.flink.util.Preconditions.checkNotNull; * Special {@link org.apache.flink.metrics.MetricGroup} representing everything belonging to * a specific job, running on the JobManager. */ +@Internal public class JobManagerJobMetricGroup extends JobMetricGroup { public JobManagerJobMetricGroup( MetricRegistry registry, http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/OperatorMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/OperatorMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/OperatorMetricGroup.java index 1ed55d0..f1354b5 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/OperatorMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/OperatorMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.metrics.CharacterFilter; import org.apache.flink.runtime.metrics.MetricRegistry; import org.apache.flink.runtime.metrics.dump.QueryScopeInfo; @@ -31,6 +32,7 @@ import static org.apache.flink.util.Preconditions.checkNotNull; /** * Special {@link org.apache.flink.metrics.MetricGroup} representing an Operator. */ +@Internal public class OperatorMetricGroup extends ComponentMetricGroup { private final String operatorName; http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java index 1f852c7..3961c14 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerJobMetricGroup.java @@ -17,6 +17,7 @@ */ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.api.common.JobID; import org.apache.flink.runtime.deployment.TaskDeploymentDescriptor; import org.apache.flink.runtime.metrics.MetricRegistry; @@ -34,6 +35,7 @@ import static org.apache.flink.util.Preconditions.checkNotNull; * *

Contains extra logic for adding Tasks ({@link TaskMetricGroup}). */ +@Internal public class TaskManagerJobMetricGroup extends JobMetricGroup { /** Map from execution attempt ID (task identifier) to task metrics */ http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java index 5bdd014..a8fa828 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskManagerMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.api.common.JobID; import org.apache.flink.metrics.CharacterFilter; import org.apache.flink.runtime.deployment.TaskDeploymentDescriptor; @@ -34,6 +35,7 @@ import java.util.Map; *

Contains extra logic for adding jobs with tasks, and removing jobs when they do * not contain tasks any more */ +@Internal public class TaskManagerMetricGroup extends ComponentMetricGroup { private final Map jobs = new HashMap<>(); http://git-wip-us.apache.org/repos/asf/flink/blob/0492dcc8/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java index 0e76ab0..5082fd8 100644 --- a/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java +++ b/flink-runtime/src/main/java/org/apache/flink/runtime/metrics/groups/TaskMetricGroup.java @@ -18,6 +18,7 @@ package org.apache.flink.runtime.metrics.groups; +import org.apache.flink.annotation.Internal; import org.apache.flink.metrics.CharacterFilter; import org.apache.flink.runtime.metrics.MetricRegistry; import org.apache.flink.runtime.metrics.dump.QueryScopeInfo; @@ -35,6 +36,7 @@ import static org.apache.flink.util.Preconditions.checkNotNull; * *

Contains extra logic for adding operators. */ +@Internal public class TaskMetricGroup extends ComponentMetricGroup { private final Map operators = new HashMap<>();