flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From se...@apache.org
Subject [2/2] flink git commit: [hotfix] [tests] Fix minor test instability in ConnectionUtilsTest
Date Tue, 02 Aug 2016 16:21:27 GMT
[hotfix] [tests] Fix minor test instability in ConnectionUtilsTest


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/36c09b09
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/36c09b09
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/36c09b09

Branch: refs/heads/master
Commit: 36c09b0996404eac47abfc3ef8387a5f353f9756
Parents: 8775189
Author: Stephan Ewen <sewen@apache.org>
Authored: Tue Aug 2 15:58:58 2016 +0200
Committer: Stephan Ewen <sewen@apache.org>
Committed: Tue Aug 2 18:21:01 2016 +0200

----------------------------------------------------------------------
 .../java/org/apache/flink/runtime/net/ConnectionUtilsTest.java   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/36c09b09/flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
index 7d615bd..570f87c 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/net/ConnectionUtilsTest.java
@@ -19,7 +19,6 @@ package org.apache.flink.runtime.net;
 
 import static org.junit.Assert.*;
 
-import org.apache.flink.util.OperatingSystem;
 import org.junit.Test;
 
 import java.net.InetAddress;
@@ -42,7 +41,8 @@ public class ConnectionUtilsTest {
 			InetAddress add = ConnectionUtils.findConnectingAddress(unreachable, 2000, 400);
 
 			// check that it did not take forever
-			assertTrue(System.currentTimeMillis() - start < (OperatingSystem.isWindows() ? 30000
: 8000));
+			// this check can unfortunately not be too tight, or it will be flaky on some CI infrastructure
+			assertTrue(System.currentTimeMillis() - start < 30000);
 
 			// we should have found a heuristic address
 			assertNotNull(add);


Mime
View raw message