flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From se...@apache.org
Subject flink git commit: [FLINK-3430] Remove "no POJO" warning in TypeAnalyzer
Date Wed, 17 Feb 2016 14:42:49 GMT
Repository: flink
Updated Branches:
  refs/heads/master a4e8fcbe9 -> cee135a85


[FLINK-3430] Remove "no POJO" warning in TypeAnalyzer

This closes #1655


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/cee135a8
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/cee135a8
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/cee135a8

Branch: refs/heads/master
Commit: cee135a85a63b6baee62aef1e87bc63a4bc414e3
Parents: a4e8fcb
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Authored: Wed Feb 17 12:12:23 2016 +0100
Committer: Stephan Ewen <sewen@apache.org>
Committed: Wed Feb 17 15:18:21 2016 +0100

----------------------------------------------------------------------
 .../org/apache/flink/api/scala/codegen/TypeAnalyzer.scala    | 8 --------
 1 file changed, 8 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/cee135a8/flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeAnalyzer.scala
----------------------------------------------------------------------
diff --git a/flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeAnalyzer.scala
b/flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeAnalyzer.scala
index 080e26d..a8587ef 100644
--- a/flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeAnalyzer.scala
+++ b/flink-scala/src/main/scala/org/apache/flink/api/scala/codegen/TypeAnalyzer.scala
@@ -153,9 +153,6 @@ private[flink] trait TypeAnalyzer[C <: Context] { this: MacroContextHolder[C]
       val immutableFields = tpe.members filter { _.isTerm } map { _.asTerm } filter { _.isVal
}
       if (immutableFields.nonEmpty) {
         // We don't support POJOs with immutable fields
-        c.warning(
-          c.enclosingPosition,
-          s"Type $tpe is no POJO, has immutable fields: ${immutableFields.mkString(", ")}.")
         return GenericClassDescriptor(id, tpe)
       }
 
@@ -180,8 +177,6 @@ private[flink] trait TypeAnalyzer[C <: Context] { this: MacroContextHolder[C]
       }
 
       if (invalidFields.nonEmpty) {
-        c.warning(c.enclosingPosition, s"Type $tpe is no POJO because it has non-public fields
'" +
-          s"${invalidFields.mkString(", ")}' that don't have public getters/setters.")
         return GenericClassDescriptor(id, tpe)
       }
 
@@ -194,9 +189,6 @@ private[flink] trait TypeAnalyzer[C <: Context] { this: MacroContextHolder[C]
 
       if (!hasZeroCtor) {
         // We don't support POJOs without zero-paramter ctor
-        c.warning(
-          c.enclosingPosition,
-          s"Class $tpe is no POJO, has no zero-parameters constructor.")
         return GenericClassDescriptor(id, tpe)
       }
 


Mime
View raw message