flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From se...@apache.org
Subject [11/11] flink git commit: [hotfix] [streaming] Processing timer errors are not logged unless the task is actually running.
Date Thu, 28 Jan 2016 13:57:02 GMT
[hotfix] [streaming] Processing timer errors are not logged unless the task is actually running.

This keeps the log cleaner in case of failed timers while canceling tasks.


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/2e233073
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/2e233073
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/2e233073

Branch: refs/heads/master
Commit: 2e23307372147287c8b49d2985d9564b2ed54eaa
Parents: 9637ee7
Author: Stephan Ewen <sewen@apache.org>
Authored: Thu Jan 28 13:37:09 2016 +0100
Committer: Stephan Ewen <sewen@apache.org>
Committed: Thu Jan 28 13:41:38 2016 +0100

----------------------------------------------------------------------
 .../org/apache/flink/streaming/runtime/tasks/StreamTask.java     | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/2e233073/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
----------------------------------------------------------------------
diff --git a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
index 91f11fa..b91c570 100644
--- a/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
+++ b/flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/StreamTask.java
@@ -688,7 +688,9 @@ public abstract class StreamTask<OUT, Operator extends StreamOperator<OUT>>
 				try {
 					target.trigger(timestamp);
 				} catch (Throwable t) {
-					LOG.error("Caught exception while processing timer.", t);
+					if (task.isRunning) {
+						LOG.error("Caught exception while processing timer.", t);
+					}
 					if (task.asyncException == null) {
 						task.asyncException = new TimerException(t);
 					}


Mime
View raw message