Return-Path: X-Original-To: apmail-flink-commits-archive@minotaur.apache.org Delivered-To: apmail-flink-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 58F2318B6C for ; Thu, 23 Jul 2015 14:47:23 +0000 (UTC) Received: (qmail 52674 invoked by uid 500); 23 Jul 2015 14:47:10 -0000 Delivered-To: apmail-flink-commits-archive@flink.apache.org Received: (qmail 52635 invoked by uid 500); 23 Jul 2015 14:47:10 -0000 Mailing-List: contact commits-help@flink.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flink.apache.org Delivered-To: mailing list commits@flink.apache.org Received: (qmail 52626 invoked by uid 99); 23 Jul 2015 14:47:10 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Jul 2015 14:47:10 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 6E44EE6812; Thu, 23 Jul 2015 14:47:10 +0000 (UTC) Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit From: uce@apache.org To: commits@flink.apache.org Message-Id: <432071a59d9f44cf969b10bbe9ac7539@git.apache.org> X-Mailer: ASF-Git Admin Mailer Subject: flink git commit: [FLINK-2400] [tests] Improve error message on unexpected TaskTest message Date: Thu, 23 Jul 2015 14:47:10 +0000 (UTC) Repository: flink Updated Branches: refs/heads/master c52e753a8 -> fa78be6df [FLINK-2400] [tests] Improve error message on unexpected TaskTest message Project: http://git-wip-us.apache.org/repos/asf/flink/repo Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/fa78be6d Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/fa78be6d Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/fa78be6d Branch: refs/heads/master Commit: fa78be6df45213406cb9b8a6299ca1f4bc085191 Parents: c52e753 Author: Ufuk Celebi Authored: Thu Jul 23 16:45:58 2015 +0200 Committer: Ufuk Celebi Committed: Thu Jul 23 16:46:52 2015 +0200 ---------------------------------------------------------------------- .../java/org/apache/flink/runtime/taskmanager/TaskTest.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/flink/blob/fa78be6d/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java ---------------------------------------------------------------------- diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java index bd36dd4..4631996 100644 --- a/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java +++ b/flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java @@ -772,7 +772,9 @@ public class TaskTest { Object rawMessage = taskManagerMessages.poll(10, TimeUnit.SECONDS); assertNotNull("There is no additional TaskManager message", rawMessage); - assertTrue("TaskManager message is not 'UnregisterTask'", rawMessage instanceof TaskMessages.TaskInFinalState); + if (!(rawMessage instanceof TaskMessages.TaskInFinalState)) { + fail("TaskManager message is not 'UnregisterTask', but " + rawMessage.getClass()); + } TaskMessages.TaskInFinalState message = (TaskMessages.TaskInFinalState) rawMessage; assertEquals(id, message.executionID()); @@ -789,8 +791,9 @@ public class TaskTest { Object rawMessage = taskManagerMessages.poll(10, TimeUnit.SECONDS); assertNotNull("There is no additional TaskManager message", rawMessage); - assertTrue("TaskManager message is not 'UpdateTaskExecutionState'", - rawMessage instanceof TaskMessages.UpdateTaskExecutionState); + if (!(rawMessage instanceof TaskMessages.UpdateTaskExecutionState)) { + fail("TaskManager message is not 'UpdateTaskExecutionState', but " + rawMessage.getClass()); + } TaskMessages.UpdateTaskExecutionState message = (TaskMessages.UpdateTaskExecutionState) rawMessage;