flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From aljos...@apache.org
Subject flink git commit: [hotfix][table] Fix not-equals code generation
Date Fri, 22 May 2015 14:19:05 GMT
Repository: flink
Updated Branches:
  refs/heads/master 36c2026fb -> 24c4f8323


[hotfix][table] Fix not-equals code generation

This was using != before, now uses !(a.equals(b))


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/24c4f832
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/24c4f832
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/24c4f832

Branch: refs/heads/master
Commit: 24c4f832307f2871c04f639117a323abd9662ceb
Parents: 36c2026
Author: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Authored: Fri May 22 14:13:54 2015 +0200
Committer: Aljoscha Krettek <aljoscha.krettek@gmail.com>
Committed: Fri May 22 16:18:46 2015 +0200

----------------------------------------------------------------------
 .../apache/flink/api/table/codegen/ExpressionCodeGenerator.scala   | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/24c4f832/flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
----------------------------------------------------------------------
diff --git a/flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
b/flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
index 8cb678a..49f7600 100644
--- a/flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
+++ b/flink-staging/flink-table/src/main/scala/org/apache/flink/api/table/codegen/ExpressionCodeGenerator.scala
@@ -322,7 +322,7 @@ abstract class ExpressionCodeGenerator[R](
 
       case NotEqualTo(left, right) =>
         generateIfNonNull(left, right, BOOLEAN_TYPE_INFO) {
-          (leftTerm, rightTerm) => s"$leftTerm != $rightTerm"
+          (leftTerm, rightTerm) => s"!($leftTerm.equals($rightTerm))"
         }
 
       case And(left, right) =>


Mime
View raw message