flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From u..@apache.org
Subject flink git commit: [tests] Remove timeout in PipelinedPartitionQueueTest
Date Wed, 25 Feb 2015 12:44:14 GMT
Repository: flink
Updated Branches:
  refs/heads/master d182d0426 -> c0c4c9f1a


[tests] Remove timeout in PipelinedPartitionQueueTest

The PipelinedPartitionQueueTest spuriously fails with a timeout. It is unclear
whether this is due to a deadlock or a test environment hickup. Since build
artifacts like stack traces for stalled builds are uploaded to S3, we can let
this test deadlock (if it is one) and then start debugging. ;-)


Project: http://git-wip-us.apache.org/repos/asf/flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/flink/commit/c0c4c9f1
Tree: http://git-wip-us.apache.org/repos/asf/flink/tree/c0c4c9f1
Diff: http://git-wip-us.apache.org/repos/asf/flink/diff/c0c4c9f1

Branch: refs/heads/master
Commit: c0c4c9f1a065cb9e7f7c2c2ee399c8f8ae0d2c19
Parents: d182d04
Author: Ufuk Celebi <uce@apache.org>
Authored: Wed Feb 25 13:40:57 2015 +0100
Committer: Ufuk Celebi <uce@apache.org>
Committed: Wed Feb 25 13:43:58 2015 +0100

----------------------------------------------------------------------
 .../network/partition/queue/PipelinedPartitionQueueTest.java  | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/flink/blob/c0c4c9f1/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/queue/PipelinedPartitionQueueTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/queue/PipelinedPartitionQueueTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/queue/PipelinedPartitionQueueTest.java
index 118b00b..4c70378 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/queue/PipelinedPartitionQueueTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/queue/PipelinedPartitionQueueTest.java
@@ -23,10 +23,10 @@ import org.apache.flink.runtime.io.network.buffer.Buffer;
 import org.apache.flink.runtime.io.network.buffer.BufferPool;
 import org.apache.flink.runtime.io.network.buffer.BufferProvider;
 import org.apache.flink.runtime.io.network.buffer.NetworkBufferPool;
+import org.apache.flink.runtime.io.network.partition.queue.IntermediateResultPartitionQueueIterator.AlreadySubscribedException;
 import org.apache.flink.runtime.io.network.util.MockConsumer;
 import org.apache.flink.runtime.io.network.util.MockNotificationListener;
 import org.apache.flink.runtime.io.network.util.MockProducer;
-import org.apache.flink.runtime.io.network.partition.queue.IntermediateResultPartitionQueueIterator.AlreadySubscribedException;
 import org.apache.flink.runtime.util.event.NotificationListener;
 import org.junit.Before;
 import org.junit.Test;
@@ -36,7 +36,6 @@ import java.util.Random;
 import java.util.concurrent.ExecutorService;
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
-import java.util.concurrent.TimeUnit;
 
 import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertFalse;
@@ -195,8 +194,8 @@ public class PipelinedPartitionQueueTest {
 
 			boolean success = false;
 			try {
-				success = producerSuccess.get(30, TimeUnit.SECONDS);
-				success &= consumerSuccess.get(30, TimeUnit.SECONDS);
+				success = producerSuccess.get();
+				success &= consumerSuccess.get();
 			}
 			catch (Throwable t) {
 				t.printStackTrace();


Mime
View raw message