flink-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From se...@apache.org
Subject [3/3] git commit: [FLINK-514] Fix additional javadoc problems and add suppressions for certain compiler warnings.
Date Wed, 01 Oct 2014 13:42:14 GMT
[FLINK-514] Fix additional javadoc problems and add suppressions for certain compiler warnings.


Project: http://git-wip-us.apache.org/repos/asf/incubator-flink/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-flink/commit/39ac5ab0
Tree: http://git-wip-us.apache.org/repos/asf/incubator-flink/tree/39ac5ab0
Diff: http://git-wip-us.apache.org/repos/asf/incubator-flink/diff/39ac5ab0

Branch: refs/heads/master
Commit: 39ac5ab0562d1c40ed051395a9ac056c7a1ee54a
Parents: c8054a3
Author: Stephan Ewen <sewen@apache.org>
Authored: Wed Oct 1 13:27:25 2014 +0200
Committer: Stephan Ewen <sewen@apache.org>
Committed: Wed Oct 1 14:30:14 2014 +0200

----------------------------------------------------------------------
 .../org/apache/flink/client/web/GUIServletStub.java     |  1 -
 .../flink/api/common/typeutils/TypeComparator.java      |  2 +-
 .../api/common/typeutils/base/BasicTypeComparator.java  |  3 +++
 .../main/java/org/apache/flink/api/java/DataSet.java    |  3 ++-
 .../apache/flink/api/java/operators/CrossOperator.java  | 12 ++++++++----
 .../api/java/record/io/ExternalProcessInputSplit.java   |  2 ++
 .../apache/flink/api/java/typeutils/TypeExtractor.java  |  1 +
 .../operators/testutils/types/IntListComparator.java    |  1 +
 .../operators/testutils/types/IntPairComparator.java    |  3 +--
 .../operators/testutils/types/StringPairComparator.java |  1 +
 .../flink/runtime/operators/util/OutputEmitterTest.java |  2 +-
 11 files changed, 21 insertions(+), 10 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-clients/src/main/java/org/apache/flink/client/web/GUIServletStub.java
----------------------------------------------------------------------
diff --git a/flink-clients/src/main/java/org/apache/flink/client/web/GUIServletStub.java b/flink-clients/src/main/java/org/apache/flink/client/web/GUIServletStub.java
index 1e3785b..83f8c39 100644
--- a/flink-clients/src/main/java/org/apache/flink/client/web/GUIServletStub.java
+++ b/flink-clients/src/main/java/org/apache/flink/client/web/GUIServletStub.java
@@ -143,7 +143,6 @@ public abstract class GUIServletStub extends HttpServlet {
 				+ "</div></h1>");
 		writer.println("  </div>");
 
-		@SuppressWarnings("unchecked")
 		Map<String, String[]> m = (Map<String, String[]>) req.getParameterMap();
 
 		// let the content be printed by the child class

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeComparator.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeComparator.java
b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeComparator.java
index f935656..27487ed 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeComparator.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/TypeComparator.java
@@ -16,7 +16,6 @@
  * limitations under the License.
  */
 
-
 package org.apache.flink.api.common.typeutils;
 
 import java.io.IOException;
@@ -297,6 +296,7 @@ public abstract class TypeComparator<T> implements Serializable
{
 	 * Get the field comparators. This is used together with {@link #extractKeys(Object)} to
provide
 	 * interoperability between different record types.
 	 */
+	@SuppressWarnings("rawtypes")
 	public abstract TypeComparator[] getComparators();
 
 	// --------------------------------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
----------------------------------------------------------------------
diff --git a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
index 5f61081..4e44326 100644
--- a/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
+++ b/flink-core/src/main/java/org/apache/flink/api/common/typeutils/base/BasicTypeComparator.java
@@ -34,9 +34,11 @@ public abstract class BasicTypeComparator<T extends Comparable<T>>
extends TypeC
 	protected final boolean ascendingComparison;
 
 	// This is used in extractKeys, so that we don't create a new array for every call.
+	@SuppressWarnings("rawtypes")
 	private final Comparable[] extractedKey = new Comparable[1];
 
 	// For use by getComparators
+	@SuppressWarnings("rawtypes")
 	private final TypeComparator[] comparators = new TypeComparator[] {this};
 	
 
@@ -93,6 +95,7 @@ public abstract class BasicTypeComparator<T extends Comparable<T>>
extends TypeC
 	}
 
 	@Override
+	@SuppressWarnings("rawtypes")
 	public TypeComparator[] getComparators() {
 		return comparators;
 	}

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
----------------------------------------------------------------------
diff --git a/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java b/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
index c582c74..d2939d8 100644
--- a/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
+++ b/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java
@@ -653,7 +653,8 @@ public abstract class DataSet<T> {
 	 * second input being the second field of the tuple.
 	 * 
 	 * <p>
-	 * Call {@link org.apache.flink.api.java.operators.CrossOperator.DefaultCross#with(org.apache.flink.api.common.functions.CrossFunction)}
to define a {@link CrossFunction} which is called for
+	 * Call {@link org.apache.flink.api.java.operators.CrossOperator.DefaultCross#with(org.apache.flink.api.common.functions.CrossFunction)}
to define a
+	 * {@link org.apache.flink.api.common.functions.CrossFunction} which is called for
 	 * each pair of crossed elements. The CrossFunction returns a exactly one element for each
pair of input elements.</br>
 	 * 
 	 * @param other The other DataSet with which this DataSet is crossed. 

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
----------------------------------------------------------------------
diff --git a/flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
b/flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
index fb882c1..d0b5054 100644
--- a/flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
+++ b/flink-java/src/main/java/org/apache/flink/api/java/operators/CrossOperator.java
@@ -152,7 +152,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1,
I2, OUT,
 		 * 					   The order of fields in the output tuple is defined by to the order of field
indexes.
 		 * @return A CrossProjection that needs to be converted into a 
 		 *           {@link org.apache.flink.api.java.operators.CrossOperator.ProjectCross} to
complete the
-		 *           Cross transformation by calling {@link CrossProjection#types(Class)}.
+		 *           Cross transformation by calling
+		 *           {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
 		 *
 		 * @see Tuple
 		 * @see DataSet
@@ -177,7 +178,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1,
I2, OUT,
 		 * 					   The order of fields in the output tuple is defined by to the order of field
indexes.
 		 * @return A CrossProjection that needs to be converted into a
 		 *           {@link org.apache.flink.api.java.operators.CrossOperator.ProjectCross} to
complete the
-		 *           Cross transformation by calling {@link CrossProjection#types(Class)}.
+		 *           Cross transformation by calling
+		 *           {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
 		 *
 		 * @see Tuple
 		 * @see DataSet
@@ -379,7 +381,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1,
I2, OUT,
 		 * 					   For a non-Tuple DataSet, do not provide parameters.
 		 * 					   The order of fields in the output tuple is defined by to the order of field
indexes.
 		 * @return A CrossProjection that needs to be converted into a {@link ProjectOperator}
to complete the
-		 *           ProjectCross transformation by calling {@link CrossProjection#types(Class)}.
+		 *           Cross transformation by calling
+		 *           {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
 		 *
 		 * @see Tuple
 		 * @see DataSet
@@ -447,7 +450,8 @@ public class CrossOperator<I1, I2, OUT> extends TwoInputUdfOperator<I1,
I2, OUT,
 		 * 					   For a non-Tuple DataSet, do not provide parameters.
 		 * 					   The order of fields in the output tuple is defined by to the order of field
indexes.
 		 * @return A CrossProjection that needs to be converted into a {@link ProjectOperator}
to complete the
-		 *           ProjectCross transformation by calling {@link CrossProjection#types(Class)}.
+		 *           Cross transformation by calling
+		 *           {@link org.apache.flink.api.java.operators.CrossOperator.CrossProjection#types(Class)}.
 		 *
 		 * @see Tuple
 		 * @see DataSet

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-java/src/main/java/org/apache/flink/api/java/record/io/ExternalProcessInputSplit.java
----------------------------------------------------------------------
diff --git a/flink-java/src/main/java/org/apache/flink/api/java/record/io/ExternalProcessInputSplit.java
b/flink-java/src/main/java/org/apache/flink/api/java/record/io/ExternalProcessInputSplit.java
index 84a660b..7b5ac96 100644
--- a/flink-java/src/main/java/org/apache/flink/api/java/record/io/ExternalProcessInputSplit.java
+++ b/flink-java/src/main/java/org/apache/flink/api/java/record/io/ExternalProcessInputSplit.java
@@ -36,6 +36,8 @@ import org.apache.flink.core.memory.DataOutputView;
  */
 public class ExternalProcessInputSplit extends GenericInputSplit {
 
+	private static final long serialVersionUID = 1L;
+	
 	// command to be executed for this input split
 	private String extProcessCommand;
 	

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
----------------------------------------------------------------------
diff --git a/flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
b/flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
index d30d152..d8e1aed 100644
--- a/flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
+++ b/flink-java/src/main/java/org/apache/flink/api/java/typeutils/TypeExtractor.java
@@ -873,6 +873,7 @@ public class TypeExtractor {
 		return new GenericTypeInfo<X>(clazz);
 	}
 
+	@SuppressWarnings("unused")
 	private <X> TypeInformation<X> analyzePojo(Class<X> clazz) {
 		List<Field> fields = getAllDeclaredFields(clazz);
 		List<PojoField> pojoFields = new ArrayList<PojoField>();

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntListComparator.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntListComparator.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntListComparator.java
index 1a886a1..49d31a2 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntListComparator.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntListComparator.java
@@ -26,6 +26,7 @@ import org.apache.flink.core.memory.DataInputView;
 import org.apache.flink.core.memory.DataOutputView;
 import org.apache.flink.core.memory.MemorySegment;
 
+@SuppressWarnings("rawtypes")
 public class IntListComparator extends TypeComparator<IntList> {
 	
 	private static final long serialVersionUID = 1L;

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntPairComparator.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntPairComparator.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntPairComparator.java
index 6abb502..98c5b69 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntPairComparator.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/IntPairComparator.java
@@ -16,7 +16,6 @@
  * limitations under the License.
  */
 
-
 package org.apache.flink.runtime.operators.testutils.types;
 
 import java.io.IOException;
@@ -27,7 +26,7 @@ import org.apache.flink.core.memory.DataInputView;
 import org.apache.flink.core.memory.DataOutputView;
 import org.apache.flink.core.memory.MemorySegment;
 
-
+@SuppressWarnings("rawtypes")
 public class IntPairComparator extends TypeComparator<IntPair> {
 
 	private static final long serialVersionUID = 1L;

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/StringPairComparator.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/StringPairComparator.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/StringPairComparator.java
index 7b32874..a5355dd 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/StringPairComparator.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/testutils/types/StringPairComparator.java
@@ -27,6 +27,7 @@ import org.apache.flink.core.memory.DataOutputView;
 import org.apache.flink.core.memory.MemorySegment;
 import org.apache.flink.types.StringValue;
 
+@SuppressWarnings("rawtypes")
 public class StringPairComparator extends TypeComparator<StringPair> {
 	
 	private static final long serialVersionUID = 1L;

http://git-wip-us.apache.org/repos/asf/incubator-flink/blob/39ac5ab0/flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
----------------------------------------------------------------------
diff --git a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
index c39054f..765d121 100644
--- a/flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
+++ b/flink-runtime/src/test/java/org/apache/flink/runtime/operators/util/OutputEmitterTest.java
@@ -380,7 +380,7 @@ public class OutputEmitterTest extends TestCase {
 		Assert.fail("Expected a NullKeyFieldException.");
 	}
 	
-	@SuppressWarnings("serial")
+	@SuppressWarnings({"serial", "rawtypes"})
 	private static class TestIntComparator extends TypeComparator<Integer> {
 		private final Comparable[] extractedKey = new Comparable[1];
 


Mime
View raw message