Mailing-List: contact users-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: users@flex.apache.org
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\))
Subject: Re: FlexJS, JQuery and FDT
From: Harbs <harbs.lists@gmail.com>
In-Reply-To: 
 <DB5PR05MB128518C83C6F82CA460D9D17A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>
Date: Thu, 21 Apr 2016 12:48:29 +0300
Content-Transfer-Encoding: quoted-printable
Message-Id: <3BD7E6FC-99C4-457A-9A12-D25D9ED80B96@gmail.com>
References: <08481C36-740D-419D-9E85-EF7A1893C1F2@gmail.com>
 <D33D52E7.68222%aharui@adobe.com>
 <3B6419D2-E331-4898-8E99-24A07B6B423A@gmail.com>
 <D33D555F.68228%aharui@adobe.com>
 <B9737E44-B374-44D7-9491-E657A128C49D@gmail.com>
 <D33D69FE.68238%aharui@adobe.com>
 <4A80C78A-3E1D-41A0-A217-38845A0468C9@gmail.com>
 <CACK5iZeEpFZYi0ZgArmd2UPd4wxRsLFzwX+TvJRJgbdA=2h=tA@mail.gmail.com>
 <5D33EC56-8E59-4B78-8F18-B5F4D361C1B7@gmail.com>
 <D33DC70D.6825F%aharui@adobe.com>
 <394885FF-2FAF-4B89-A417-9C89A5D44FA5@gmail.com>
 <2A8FA2A7-FC67-4738-8424-A8F64ABBB38E@gmail.com>,<D33DC9BA.68269%aharui@adobe.com>
 <DB5PR05MB128518C83C6F82CA460D9D17A26E0@DB5PR05MB1285.eurprd05.prod.outlook.com>
To: users@flex.apache.org

OK. Can you recommend a workflow so these changes are properly captured?

On Apr 21, 2016, at 12:40 PM, Christofer Dutz =
<christofer.dutz@c-ware.de> wrote:

> Hi,
>=20
> just a request from my side, If you adjust any of the =
pre-/post-processing scripts or change javascript downloads, please =
inform me about that cause these are impossible to auto-merge and even =
harder to detect.
>=20
> Chris
>=20
> ________________________________________
> Von: Alex Harui <aharui@adobe.com>
> Gesendet: Donnerstag, 21. April 2016 09:07
> An: users@flex.apache.org
> Betreff: Re: FlexJS, JQuery and FDT
>=20
> We do these kinds of changes with Ant replace and replaceregex in the
> build.xml.  See the top-level build.xml and the externc.js.swc target.
>=20
> -Alex
>=20
> On 4/21/16, 12:04 AM, "Harbs" <harbs.lists@gmail.com> wrote:
>=20
>> Bah. .gitignore has this entry: externs/jquery/externs
>>=20
>> Is there any way to make this change and have it =93stick=94 in the =
repo?
>>=20
>> On Apr 21, 2016, at 10:00 AM, Harbs <harbs.lists@gmail.com> wrote:
>>=20
>>> OK. I=92ll make that change. I don=92t have time to test today, so =
I=92ll see
>>> what happens in the next nightly=85
>>>=20
>>> On Apr 21, 2016, at 9:55 AM, Alex Harui <aharui@adobe.com> wrote:
>>>=20
>>>> I think it should be:
>>>>=20
>>>> /**
>>>> * @const
>>>> * @type {jQuery}
>>>> */
>>>> var $ =3D jQuery;
>>>>=20
>>>> Look at other extern files for similar usage.
>>>>=20
>>>>=20
>>>> -Alex
>>>>=20
>>>>=20
>>>>=20
>>>> On 4/20/16, 11:36 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>=20
>>>>> Yes. I was looking in asjs instead of falcon=85
>>>>>=20
>>>>> I=92ve never done typdefs before. Does this look right?
>>>>>=20
>>>>> /**
>>>>> * @const
>>>>> * @typedef {jQuery}
>>>>> */
>>>>> var $ =3D jQuery;
>>>>>=20
>>>>> It=92s currently:
>>>>> /**
>>>>> * @const
>>>>> */
>>>>> var $ =3D jQuery;
>>>>>=20
>>>>> On Apr 21, 2016, at 9:25 AM, OmPrakash Muppirala
>>>>> <bigosmallm@gmail.com>
>>>>> wrote:
>>>>>=20
>>>>>> I think this is what you are looking for?
>>>>>> : flex-falcon\externs\jquery\externs\jquery-1.9.js
>>>>>>=20
>>>>>> Thanks,
>>>>>> Om
>>>>>>=20
>>>>>> On Wed, Apr 20, 2016 at 11:21 PM, Harbs <harbs.lists@gmail.com>
>>>>>> wrote:
>>>>>>=20
>>>>>>> I=92m looking for where the jQuery definitions are and I can=92t =
seem to
>>>>>>> find
>>>>>>> it.
>>>>>>>=20
>>>>>>> On Apr 21, 2016, at 3:17 AM, Alex Harui <aharui@adobe.com> =
wrote:
>>>>>>>=20
>>>>>>>> Looks like the externs file doesn't have an @type for the $
>>>>>>>> constant.
>>>>>>> You
>>>>>>>> can try adding it in the build script or see if Google will =
accept
>>>>>>>> a
>>>>>>> patch
>>>>>>>> for it.
>>>>>>>>=20
>>>>>>>> -Alex
>>>>>>>>=20
>>>>>>>> On 4/20/16, 4:13 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>=20
>>>>>>>>> Replacing =93$=94 with =93jQuery=94 makes the warnings go =
away. Why would
>>>>>>>>> =93$=94 be
>>>>>>>>> different than =93jQuery=94? It sounds to me like a bug in the
>>>>>>>>> definitions.
>>>>>>>>>=20
>>>>>>>>> jQuery always returns a JQuery object which has many defined
>>>>>>>>> methods.
>>>>>>> One
>>>>>>>>> of those is attr.
>>>>>>>>>=20
>>>>>>>>> On Apr 21, 2016, at 1:50 AM, Alex Harui <aharui@adobe.com> =
wrote:
>>>>>>>>>=20
>>>>>>>>>> IMO, this is why Jquery is painful for strong typing.
>>>>>>>>>>=20
>>>>>>>>>> I think you may need to do casting:
>>>>>>>>>>=20
>>>>>>>>>> ($("#topcoat") as Whatever).attr(..)
>>>>>>>>>>=20
>>>>>>>>>> Where Whatever is a "type" that has an attr function.
>>>>>>>>>>=20
>>>>>>>>>> And you may need to use @flexjsignorecoercion or other =
compiler
>>>>>>>>>> options
>>>>>>>>>> to
>>>>>>>>>> not actually do the "as" test in the JS output.
>>>>>>>>>>=20
>>>>>>>>>> Good luck,
>>>>>>>>>> -Alex
>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>> On 4/20/16, 3:46 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>>>=20
>>>>>>>>>>> Here=92s an example:
>>>>>>>>>>> $("#topcoat").attr("href",
>>>>>>>>>>> "css/topcoat-desktop-lightlight.min.css");
>>>>>>>>>>>=20
>>>>>>>>>>> It looks like =93$=94 is defined as an object.
>>>>>>>>>>>=20
>>>>>>>>>>> Here=92s the exact warnings I=92m getting:
>>>>>>>>>>>=20
>>>>>>>>>>> Could not resolve variable (may be a dynamic member) 'attr' =
at
>>>>>>>>>>> line 43
>>>>>>>>>>> column 19. ThemeManager.as /MyExtension/src/com/unhurdle
>>>>>>>>>>> Unknown
>>>>>>> Flash
>>>>>>>>>>> Problem
>>>>>>>>>>> Maybe invoking a non function. Found
>>>>>>>>>>>=20
>>>>>>>>>>>=20
>>>>>>>>>>> =
$("#topcoat").attr("href","css/topcoat-desktop-lightlight.min.css
>>>>>>>>>>> ");
>>>>>>> at
>>>>>>>>>>> line 43 column
>>>>>>>>>>> 5. ThemeManager.as /MyExtension/src/com/unhurdle   Unknown =
Flash
>>>>>>> Problem
>>>>>>>>>>>=20
>>>>>>>>>>> And yes, js/libs/jquery.swc is included. If I remove it, I =
get
>>>>>>>>>>> an
>>>>>>> error
>>>>>>>>>>> that =93$=94 is not defined instead of a warning.
>>>>>>>>>>>=20
>>>>>>>>>>> On Apr 21, 2016, at 1:39 AM, Alex Harui <aharui@adobe.com>
>>>>>>>>>>> wrote:
>>>>>>>>>>>=20
>>>>>>>>>>>>=20
>>>>>>>>>>>>=20
>>>>>>>>>>>> On 4/20/16, 3:34 PM, "Harbs" <harbs.lists@gmail.com> wrote:
>>>>>>>>>>>>=20
>>>>>>>>>>>>> Does anyone know if there=92s a way to get FDT to not flag
>>>>>>>>>>>>> JQuery
>>>>>>>>>>>>> expressions with =93could not resolve variable=94 and =
"Maybe
>>>>>>>>>>>>> invoke a
>>>>>>> non
>>>>>>>>>>>>> function=94 warnings?
>>>>>>>>>>>>=20
>>>>>>>>>>>> What kind of expressions result in this output?  Are you =
sure
>>>>>>>>>>>> you
>>>>>>> have
>>>>>>>>>>>> the
>>>>>>>>>>>> jquery.swc from the externs on the -external-library-path?
>>>>>>>>>>>>=20
>>>>>>>>>>>> -Alex
>>>>>>>>>>>>=20
>>>>>>>>>>>=20
>>>>>>>>>>=20
>>>>>>>>>=20
>>>>>>>>=20
>>>>>>>=20
>>>>>>>=20
>>>>>=20
>>>>=20
>>>=20
>>=20
>=20