Return-Path: X-Original-To: apmail-flex-users-archive@www.apache.org Delivered-To: apmail-flex-users-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 09C93182A8 for ; Fri, 18 Mar 2016 18:21:44 +0000 (UTC) Received: (qmail 93867 invoked by uid 500); 18 Mar 2016 18:21:43 -0000 Delivered-To: apmail-flex-users-archive@flex.apache.org Received: (qmail 93839 invoked by uid 500); 18 Mar 2016 18:21:43 -0000 Mailing-List: contact users-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: users@flex.apache.org Delivered-To: mailing list users@flex.apache.org Received: (qmail 93827 invoked by uid 99); 18 Mar 2016 18:21:43 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Mar 2016 18:21:43 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id D7845C00F0 for ; Fri, 18 Mar 2016 18:21:42 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: 1.179 X-Spam-Level: * X-Spam-Status: No, score=1.179 tagged_above=-999 required=6.31 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, HTML_MESSAGE=2, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001] autolearn=disabled Authentication-Results: spamd1-us-west.apache.org (amavisd-new); dkim=pass (2048-bit key) header.d=gmail.com Received: from mx2-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id gald8L_fAMNv for ; Fri, 18 Mar 2016 18:21:41 +0000 (UTC) Received: from mail-vk0-f46.google.com (mail-vk0-f46.google.com [209.85.213.46]) by mx2-lw-us.apache.org (ASF Mail Server at mx2-lw-us.apache.org) with ESMTPS id 93D785F241 for ; Fri, 18 Mar 2016 18:21:41 +0000 (UTC) Received: by mail-vk0-f46.google.com with SMTP id e6so151705724vkh.2 for ; Fri, 18 Mar 2016 11:21:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to; bh=030nDbIsBICcdWrYsPjEcv0NM6nJ2fqt+Ehi6LiilFo=; b=hWaQmoIBFZ9DubjujdmvUo2ckJRMCNzomlyF7anev0xx3V/c68YcCkpKtz8yLcWZL2 5BIFNyU6yI19r+4dPpspUL+oC07cc6VmYDYO+U1Px2WCEnh4gDV/NrdxV+rQ1Wgykzzx 119FRdk4xaXCtvd6uTbIJ0irToEReByiwhoShfan/lQSqqvh+rLbHynQh//5hnA+ek25 ESRxgRhTZcsU5ILj8DErpwWUXmmfneC5cxccuMFp0d5t/RPwjZ7TGU2oNf/16X9LtxCU hrmCR+8lwK6sv3rOIaT/SWV0ub9P/H3f32mNNqDm8B13BiZhd3dZukIG3eapTGfRCqyn DK6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to; bh=030nDbIsBICcdWrYsPjEcv0NM6nJ2fqt+Ehi6LiilFo=; b=T84xFUYm5m0pbJiYxH6PzdW5F6BQkbhKylARFAuqoUWNDxdNZdRujdjltLGqPrii/Y TE0Uw2hR9Qwa36JGz0Lh+iuXFm2WYwPt2UQFrjqzCcSSkCCB890kFBaiX8FmuZ+6RtrD sXEW/0/RMZ2aIOO0BODg6ml743RzS0cwNM220OroYkZICo5LHWlFOVhEPCM3dd5R8+fp DeXLfgC0ezcqWkKfRDdRvmzWg2NQv5jrFDJeaSQ0Sj8lNqaA17fnD366e64ynWfd/qql d0ckPNik6E5yS/ZWmFd0OpwXKuo25DCnzzuvwCvQnfTZcxDJ/t/bA8ENgudN7DII0nu8 lwfQ== X-Gm-Message-State: AD7BkJK7omSzgKqYqgfiS0/sPwlMOZGJpvmIeNcfaLinrzzBXEBCPhyXppCSR2dZn206/28x0jM8vcRaYQdGZA== MIME-Version: 1.0 X-Received: by 10.31.8.210 with SMTP id 201mr18764604vki.90.1458325301034; Fri, 18 Mar 2016 11:21:41 -0700 (PDT) Received: by 10.176.69.39 with HTTP; Fri, 18 Mar 2016 11:21:40 -0700 (PDT) Received: by 10.176.69.39 with HTTP; Fri, 18 Mar 2016 11:21:40 -0700 (PDT) In-Reply-To: <1BAD6DED-FE4E-47AE-99C3-C5E67C7BBE6E@gmail.com> References: <8329C3A9-25F3-4762-8286-21A9C161ADA8@classsoftware.com> <67AD7D35-6BD0-4751-8A35-27BA197894F3@gmail.com> <1BAD6DED-FE4E-47AE-99C3-C5E67C7BBE6E@gmail.com> Date: Fri, 18 Mar 2016 13:21:40 -0500 Message-ID: Subject: Re: Undo and redo in TLF From: jude To: users@flex.apache.org Content-Type: multipart/alternative; boundary=001a1142e72089040b052e56d13d --001a1142e72089040b052e56d13d Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable I like it. If I commit this fix as is it will enable redo via CTRL+ Shift+Z on Windows and Linux. If that's ok, or if I don't hear any response I'll go ahead and commit the change. CTRL+y will still perform redo. We'll have two ways to perform redo with Spark / TLF based controls. On Mar 18, 2016 7:32 AM, "Harbs" wrote: > How do you like that? It looks like I did commit that code... > > I wonder if something changed in Flash player. Either way, feel free to > add in a fix. > > On Mar 14, 2016, at 8:01 AM, jude wrote: > > > It looks like there's already code in EditManager to handle CMD+SHIFT+Z > but > > it's not hitting it because it's checking for lowercase z. The shift ke= y > > makes it uppercase so we need to check for character code 90 too. > > > > The following code in the EditManager class at line 307 adds a test for > > case 90. http://pastebin.com/gwP1WiAj > > > > > > On Sun, Mar 13, 2016 at 8:21 AM, Harbs wrote: > > > >> No. I think that was how it=E2=80=99s always worked. I was going to fi= x it so > >> cmd/shift/z worked on Mac, but I don=E2=80=99t think that ever happene= d. > >> > >> On Mar 13, 2016, at 7:35 AM, jude wrote: > >> > >>> It looks like redo does work but it is using CTRL+Y or CMD+Y on Mac. > I'm > >>> pretty sure it was CMD+Z for Undo and CMD+SHIFT+Z for Redo. Does anyo= ne > >>> else recall this it working with this key combination? > >>> > >>> On Tue, Jan 26, 2016 at 12:54 PM, jude > wrote: > >>> > >>>> Yeah, I'll come up with some more test cases. > >>>> On Jan 24, 2016 1:44 AM, "Harbs" wrote: > >>>> > >>>>> Jude, > >>>>> > >>>>> Can you test this against different Flex builds? I wonder if there > was > >>>>> some side effect of TLF changes. > >>>>> > >>>>> FWIW, redo works for me in the current build using raw TLF, but I > have > >>>>> not tried with Spark components. > >>>>> > >>>>> On Jan 16, 2016, at 3:22 AM, jude wrote: > >>>>> > >>>>>> I remember it working in previous versions. I don't think it was > >>>>> introduced > >>>>>> in 4.15. I'm wondering if it was introduced in a recent AIR or Fla= sh > >>>>>> Player. Did it work for you? > >>>>>> > >>>>>> On Fri, Jan 15, 2016 at 12:47 AM, Justin Mclean < > >>>>> justin@classsoftware.com> > >>>>>> wrote: > >>>>>> > >>>>>>> Hi, > >>>>>>> > >>>>>>>> Does undo and more importantly redo work for everyone else? > >>>>>>> > >>>>>>> Does it work in previous versions? i.e. is this a regression or a= n > >>>>> issue > >>>>>>> that has existed for a while? > >>>>>>> > >>>>>>> Thanks, > >>>>>>> Justin > >>>>> > >>>>> > >> > >> > > --001a1142e72089040b052e56d13d--