flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alex Harui (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (FLEX-35345) incorrect output for super call in getter
Date Fri, 04 Aug 2017 15:07:00 GMT

     [ https://issues.apache.org/jira/browse/FLEX-35345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Alex Harui resolved FLEX-35345.
-------------------------------
       Resolution: Fixed
    Fix Version/s: Apache FalconJX 0.9.0

9827b9f9090cb533cf017bbdf3dbc4b0f2bddb66

> incorrect output for super call in getter
> -----------------------------------------
>
>                 Key: FLEX-35345
>                 URL: https://issues.apache.org/jira/browse/FLEX-35345
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: FalconJX
>    Affects Versions: Apache FalconJX 0.8.0
>            Reporter: Harbs
>             Fix For: Apache FalconJX 0.9.0
>
>
>         COMPILE::JS
> 		public function get defaultPrevented():Boolean
> 		{
> 			return wrappedEvent ? wrappedEvent.defaultPrevented : super.isDefaultPrevented();
> 		}
>         COMPILE::JS
> 		override public function isDefaultPrevented():Boolean
> 		{
> 			return defaultPrevented;
> 		}
> compiles to:
> org.apache.flex.events.KeyboardEvent.prototype.get__defaultPrevented = function() {
>   return this.wrappedEvent ? this.wrappedEvent.defaultPrevented : org.apache.flex.events.KeyboardEvent.superClass_.get__defaultPrevented.apply(this);
> };
> org.apache.flex.events.KeyboardEvent.prototype.isDefaultPrevented = function() {
>   return this.defaultPrevented;
> };
> In case the problem was not obvious, the first function should have looked like this:
> return this.wrappedEvent ? this.wrappedEvent.defaultPrevented : org.apache.flex.events.KeyboardEvent.superClass_.isDefaultPrevented.apply(this);
> instead of using (the non-existent) get__defaultPrevented function.
> Reversing the functions to use super in the normal function behaves as I’d expect:
>         COMPILE::JS
> 		public function get defaultPrevented():Boolean
> 		{
>             return isDefaultPrevented();
> 		}
>         COMPILE::JS
> 		override public function isDefaultPrevented():Boolean
> 		{
> 			return wrappedEvent ? wrappedEvent.defaultPrevented : super.isDefaultPrevented();
> 		}
> Compiles to:
> org.apache.flex.events.KeyboardEvent.prototype.get__defaultPrevented = function() {
>   return this.isDefaultPrevented();
> };
> org.apache.flex.events.KeyboardEvent.prototype.isDefaultPrevented = function() {
>   return this.wrappedEvent ? this.wrappedEvent.defaultPrevented : org.apache.flex.events.KeyboardEvent.superClass_.isDefaultPrevented.apply(this);
> };



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message