flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Josh Tynjala (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-35307) Maven distribution does not include framework source files in frameworks/projects
Date Fri, 12 May 2017 16:02:04 GMT

    [ https://issues.apache.org/jira/browse/FLEX-35307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008304#comment-16008304
] 

Josh Tynjala commented on FLEX-35307:
-------------------------------------

> AFAICT, Maven does not use flex-config.xml.

I'm sure you're right. However, the Maven distribution still bundles *-config.xml files because
they are required to make a valid distribution that can be used by an IDE. The current distribution
does not work in an IDE because the *-config.xml files that the Maven distribution bundles
are no longer valid after the dual merge.

>  and did not see any source code, not just Basic.

Correct. I used Basic as an example. All source code in frameworks/projects is missing.

> Maven distribution does not include framework source files in frameworks/projects
> ---------------------------------------------------------------------------------
>
>                 Key: FLEX-35307
>                 URL: https://issues.apache.org/jira/browse/FLEX-35307
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: FlexJS
>    Affects Versions: Apache FlexJS 0.8.0
>            Reporter: Josh Tynjala
>
> The original ActionScript source files and related resources (like the manifest.xml files)
for each project in the framework should be included in a distribution of FlexJS created with
Maven.
> For example, the files in this directory are missing from the distribution:
> frameworks/projects/Basic/src/main
> Additionally, this change will be helpful for consolidating the manifest.xml files used
in the builds. The Maven distribution currently duplicates the manifest.xml files from each
project in frameworks/projects to distribution/src/main/resources/manifests. This causes files
like flex-config.xml to need special modifications for the Maven distribution to use different
paths. If the Maven distribution includes the manifest.xml files in their original location
(which correctly follows the Maven directory structure, like Basic/src/main/resources/basic-manifest.xml),
then it can use the same flex-config.xml as the Ant distribution.
> Ideally, both would bundle the same flex-config.xml file from the same location in the
repository (like the manifest.xml files, the -config.xml files are duplicated in distribution/src/main/resources
for Maven). However, even if the files come from different locations in the repo for Ant and
Maven, if their contents can be exactly the same, that would still be an improvement. As it
is, the manifest files need to be duplicated, then the -config.xml files, and then the -config.xml
files need to be modified.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Mime
View raw message