Mailing-List: contact issues-help@flex.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@flex.apache.org
Date: Thu, 27 Apr 2017 21:20:04 +0000 (UTC)
From: "Alex Harui (JIRA)" <jira@apache.org>
To: issues@flex.apache.org
Message-ID: <JIRA.13067523.1493327467000.72156.1493328004239@Atlassian.JIRA>
In-Reply-To: <JIRA.13067523.1493327467000@Atlassian.JIRA>
References: <JIRA.13067523.1493327467000@Atlassian.JIRA> <JIRA.13067523.1493327467107@jira-lw-us.apache.org>
Subject: [jira] [Commented] (FLEX-35300) Could not find file for class:
 Error
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 27 Apr 2017 21:20:09 -0000


    [ https://issues.apache.org/jira/browse/FLEX-35300?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1598=
7698#comment-15987698 ]=20

Alex Harui commented on FLEX-35300:
-----------------------------------

What is the output JS for CustomError?  There should not be a goog.require =
for Error assuming Error is defined in an external-library-path SWC.  Could=
 some other SWC on the regular library-path have baked in an Error class?

GoogDepsWriter should not be seeing goog.requires for native classes so it =
shouldn't be trying to find files for them.

> Could not find file for class: Error
> ------------------------------------
>
>                 Key: FLEX-35300
>                 URL: https://issues.apache.org/jira/browse/FLEX-35300
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: FalconJX
>    Affects Versions: Apache FalconJX 0.8.0
>            Reporter: Josh Tynjala
>
> Create the following class and instantiate it with {{new CustomError()}}
> {code:title=3DCustomError.as}
> package
> {
> =09public class CustomError extends Error
> =09{
> =09}
> }
> {code}
> When you try to compile, the following error will appear in the compiler =
output:
> {code}
> Could not find file for class: Error
> File not found: Error
> org.apache.flex.compiler.internal.graph.GoogDepsWriter.addDeps(GoogDepsWr=
iter.java:366)org.apache.flex.compiler.internal.graph.GoogDepsWriter.addDep=
s(GoogDepsWriter.java:382)org.apache.flex.compiler.internal.graph.GoogDepsW=
riter.addDeps(GoogDepsWriter.java:391)org.apache.flex.compiler.internal.gra=
ph.GoogDepsWriter.addDeps(GoogDepsWriter.java:391)org.apache.flex.compiler.=
internal.graph.GoogDepsWriter.buildDB(GoogDepsWriter.java:206)org.apache.fl=
ex.compiler.internal.graph.GoogDepsWriter.getListOfFiles(GoogDepsWriter.jav=
a:96)org.apache.flex.compiler.internal.codegen.mxml.flexjs.MXMLFlexJSPublis=
her.publish(MXMLFlexJSPublisher.java:319)org.apache.flex.compiler.clients.M=
XMLJSCNode.compile(MXMLJSCNode.java:380)org.apache.flex.compiler.clients.MX=
MLJSCNode._mainNoExit(MXMLJSCNode.java:238)org.apache.flex.compiler.clients=
.MXMLJSCNode.mainNoExit(MXMLJSCNode.java:195)org.apache.flex.compiler.clien=
ts.MXMLJSC._mainNoExit(MXMLJSC.java:365)org.apache.flex.compiler.clients.MX=
MLJSC.mainNoExit(MXMLJSC.java:282)org.apache.flex.compiler.clients.MXMLJSC.=
staticMainNoExit(MXMLJSC.java:242)org.apache.flex.compiler.clients.MXMLJSC.=
main(MXMLJSC.java:224)
> {code}
> It appears to be related to the following code in GoogDepsWriter.java (an=
d the section above for {{@implements}} is probably also affected):
> {code:Java}
> c =3D line.indexOf("@extends");
> if (c > -1)
> {
> =09if (fi.impls =3D=3D null)
> =09=09fi.impls =3D new ArrayList<String>();
> =09c2 =3D line.indexOf("}", c);
> =09String impl =3D line.substring(c + 10, c2);
> =09fi.impls.add(impl);
> }
> {code}
> Using NativeUtils.isJSNative() seems to help for this particular case wit=
h the Error class:
> {code:Java}
> c =3D line.indexOf("@extends");
> if (c > -1)
> {
> =09if (fi.impls =3D=3D null)
> =09=09fi.impls =3D new ArrayList<String>();
> =09c2 =3D line.indexOf("}", c);
> =09String impl =3D line.substring(c + 10, c2);
> =09if(!NativeUtils.isJSNative(impl))
> =09{
> =09=09fi.impls.add(impl);
> =09}
> }
> {code}
> I don't think that this is the correct solution, though. Other classes de=
fined in externs can also give us this error and return false for isJSNativ=
e(). For instance, I randomly tried extending child_process.ChildProcess fr=
om node.swc, and I got the same error.
> {code}
> Could not find file for class: child_process.ChildProcess
> File not found: child_process.ChildProcess
> org.apache.flex.compiler.internal.graph.GoogDepsWriter.addDeps(GoogDepsWr=
iter.java:367)org.apache.flex.compiler.internal.graph.GoogDepsWriter.addDep=
s(GoogDepsWriter.java:383)org.apache.flex.compiler.internal.graph.GoogDepsW=
riter.addDeps(GoogDepsWriter.java:392)org.apache.flex.compiler.internal.gra=
ph.GoogDepsWriter.buildDB(GoogDepsWriter.java:207)org.apache.flex.compiler.=
internal.graph.GoogDepsWriter.getListOfFiles(GoogDepsWriter.java:97)org.apa=
che.flex.compiler.internal.codegen.mxml.flexjs.MXMLFlexJSPublisher.publish(=
MXMLFlexJSPublisher.java:319)org.apache.flex.compiler.clients.MXMLJSCNode.c=
ompile(MXMLJSCNode.java:380)org.apache.flex.compiler.clients.MXMLJSCNode._m=
ainNoExit(MXMLJSCNode.java:238)org.apache.flex.compiler.clients.MXMLJSCNode=
.mainNoExit(MXMLJSCNode.java:195)org.apache.flex.compiler.clients.MXMLJSC._=
mainNoExit(MXMLJSC.java:365)org.apache.flex.compiler.clients.MXMLJSC.mainNo=
Exit(MXMLJSC.java:282)org.apache.flex.compiler.clients.MXMLJSC.staticMainNo=
Exit(MXMLJSC.java:242)org.apache.flex.compiler.clients.MXMLJSC.main(MXMLJSC=
.java:224)
> {code}
> Something more robust than NativeUtils.isJSNative() that accounts for whe=
ther the class is extern seems required here.
> This issue was not present in FlexJS 0.7.0. The issue exists in both the =
develop and dual branches.


--
This message was sent by Atlassian JIRA
(v6.3.15#6346)