flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mihai Chira (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLEX-34853) ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change
Date Wed, 09 Nov 2016 13:42:59 GMT

     [ https://issues.apache.org/jira/browse/FLEX-34853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Mihai Chira updated FLEX-34853:
-------------------------------
    Description: 
{code}
            _sut.addAll(from4To0); //values["name"]: Object4, Object3, Object2, Object1, Object0

            const sortByIndexAscending:Sort = new Sort();
            sortByIndexAscending.fields = [new SortField("index", false, false, true)];
            _sut.sort = sortByIndexAscending;
            _sut.refresh(); //should be: Object0, Object1, Object2, Object3, Object4

            //when
            sortByIndexAscending.fields = [new SortField("name", false, true, false)]; //should
have no effect

            //then
            assertThat(_sut.getItemIndex(from4To0.getItemAt(i)) != -1); //an RTE is thrown
here
{code}

*Expected behaviour*: the collection should resort when any of the flags of its {{Sort}} object
changes, or whenever one of the flags of the Sort's {{SortField}} list changes. That, or {{Sort}}
and {{SortField}} should be made immutable, to prevent this scenario in the first place.

  was:
{code}
            _sut.addAll(from4To0); //values["name"]: Object4, Object3, Object2, Object1, Object0

            const sortByIndexAscending:Sort = new Sort();
            sortByIndexAscending.fields = [new SortField("index", false, false, true)];
            _sut.sort = sortByIndexAscending;
            _sut.refresh(); //should be: Object0, Object1, Object2, Object3, Object4

            //when
            sortByIndexAscending.fields = [new SortField("name", false, true, false)]; //should
have no effect

            //then
            assertThat(_sut.getItemIndex(from4To0.getItemAt(i)) != -1); //an RTE is thrown
here
{code}

*Expected behaviour*: the collection should redo the sort when any of its sort's flags changes,
or whenever one of the sortFields' flags changes.

*Note*: the solution being pursued is to make Sort and SortField immutable. See more of the
discussion [here|http://mail-archives.apache.org/mod_mbox/flex-dev/201505.mbox/%3CCAP1cEXG8%2BM1AXM_5CPVJseTpY3cppgRJY%2BnuHJ1gL-VcB%3D3z3A%40mail.gmail.com%3E].


> ListCollectionView.getItemIndex throws RTE when the Sort's sortFields change
> ----------------------------------------------------------------------------
>
>                 Key: FLEX-34853
>                 URL: https://issues.apache.org/jira/browse/FLEX-34853
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Collections, Spark: Sort and SortField
>    Affects Versions: Apache Flex 4.14.1
>            Reporter: Mihai Chira
>            Assignee: Mihai Chira
>             Fix For: Apache Flex 4.15.0
>
>
> {code}
>             _sut.addAll(from4To0); //values["name"]: Object4, Object3, Object2, Object1,
Object0
>             const sortByIndexAscending:Sort = new Sort();
>             sortByIndexAscending.fields = [new SortField("index", false, false, true)];
>             _sut.sort = sortByIndexAscending;
>             _sut.refresh(); //should be: Object0, Object1, Object2, Object3, Object4
>             //when
>             sortByIndexAscending.fields = [new SortField("name", false, true, false)];
//should have no effect
>             //then
>             assertThat(_sut.getItemIndex(from4To0.getItemAt(i)) != -1); //an RTE is thrown
here
> {code}
> *Expected behaviour*: the collection should resort when any of the flags of its {{Sort}}
object changes, or whenever one of the flags of the Sort's {{SortField}} list changes. That,
or {{Sort}} and {{SortField}} should be made immutable, to prevent this scenario in the first
place.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message