flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Georgios Galyfianakis (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (FLEX-28848) DataGrid.borderVisible = false causes alignment issues
Date Mon, 02 Nov 2015 22:57:27 GMT

     [ https://issues.apache.org/jira/browse/FLEX-28848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Georgios Galyfianakis updated FLEX-28848:
-----------------------------------------
    Attachment: patch FLEX-28848.png
                patch FLEX-28848.diff

patch proposal..

> DataGrid.borderVisible = false causes alignment issues
> ------------------------------------------------------
>
>                 Key: FLEX-28848
>                 URL: https://issues.apache.org/jira/browse/FLEX-28848
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Spark: DataGrid
>    Affects Versions: Adobe Flex SDK Previous
>         Environment: Affected OS(s): All OS Platforms
> Affected OS(s): All OS Platforms
> Browser: Other (specify version)
> Language Found: English
>            Reporter: Adobe JIRA
>            Priority: Minor
>         Attachments: patch FLEX-28848.diff, patch FLEX-28848.png
>
>
> Steps to reproduce:
> 1. Create a DataGrid and set borderVisible to false.
>  
>  Actual Results: The column header column separators and grid separators will now not
line up correctly.
>  
>  
>  Expected Results: The should align correctly
>  
>  
>  Workaround (if any): Set borderAlpha to 0 instead of setting borderVisible to false.
> This issue is down to the fact that when there is a border the scroller has its minViewportInset
property set to 1, so the Grid inside it has a border of one pixel around the edge. When borderVisible
is set to false the minViewportInset property set to 0, therefore leaving no border around
the edge of the Grid.....
> .... but GridColumnHeaderGroup always has a padding value of 1.
> <s:GridColumnHeaderGroup id="columnHeaderGroup"
> 								 paddingLeft="1" paddingTop="1" paddingRight="1" minHeight="21" 
> 								 columnSeparator="{headerColumnSeparator}"
> 								 headerRenderer="{headerRenderer}"/>
> The following code would fix this...
> override protected function updateDisplayList(unscaledWidth:Number, unscaledHeight:Number):void
> {
> 	if (getStyle("borderVisible") == true)
> 	{
> 		border.visible = true;
> 		background.left = background.top = background.right = background.bottom = 1;
> 		scroller.minViewportInset = 1;
> 		columnHeaderGroup.paddingLeft = columnHeaderGroup.paddingRight = 1;
> 	}
> 	else
> 	{
> 		border.visible = false;
> 		background.left = background.top = background.right = background.bottom = 0;
> 		scroller.minViewportInset = 0;
> 		columnHeaderGroup.paddingLeft = columnHeaderGroup.paddingRight = 0;
> 	}
> 	
> 	borderStroke.color = getStyle("borderColor");
> 	borderStroke.alpha = getStyle("borderAlpha");
> 	
> 	super.updateDisplayList(unscaledWidth, unscaledHeight);
> }



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message