flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gareth Daniel Smith (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34772) Add padding property to VerticalLayout and HorizontalLayout
Date Wed, 18 Mar 2015 09:48:38 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366893#comment-14366893
] 

Gareth Daniel Smith commented on FLEX-34772:
--------------------------------------------

I think there could be some unexpected behavior with how this feature interacts with the other
padding properties:

x.padding = 4; // OK
x.paddingLeft = 2; // OK
x.padding = 4; // not OK - this will have no effect because x._padding is already 4

To fix this, maybe the padding{Left, Right, Top, Bottom} setters should set _padding to NaN.



> Add padding property to VerticalLayout and HorizontalLayout
> -----------------------------------------------------------
>
>                 Key: FLEX-34772
>                 URL: https://issues.apache.org/jira/browse/FLEX-34772
>             Project: Apache Flex
>          Issue Type: New Feature
>          Components: Spark: HorizontalLayout, Spark: TileLayout, Spark: VerticalLayout
>    Affects Versions: Apache Flex 4.14.0
>            Reporter: Dany Dhondt
>            Assignee: OmPrakash Muppirala
>            Priority: Minor
>              Labels: feature, patch
>             Fix For: Apache Flex 4.14.1
>
>         Attachments: spark1.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> It's tedious to keep on typing paddingTop=5, etc. when all you want to do is add padding
around all borders. Adding the property 'padding' which basically sets the same padding value
for all sides is much more comfortable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message