flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "shane doolan (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (FLEX-34759) ArrayList/ArrayCollection performance improvements
Date Tue, 24 Feb 2015 23:28:04 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14335653#comment-14335653
] 

shane doolan edited comment on FLEX-34759 at 2/24/15 11:27 PM:
---------------------------------------------------------------

I agree, and its would defiantly be the fastest way. From what I understand this is (was?)
not the case for BlazeDS, see https://issues.apache.org/jira/browse/FLEX-16414

We are using an old version of Fluorine and unfortunately its DataSet de-serialisation also
does not init an array first, it uses addItem. That's the next optimisation on my hit list.



was (Author: sdoolan):
I agree, and its would definatly be the fastest way. From what I understand this is (was?)
not the case for BlazeDS, see https://issues.apache.org/jira/browse/FLEX-16414

We are using an old version of Fluorine and unfortunately its DataSet de-serialisation also
does not init an array first, it uses addItem. That's the next optimisation on my hit list.


> ArrayList/ArrayCollection performance improvements
> --------------------------------------------------
>
>                 Key: FLEX-34759
>                 URL: https://issues.apache.org/jira/browse/FLEX-34759
>             Project: Apache Flex
>          Issue Type: Improvement
>          Components: Collections
>            Reporter: shane doolan
>              Labels: newbie, patch, performance
>         Attachments: FLEX-34759.patch, FLEX-34759_v2.patch, ListProfiler.zip
>
>
> Considerable performance gains can be achieved by avoiding the use of array splice when
adding/removing items from the start or end of the source array in ArrayList.
> eg/ in ArrayList.addItemAt, replace this:
> {code}
> source.splice(index, 0, item);
> {code}
> with this:   
> {code} 
> if (index == length)
>     source.push(item);
> else if (index == 0)
>     source.unshift(item);
> else
>     source.splice(index, 0, item);
> {code}
> ArrayList.addItem is 10x faster when adding non IEventDispatcher's, and 6x faster for
IEventDispatcher's. There is a small trade-off when performing random access add/removes,
where the extra logic slightly increases the times taken. 
> Since ArrayCollection wraps an ArrayList by default and ArrayCollection.addItem is used
extensively within our apps, this patch has provided considerable performance improvements.
> See profiling results below:
> *Original ArrayList, adding/removing 100k ints*
> * addItemAtStart = "2434ms"
> * addItemAtEnd = "2501ms"
> * addItemAtRandom = "3149ms"
> * removeItemAtStart = "3098ms"
> * removeItemAtEnd = "2401ms"
> * removeItemAtRandom = "2606ms"
> *Original ArrayList, adding/removing 100k IEventDispatcher's*
> * addItemAtStart = "2501ms"
> * addItemAtEnd = "2505ms"
> * addItemAtRandom = "3165ms"
> * removeItemAtStart = "3053ms"
> * removeItemAtEnd = "2453ms"
> * removeItemAtRandom = "2709ms"
> *Patched ArrayList, adding/removing 100k ints*
> * addItemAtStart = "226ms"
> * addItemAtEnd = *"213ms"*
> * addItemAtRandom = "3281ms"
> * removeItemAtStart = "803ms"
> * removeItemAtEnd = "219ms"
> * removeItemAtRandom = "2808ms"
> *Patched ArrayList, adding/removing 100k IEventDispatcher's*
> * addItemAtStart = "415ms"
> * addItemAtEnd = *"488ms"*
> * addItemAtRandom = "3662ms"
> * removeItemAtStart = "878ms"
> * removeItemAtEnd = "264ms"
> * removeItemAtRandom = "2949ms"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message