flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Devin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34741) Spark DataGrid Drag and Drop non functioning
Date Fri, 06 Feb 2015 21:33:36 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309963#comment-14309963
] 

Devin commented on FLEX-34741:
------------------------------

Here's everything I had to do to fix this. Not well tested.

DataGrid.calculateDropLocation()
it needs to call calculateDropLocation() in the GridViewLayout, not the GridLayout.
And that method needs to be public or protected. Since it's private, I had to make the change
in all the drag handlers instead of that one spot.

All the drag handlers in DataGrid need to call showDropIndicator(), hideDropIndicator(), and
destroyDropIndicator() on the GridViewLayout, not the GridLayout.

DataGrid.createDropIndicator()
The dropIndicator needs to be set on the GridViewLayout, not the GridLayout. 





> Spark DataGrid Drag and Drop non functioning
> --------------------------------------------
>
>                 Key: FLEX-34741
>                 URL: https://issues.apache.org/jira/browse/FLEX-34741
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Spark: DataGrid
>    Affects Versions: Apache Flex 4.14.0
>            Reporter: Devin
>              Labels: drag&drop
>
> Description
> Dropping a dragged item onto the grid does not work. When calculating the DropLocation
(in dragEnter, dragOver, dragDrop handlers) it falls through to LayoutBase.calculateDropIndex
which simply executes "return target.numElements;" That's clearly not how the dropIndex should
be calculated on the grid. The GridLayout class should be overriding this method and calculating
it correctly.
> Furthermore, upon trying to fix this issue (which is more complicated than it should
be because DataGrid.calculateDropPosition() is marked as private) the DataGrid.calculateDropPosition()
does not perform a null check on the DropLocation (which is valid value).
> Steps to Reproduce
> 1. Create a DataGrid with dragEnabled, dragMoveEnabled, and dropEnabled all set to true.
> 2. Try dragging rows around and dropping them.
> Environment
> Windows 8, Apache Flex 4.14
> Expected Behavior
> Seeing the drop indicator.
> The expected behavior of dragging a row and dropping it in another location.
> Actual Behavior
> No drop indicator. Dropping a row does nothing.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message