flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34712) Callout loses anchor to CalloutButton while callout open and screen rotates
Date Wed, 14 Jan 2015 11:37:34 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276814#comment-14276814
] 

ASF GitHub Bot commented on FLEX-34712:
---------------------------------------

GitHub user kevinGodell opened a pull request:

    https://github.com/apache/flex-sdk/pull/14

    FLEX-34712 bug fix for callout positioning on android device rotation

    Created function queued_systemManager_resizeHandler() and moved code from systemManager_resizeHandler()
to that new function. New function is called via callLater() from original systemManager_resizeHandler(),
allowing for calculatePopUpPosition() to get correct x and y.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kevinGodell/flex-sdk develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flex-sdk/pull/14.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14
    
----
commit b5e1c0b1ba007709194cd61e2cf117959b467828
Author: Kevin Godell <kevin.godell@gmail.com>
Date:   2015-01-08T02:41:17Z

    Fix for Callout positioning on rotate FLEX-34712
    
    Bug shows itself on device, and not in the simulator. When device is rotated, updatePopupPosition()
is called too soon and positions to incorrect location. This fix adds a flag after detecting
stageOrientationChange. The flag is read in updateDisplayList() and queues updatePopUpPostion()
by calling it using callLater().

commit 6e0a356fc1d9297f6f7cc5a0b72cc51cbbabd49f
Author: Kevin Godell <kevin.godell@gmail.com>
Date:   2015-01-10T01:26:41Z

    Revert "Fix for Callout positioning on rotate FLEX-34712"
    
    This reverts commit b5e1c0b1ba007709194cd61e2cf117959b467828.

commit 706eb343b83085fdf339026cdb8f27124896f63d
Author: Kevin Godell <kevin.godell@gmail.com>
Date:   2015-01-10T04:27:41Z

    FLEX-34712 bug fix
    
    Popup is positioned incorrectly when called by systemManager_resizeHandler because calculatePopUpPosition()'s
x or y may not be correct at that moment. Delaying the code call via callLater() solved the
problem and allows the open popup to snap to its new position after device screen is rotated.

commit ba0144f5f9d97d02246dfa4b89b21188ae060199
Author: Kevin Godell <kevin.godell@gmail.com>
Date:   2015-01-10T12:58:56Z

    FLEX-34712 bug fix for callout
    
    Created function queued_systemManager_resizeHandler() and moved code from systemManager_resizeHandler()
to that new function. New function is called via callLater() from original systemManager_resizeHandler(),
allowing for calculatePopUpPosition() to get correct x and y.

commit 81618ab0285c7aa2143528239613e7c11eeca99d
Author: Kevin Godell <kevin.godell@gmail.com>
Date:   2015-01-14T00:42:53Z

    Update Callout.as

----


> Callout loses anchor to CalloutButton while callout open and screen rotates 
> ----------------------------------------------------------------------------
>
>                 Key: FLEX-34712
>                 URL: https://issues.apache.org/jira/browse/FLEX-34712
>             Project: Apache Flex
>          Issue Type: Bug
>          Components: Mobile: Callout / CalloutButton
>    Affects Versions: Apache Flex 4.14.0
>         Environment: windows 7, flashbuilder 4.6, flex 4.14, air 15
>            Reporter: kevin godell
>         Attachments: calloutButtonCalloutPositionOnResize.fxp
>
>
> When debugging on android device, rotating device from landscape to portrait and then
back again causes callout to lose its positioning to the calloutbutton. It works good on the
simulator, but on the device, it seems that the positioning is called before the screen finishes
rotating. Tested on 3 different android devices with android 2.3.6, 4.2.2, and 4.4.
> workaround: patching callout.as 
> in systemManager_resizeHandler, change invalidatePosition() to callLater(invalidatePosition).
This gives the necessary delay to allow the popup to position itself in the correct location.
It looks a little buggy as it moves from the old position to the new position, but atleast
it gets to the right spot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message