Return-Path: X-Original-To: apmail-flex-issues-archive@minotaur.apache.org Delivered-To: apmail-flex-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 645F117755 for ; Thu, 30 Oct 2014 16:07:34 +0000 (UTC) Received: (qmail 81795 invoked by uid 500); 30 Oct 2014 16:07:34 -0000 Delivered-To: apmail-flex-issues-archive@flex.apache.org Received: (qmail 81768 invoked by uid 500); 30 Oct 2014 16:07:34 -0000 Mailing-List: contact issues-help@flex.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@flex.apache.org Delivered-To: mailing list issues@flex.apache.org Received: (qmail 81758 invoked by uid 99); 30 Oct 2014 16:07:34 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 30 Oct 2014 16:07:34 +0000 Date: Thu, 30 Oct 2014 16:07:33 +0000 (UTC) From: "Andrii Radistao (JIRA)" To: issues@flex.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (FLEX-34630) spark.components.Alert#partRemoved() implementation makes wrong super.partAdded() call MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/FLEX-34630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrii Radistao updated FLEX-34630: ----------------------------------- Attachment: (was: TestSparkAlertBuilt.zip) > spark.components.Alert#partRemoved() implementation makes wrong super.partAdded() call > -------------------------------------------------------------------------------------- > > Key: FLEX-34630 > URL: https://issues.apache.org/jira/browse/FLEX-34630 > Project: Apache Flex > Issue Type: Bug > Affects Versions: Apache Flex 4.13.0 > Environment: Flash Player 15.0.0.189 (debug version), Opera, Windows 7, SDK 4.13.0 (20140701) and WIN_flex4.13.0-air15.0.0.249 > Reporter: Andrii Radistao > Labels: Alert, Skin, partAdded, partRemoved, spark > Attachments: TestSparkAlert.zip > > > _partRemoved_ implementation for {{spark.components.Alert}} probably has wrong super method call: _partAdded_ instead of _partRemoved_. > {code:title=Alert.as: 642|borderStyle=solid} > override protected function partRemoved(partName:String, instance:Object):void { > super.partAdded(partName, instance); > if (partName == "buttonGroup") { > destroyButtons(Group(instance)); > } > } > {code} > *This implementation cause an exception if you change component's skin at runtime* (see the attachment): > [Fault] exception, information=ReferenceError: Error #1069: Property autoLayout not found on Number and there is no default value. > at spark.components::SkinnableContainer/partAdded()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/SkinnableContainer.as:970] > at spark.components::Panel/partAdded()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/Panel.as:554] > at spark.components::Alert/partRemoved()[/Users/aharui/release4.13.0/frameworks/projects/experimental/src/spark/components/Alert.as:643] > at spark.components.supportClasses::SkinnableComponent/clearSkinParts()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as:779] > at spark.components.supportClasses::SkinnableComponent/detachSkin()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as:813] > at spark.components.supportClasses::SkinnableComponent/validateSkinChange()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as:453] > at spark.components.supportClasses::SkinnableComponent/commitProperties()[/Users/aharui/release4.13.0/frameworks/projects/spark/src/spark/components/supportClasses/SkinnableComponent.as:472] > at mx.core::UIComponent/validateProperties()[/Users/aharui/release4.13.0/frameworks/projects/framework/src/mx/core/UIComponent.as:8751] > at mx.managers::LayoutManager/validateProperties()[/Users/aharui/release4.13.0/frameworks/projects/framework/src/mx/managers/LayoutManager.as:605] > at mx.managers::LayoutManager/doPhasedInstantiation()[/Users/aharui/release4.13.0/frameworks/projects/framework/src/mx/managers/LayoutManager.as:821] > at mx.managers::LayoutManager/doPhasedInstantiationCallback()[/Users/aharui/release4.13.0/frameworks/projects/framework/src/mx/managers/LayoutManager.as:1188] -- This message was sent by Atlassian JIRA (v6.3.4#6332)