flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mihai Chira (JIRA)" <j...@apache.org>
Subject [jira] [Created] (FLEX-34609) ContainerController has superfluous null checks for _container
Date Wed, 15 Oct 2014 16:21:33 GMT
Mihai Chira created FLEX-34609:
----------------------------------

             Summary: ContainerController has superfluous null checks for _container
                 Key: FLEX-34609
                 URL: https://issues.apache.org/jira/browse/FLEX-34609
             Project: Apache Flex
          Issue Type: Improvement
          Components: .Unspecified - Framework
    Affects Versions: Apache Flex 4.13.0
            Reporter: Mihai Chira
            Assignee: Mihai Chira
            Priority: Minor
             Fix For: Apache Flex 4.14.0


ContainerController sometimes checks whether _container is null, yet most of the times it
doesn't.

However, _container is only changed by the initialize() method, which assumes it's not null
(through "_container.doubleClickEnabled = true"). Initialize() is only called by the constructor,
which in turn is only called by the constructor of TextLineFactoryBase with a non-null Sprite.

Therefore we could safely remove the few occurrences in which _container is checked for the
null value.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message