flex-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Neil Madsen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLEX-34605) Code formatting and cleanup
Date Sat, 25 Oct 2014 13:10:34 GMT

    [ https://issues.apache.org/jira/browse/FLEX-34605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14184086#comment-14184086
] 

Neil Madsen commented on FLEX-34605:
------------------------------------

Just adding in this note from Alex Harui.

>-        import AntClasses; AntClasses;
>+        import AntClasses;
This one worries me.  I should have left a comment on it, but the second “AntClasses”
force-links all of the ant task handlers into the app.  I’m not sure I’ve listed them
any other way that would link them in.  Did an ant_on_air install actually work after this
change?  I think you have to try 4.13 or FlexJS as all older SDKs are not using ant_on_air
right now.

Justin, can you to revert this patch, or at least that portion?


> Code formatting and cleanup
> ---------------------------
>
>                 Key: FLEX-34605
>                 URL: https://issues.apache.org/jira/browse/FLEX-34605
>             Project: Apache Flex
>          Issue Type: Task
>          Components: InstallApacheFlex
>            Reporter: Neil Madsen
>            Assignee: Justin Mclean
>            Priority: Trivial
>              Labels: easyfix, formatting
>             Fix For: Install Apache Flex 3.2
>
>         Attachments: InstallApacheFlex.mxml, patch-CODE-CLEANUP.diff
>
>
> Mixture of spaces and tabs. Method signature braces inconsistent.
> Just like to bring it closer to the formatting guidelines of the project.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message